make builder image version consistent with glide.lock hash #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lluunn
reviewed
Sep 24, 2018
| COPY ./ $GOPATH/src/github.com/kubeflow/kubeflow/bootstrap/ | ||
|
|
||
| RUN go build ${GOLANG_GCFLAGS} -i -o /opt/kubeflow/bootstrapper \ | ||
| ${GOPATH}/src/github.com/kubeflow/kubeflow/bootstrap/cmd/bootstrap/main.go | ||
|
|
||
| FROM golang:${GOLANG_VERSION} AS build |
There was a problem hiding this comment.
what's this line for?
Do we need to build after this line?
| @@ -18,10 +18,3 @@ RUN mkdir -p $GOPATH/src/github.com/kubeflow/kubeflow/bootstrap | |||
| COPY ./glide* $GOPATH/src/github.com/kubeflow/kubeflow/bootstrap/ | |||
| RUN cd $GOPATH/src/github.com/kubeflow/kubeflow/bootstrap/ && \ | |||
| glide install -v | |||
|
|
|||
There was a problem hiding this comment.
So builder only containers vendor, and we only need to rebuild it if glide is changed, right?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* add kfp-tekton deployment and update IBM stacks * update owner file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify test and local dev.
Old method:
go pkg was compiled in builder image:
make buildNew method:
builder image is cache of glide & vendor dir,
glide.lockfile 100% determines the content of builder image. So use hash code ofglide.lockas builder image version. And resolve 1,2,3 of old methodThis change is