Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Katib 0.3 cherrypick #2011

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Katib 0.3 cherrypick #2011

merged 1 commit into from
Dec 5, 2018

Conversation

texasmichelle
Copy link
Member

@texasmichelle texasmichelle commented Nov 29, 2018 •
edited by jlewi
Loading

Cherrypick #1955

This change is Reviewable

@YujiOshima @texasmichelle
Katib 0.3 cherrypick
d8c95fe 
update katib components (kubeflow#1955)

* update katib components

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* format jsonnet

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix metrics collector image

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix test

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@texasmichelle
Copy link
Member Author

/assign @YujiOshima

@jlewi
Copy link
Contributor

jlewi commented Dec 4, 2018

/assign @richardsliu
/unassign @jlewi

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@texasmichelle
Copy link
Member Author

Do we need an LGTM from @YujiOshima?

@YujiOshima
Copy link
Contributor

@texasmichelle Thank you! LGTM

@texasmichelle
Copy link
Member Author

what's the command for removing the cla:no label?

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@richardsliu
Copy link
Contributor

@texasmichelle I removed the cla: no label manually.

@k8s-ci-robot k8s-ci-robot merged commit e7ecb1c into kubeflow:v0.3-branch Dec 5, 2018
@texasmichelle texasmichelle deleted the v0.3-cherrypick-katib branch December 6, 2018 02:47
@texasmichelle
Copy link
Member Author

excellent - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjangoPeng DjangoPeng Awaiting requested review from DjangoPeng

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@YujiOshima YujiOshima

@richardsliu richardsliu

Labels
approved cla: yes lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@texasmichelle @googlebot @jlewi @richardsliu @k8s-ci-robot @YujiOshima