Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update jupyter hub with customized docker registry #2243

Merged
merged 1 commit into from
Jan 9, 2019
Merged

update jupyter hub with customized docker registry #2243

merged 1 commit into from
Jan 9, 2019

Conversation

cheyang
Copy link
Contributor

@cheyang cheyang commented Jan 9, 2019 •
edited by jlewi
Loading

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Jan 9, 2019

Thanks; you might want to cherry pick this onto the v0.4-branch

@cheyang
Copy link
Contributor Author

cheyang commented Jan 9, 2019

Yeah, @jlewi . Please help to cherry pick.

@jlewi
Copy link
Contributor

jlewi commented Jan 9, 2019

/lgtm
/approve

@cheyang Can you just create another PR applying this change to 0.4?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bce8f4b into kubeflow:master Jan 9, 2019
@k8s-ci-robot
Copy link
Contributor

@cheyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-presubmit dc49a51 link /test kubeflow-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cheyang
Copy link
Contributor Author

cheyang commented Jan 10, 2019

Sure, I will do this.

cheyang added a commit to cheyang/kubeflow that referenced this pull request Jan 10, 2019
@cheyang
update jupyter hub with customized docker registry (kubeflow#2243)
d9aa73a
@cheyang cheyang mentioned this pull request Jan 10, 2019
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 14, 2019
@cheyang @k8s-ci-robot
Branch v0.4.0 fix (#2255)
7749b6d 
* Sync up Kubeflow official docker images to user's registry (#2230)

* sync kubeflow images to your registry

* update comments

* fix sub namespace

* remove requirements txt

* Fix katib repo for  the docker registry which doesn't support sub namespace (#2237)

* update jupyter hub with customized docker registry (#2243)
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
@cheyang
update jupyter hub with customized docker registry (kubeflow#2243)
2da12d9
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@cheyang @k8s-ci-robot
update jupyter hub with customized docker registry (kubeflow#2243)
f79ec06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn Awaiting requested review from ellistarn

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@jlewi jlewi

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheyang @jlewi @k8s-ci-robot @googlebot