Enabling EFS on AWS for Tensorboard #2569
Conversation
|
Hi @jeremievallee. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/retest |
1 similar comment
|
/retest |
jeremievallee
force-pushed
the
efs-aws-tensorboard
branch
2 times, most recently
from
4ba5bc6
to
c27cb0d
Compare
|
/assign @pdmack |
| @@ -8,13 +8,18 @@ | |||
| // @optionalParam servicePort number 9000 Name of the servicePort | |||
| // @optionalParam serviceType string ClusterIP The service type for tensorboard service | |||
| // @optionalParam defaultTbImage string tensorflow/tensorflow:1.8.0 default tensorboard image to use | |||
| // @optionalParam s3Enabled string false Wether or not to use S3 | |||
| // @optionalParam s3SecretName string null Name of the k8s secrets containing S3 credentials | ||
| // @optionalParam s3SecretAccesskeyidKeyName string null Name of the key in the k8s secret containing AWS_ACCESS_KEY_ID | ||
| // @optionalParam s3SecretSecretaccesskeyKeyName string null Name of the key in the k8s secret containing AWS_SECRET_ACCESS_KEY | ||
| // @optionalParam s3AwsRegion string us-west-1 S3 region | ||
| // @optionalParam s3UseHttps string true Whether or not to use https | ||
| // @optionalParam s3VerifySsl string true Whether or not to verify https certificates for S3 connections | ||
| // @optionalParam s3Endpoint string s3.us-west-1.amazonaws.com URL for your s3-compatible endpoint | ||
| // @optionalParam efsEnabled string false Wether or not to use EFS |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
gah |
|
/retest |
|
Sorry @jeremievallee but I think you need another rebase to pick up #2564 |
|
@pdmack yep, I think so too. I'll do that now. Thanks! |
jeremievallee
force-pushed
the
efs-aws-tensorboard
branch
from
c27cb0d
to
a283066
Compare
|
/lgtm |
* Enabling EFS on AWS for Tensorboard * Fixed comment typos.
* Enabling EFS on AWS for Tensorboard * Fixed comment typos.
Allowing the use of AWS EFS for the Tensorboard deployment on AWS.
Previously, only S3 parameters were available.
With these changes, provided you have a Persistent Volume Claim with an EFS resource on your cluster (using efs-provisioner), you can make Tensorboard read from EFS.
You can still use S3, of course. They are not mutually exclusive (use the flags
efsEnabledands3Enabled, both can betrueat the same time).This change is