Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added notebook-controller and jupyter-web-app as part of kf deployment #2764

Merged
merged 6 commits into from
Mar 24, 2019

Conversation

zabbasi
Copy link
Contributor

@zabbasi zabbasi commented Mar 21, 2019

This change is Reviewable

@zabbasi zabbasi changed the title WIP: added notebook_controller and jupyter-web-app as part of kf deployment added notebook-controller and jupyter-web-app as part of kf deployment Mar 21, 2019
@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 21, 2019

/retest

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 21, 2019

/assign @kunmingg

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 21, 2019

/retest

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 22, 2019

@kimwnasptd @lluunn can you please check if all required components are added?

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 22, 2019

/retest

@lluunn
Copy link
Contributor

lluunn commented Mar 22, 2019

/lgtm
/approve
/hold
for @kunmingg

@lluunn
Copy link
Contributor

lluunn commented Mar 22, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 22, 2019
@kunmingg
Copy link
Contributor

/lgtm
/hold cancel
Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 22, 2019
@kunmingg
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 22, 2019
@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 23, 2019

/retest

@zabbasi
Copy link
Contributor Author

zabbasi commented Mar 24, 2019

@kunmingg

@jlewi
Copy link
Contributor

jlewi commented Mar 24, 2019

/lgtm (since @kunmingg approved it and the only change was the merge with masteR)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kunmingg
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 3fa97bc into kubeflow:master Mar 24, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
kubeflow#2764)

* added notebook_controller and jupyter-web-app as part of kf dployment

* small formatting

* added notebook-controller and jupyter-wb-app
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
kubeflow#2764)

* added notebook_controller and jupyter-web-app as part of kf dployment

* small formatting

* added notebook-controller and jupyter-wb-app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants