set termination policy to worker 0 by default when no master exists #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no master exists.
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Closed
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Mar 20, 2018
* kubeflow#444 add an argument for the termination policy but the TFCnn prototype isn't setting it. * The TFCnn prototype overrides the termination policy so we can just pass null for the TP.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 21, 2018
yanniszark
added a commit
to arrikto/kubeflow
that referenced
this pull request
Nov 1, 2019
* tests: add script to add images to kustomizations Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> * remove tabs from yaml files Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> * e2e: check that kustomization is filled correctly Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> * format all kustomizations the same way Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> * kustomizations: add missing images Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> * regenerate tests Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com> * fix run-tests script Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Nov 1, 2019
* Update the notebook-controller image. * It looks like the code may not have actually changed since we last built the image. Nonethless, lets update the tag to use the sha as opposed to a tag like v20190911-e8193317-dirty-cd2831 * Update the tests. * Disable the new test for making sure the images are set because it doesn't handle digests. * Related to kubeflow#444
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most tensorflow training examples use worker 0 as the chief worker instead of master.
using ksonnet tf-job prototype to create training jobs dosen't allow that
and will make the tfjob fails if we set num_masters to 0.
This change is