-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the pip install tensorboard #446
Conversation
this is a screen shot from a container i built for tensorflow-notebook-cpu and uploaded to hub.docker.com https://hub.docker.com/r/nervana/tensorflow-notebook-cpu/tags/ |
/test |
@pdmack I think you helped a customer recently get this working. Any reason we should keep this rather than telling customers to directly launch TB and potentially providing a UI for that if we think one is needed? |
@jlewi updated the PR description |
/retest |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jlewi Sorry, too slow. I think clear instructions for accessing TB will be fine. The user wasn't aware that the menu item was there, and therefore tried to launch it from the NB terminal. Also, they were using a spawned image which had TB launch issues (even from the menu). |
* Update OWNERS * Update OWNERS * Update OWNERS
/assign @jlewi
This is for the issue #428 "remove tensorboard link from jupyter" and #297 "add prototypes for TensorBoard". In general we're utilizing the ksonnet way to launch tensorboard rather than using a button in jupyterhub.
This change is