Create a script to deploy minikube on a VM. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is the first step in adding E2E testing on minikube. * We add a function call to test_deploy that will deploy minikube on a VM. * Also provide a function to teardown the VM. * The script copies the relevant kubeconfig information and certificates to a directory. * In a follow on PR we will incorporate this new command into our E2E workflow in order to create an E2E test that runs on minikube. * Related to kubeflow#6
jlewi
changed the title
|
/assign @lluunn |
lluunn
reviewed
Mar 21, 2018
testing/test_deploy.py
Outdated
| install_script = os.path.join(os.path.dirname(__file__), "install_minikube.sh") | ||
|
|
||
| if not os.path.exists(install_script): | ||
| logging.error("C %s", install_script) |
| vm_util.execute_script(args.project, args.zone, args.vm_name, install_script) | ||
| vm_util.execute(args.project, args.zone, args.vm_name, ["sudo minikube start --vm-driver=none --disk-size=40g"]) | ||
|
|
||
| # Copy the .kube and .minikube files to test_dir |
testing/test_deploy.py
Outdated
| if not os.path.exists(minikube_dir): | ||
| os.makedirs(minikube_dir) | ||
|
|
||
| for target in ["~/.minikube/*.crt", "~/.minikube/client.key"]: |
| @@ -289,6 +298,122 @@ def ks_deploy(app_dir, component, params, env=None, account=None): | |||
| apply_command.append("--as=" + account) | |||
| util.run(apply_command, cwd=app_dir) | |||
|
|
|||
| def modify_minikube_config(config_path, certs_dir): | |||
There was a problem hiding this comment.
what's the purpose of doing this?
There was a problem hiding this comment.
We need to make the config work inside the pod and not the VM where minikube is running.
Added a comment.
|
@lluunn PTAL. |
lluunn
approved these changes
Mar 22, 2018
| @@ -289,6 +298,122 @@ def ks_deploy(app_dir, component, params, env=None, account=None): | |||
| apply_command.append("--as=" + account) | |||
| util.run(apply_command, cwd=app_dir) | |||
|
|
|||
| def modify_minikube_config(config_path, certs_dir): | |||
|
/lgtm |
|
@lluunn Can you re LGTM? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a directory.
workflow in order to create an E2E test that runs on minikube.
This change is