Synchronize jupyter-web-application role with clusterrole #6241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
StefanoFioravanzo and
thesuperzapper
juliusvonkohout
changed the title
|
@juliusvonkohout I agree that we should reduce the RBAC in this Role, but can we also fix up the other parts of this role while we are looking at it? For example, not giving "*" for verbs (on the other resource types also). |
I could take the verbs from here https://github.com/kubeflow/kubeflow/blob/d43aee19ad8b556273a627ad34367e7e56b5c97e/components/crud-web-apps/jupyter/manifests/base/cluster-role.yaml for the namespace-role and remove create and delete for namespaces. |
|
@thesuperzapper both roles contain the same rules now and i have removed the dangerous right to manage namespaces. |
|
/ok-to-test |
juliusvonkohout
force-pushed
the
patch-8
branch
from
8e76886
to
1a5fe1b
Compare
|
Now it should be ready. |
|
@kimwnasptd @thesuperzapper i consider this to be a candidate for Kubeflow 1.5 rc1 |
Comment on lines
-11
to
-12
| - get | ||
| - list |
There was a problem hiding this comment.
@juliusvonkohout Can you confirm that the jupyter-web-app still functions correctly without "get" and "list" on namespaces?
There was a problem hiding this comment.
That seems to be the case. I just updated the roles, restarted jupyter-web-app and notebook-controller and was able to start, stop, create, delete jupyterlabs. There are also no errors in the logs.
jupyter-web-app-deployment-7f7f55f9d8-slb8k-jupyter-web-app.log
There was a problem hiding this comment.
Is there more to test or it is ready to be merged?
There was a problem hiding this comment.
Should be good to go. It would also be a bug from the current code if it couldn't operate without listing namespaces, since it shouldn't need these permissions in the first place.
Note that we might need to re-introduce them though, in a future iteration when we would want the apps to be self-standing. But we need to discuss other items for this effort. But I'm also mentioning this context to keep in mind
|
Moving on with merging the PR, to also include it in the RC1. Thank you for your time @juliusvonkohout! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261) * proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295) * proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270) Provide a design doc as a proposal for extending Notebook Controller to expose idleness for Jupyter. Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide. You can view the #6270 issue in the following link: #6270 Signed-off-by: Athanasios Markou <athamark@arrikto.com> * review: change the title of the proposal Change the title of the proposal to only include the proposed new feature. The new title of the proposal will now be "Expose Idleness Information for Jupyter Notebooks". * review: rename the proposal markdown file We want to give a more specific name to the markdown which contains the proposal. Since this proposal emphasizes on a feature regarding the Jupyter Notebooks, the new name will be: 20220121-jupyter-notebook-idleness.md * Synchronize jupyter-web-application role with clusterrole (#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml * Kubeflow Roadmap update - with 1.5 details (#6266) * Kubeflow Roadmap update - with 1.5 details These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads. * correct formatting in KFP features Moved KFP features under KFP Control Flow doc * updating KFP section updating KFP references with updates from KFP team * Updated the 1.5 release date to March updated the 1.5 release date to March * Update ROADMAP.md change Hyperparameter leader election to Katib leader election Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update ROADMAP.md improve description and details of feature for metrics collector Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Katib description for Early stopping in 1.5 updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297) * notebooks: Update image's tag in make Modify Makefile to update properly the TAG based on the git TAG. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Expose last-activity Extend the notebook-controller to: * cull idle Notebook Servers based on their new `last-activity` annotation * expose the last activity of each Notebook Server as an annotation on the metadata of the corresponding CR object Modify notebook_controller.go to: * update the Last Activity of each Notebook Server that has a Running pod * delete the Last Activity Annotation for every Notebook Server that does not have a Running pod Extend culler.go to: * perform culling based on the new `last-activity` annotation and not based on the `/api/status` endpoint. * update the last activity of a Notebook Server, based on the kernels' execution states. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Athanasios Markou <athamark@arrikto.com> * notebooks: Introduce a DEV env var We introduce a DEV ENV var to allow admins develop and test on their local machine their custom Notebook Controller. We provide information and instructions inside the components/notebook-controller/README.md. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add unit tests for last-activity * Introduce new tests for allKernelsAreIdle() * Extend the tests for NotebookIsIdle() and for NotebookNeedsCulling(). Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: UpdateNotebookLastActivityAnnotation() Ensure that UpdateNotebookLastActivityAnnotation() does not return "true". This function should not return any value. Signed-off-by: Athanasios Markou <athamark@arrikto.com> * jwa: Rework the Storage API of the web app (#6321) * wa(back): Add helper for deserializing JSON obj In some cases we might need to construct Python k8s lib objects from the JSONs that are provided by clients. I.e. the UI will be sending a PVC object in json format, so the backend will need to create the corresponding client.V1PersistentVolumeClaim object and submit it. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Serialization helper Add helper function for converting a k8s-client object into a dict that can be sent as an HTTP response. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Add dry run to Notebooks and PVCs The backend will need to be able to create objects with dry-run, in order to ensure they are valid. The backend will need to check that both the Notebook and the PVCs can be created beforehand. This way we avoid the scenario where we create PVCs but the Notebook fails to be created, and the PVCs are never garbage collected. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Update kubernetes to 0.17 In order to support dry-run we must use the 0.17 version of the Python k8s client. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Extend api module to patch pvcs The backend will need to be able to PATCH PVCs in order to set the ownerReference to the Notebook that mounts the PVCs. Ref: arrikto/dev/issues/386#issuecomment-856700392 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Work with new Volumes API The backend API should not add any more layers of abstractions on top of the K8s API. The backend should expect the client/UI to be sending the entire PVC spec of a new PVC. Refs: arrikto/dev/issues/386 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Add unittests for new volumes API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Extend the PVC info returned We want to show both the access mode and size of the existing PVCs, when a user clicks on the dropdown to select which PVC to mount. The backend will need to provide this information to the frontend. We don't want to send the K8s list of PVCs since this will result in a lot of unnecessary data to be sent. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(front): Add proxy config for Rok When developing the Rok flavor locally we will need to be able to open the Rok chooser. This can be done by using Angular/webpack proxy to bring the exposed rok service and the app under the same domain. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Remove card from form The form of the app should not be a big card, but a normal form. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Install AceModule for yaml editing Install AceModule to allow users to edit yamls of objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * wa(front): Change the styling of form sections Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Create common volume components Component for: * New PVC and configuring its spec * Attaching an existing PVC in a Notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Update Rok form for new Volume API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Mark inputs as dirty when restoring Lab When the UI autofills the form with values from a JupyterLab snapshot then it should mark the touched fields as dirty. This way if a field has errors the UI will make that input red. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa: Update ConfigMap in manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(front): Fix format errors Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * profiles: Update the permissions for notebook idleness (#6335) Extend the Profiles Controller to give permissions to Notebooks controller for making GET requests to notebook's /api/kernels endpoint. Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Graceful handling of events (#6338) * notebooks: Handle events gracefully The controller is not exiting the reconciliation loop after it has re-emitted a Pod/STS Event as a Notebook Event. This results in the controller to later on try and GET a Notebook with the name of the Event that triggered the reconciliation loop. The controller should exit the reconciliation function once it has emitted the event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on deleted events We don't want to trigger the reconciliation function when an event gets deleted. If a Notebook would be deleted then the underlying events would be deleted as well, which results in the reconcile function to get triggered and try to GET Events and Notebooks with the name of the deleted event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Fix endless restarts (#6341) * notebooks: Update notebook if timestamp changed We don't want to be updating the spec of the notebook if the timestamp hasn't changed, since this will lead to constant updates and reconciliation loops. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Use a deep-copy of the notebook spec The controller should use a deep-copy of the notebook spec when calculating the spec for the StatefulSet. If not then we could update the notebook object without wanting it, since the spec could have been changed when calculating the STS spec. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add prefix env var only if missing The controller should be setting OR updating the NB_PREFIX env var. Previously it would always blindly append it to the spec, which could result in double entries for the same env var. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update tags for v1.5.0-rc.1 (#6343) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
google-oss-prow bot
pushed a commit
that referenced
this pull request
May 10, 2022
* Cherry-pick latest commits to the 1.5-branch (#6354) * Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261) * proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295) * proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270) Provide a design doc as a proposal for extending Notebook Controller to expose idleness for Jupyter. Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide. You can view the #6270 issue in the following link: #6270 Signed-off-by: Athanasios Markou <athamark@arrikto.com> * review: change the title of the proposal Change the title of the proposal to only include the proposed new feature. The new title of the proposal will now be "Expose Idleness Information for Jupyter Notebooks". * review: rename the proposal markdown file We want to give a more specific name to the markdown which contains the proposal. Since this proposal emphasizes on a feature regarding the Jupyter Notebooks, the new name will be: 20220121-jupyter-notebook-idleness.md * Synchronize jupyter-web-application role with clusterrole (#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml * Kubeflow Roadmap update - with 1.5 details (#6266) * Kubeflow Roadmap update - with 1.5 details These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads. * correct formatting in KFP features Moved KFP features under KFP Control Flow doc * updating KFP section updating KFP references with updates from KFP team * Updated the 1.5 release date to March updated the 1.5 release date to March * Update ROADMAP.md change Hyperparameter leader election to Katib leader election Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update ROADMAP.md improve description and details of feature for metrics collector Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Katib description for Early stopping in 1.5 updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297) * notebooks: Update image's tag in make Modify Makefile to update properly the TAG based on the git TAG. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Expose last-activity Extend the notebook-controller to: * cull idle Notebook Servers based on their new `last-activity` annotation * expose the last activity of each Notebook Server as an annotation on the metadata of the corresponding CR object Modify notebook_controller.go to: * update the Last Activity of each Notebook Server that has a Running pod * delete the Last Activity Annotation for every Notebook Server that does not have a Running pod Extend culler.go to: * perform culling based on the new `last-activity` annotation and not based on the `/api/status` endpoint. * update the last activity of a Notebook Server, based on the kernels' execution states. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Athanasios Markou <athamark@arrikto.com> * notebooks: Introduce a DEV env var We introduce a DEV ENV var to allow admins develop and test on their local machine their custom Notebook Controller. We provide information and instructions inside the components/notebook-controller/README.md. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add unit tests for last-activity * Introduce new tests for allKernelsAreIdle() * Extend the tests for NotebookIsIdle() and for NotebookNeedsCulling(). Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: UpdateNotebookLastActivityAnnotation() Ensure that UpdateNotebookLastActivityAnnotation() does not return "true". This function should not return any value. Signed-off-by: Athanasios Markou <athamark@arrikto.com> * jwa: Rework the Storage API of the web app (#6321) * wa(back): Add helper for deserializing JSON obj In some cases we might need to construct Python k8s lib objects from the JSONs that are provided by clients. I.e. the UI will be sending a PVC object in json format, so the backend will need to create the corresponding client.V1PersistentVolumeClaim object and submit it. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Serialization helper Add helper function for converting a k8s-client object into a dict that can be sent as an HTTP response. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Add dry run to Notebooks and PVCs The backend will need to be able to create objects with dry-run, in order to ensure they are valid. The backend will need to check that both the Notebook and the PVCs can be created beforehand. This way we avoid the scenario where we create PVCs but the Notebook fails to be created, and the PVCs are never garbage collected. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Update kubernetes to 0.17 In order to support dry-run we must use the 0.17 version of the Python k8s client. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Extend api module to patch pvcs The backend will need to be able to PATCH PVCs in order to set the ownerReference to the Notebook that mounts the PVCs. Ref: arrikto/dev/issues/386#issuecomment-856700392 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Work with new Volumes API The backend API should not add any more layers of abstractions on top of the K8s API. The backend should expect the client/UI to be sending the entire PVC spec of a new PVC. Refs: arrikto/dev/issues/386 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Add unittests for new volumes API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Extend the PVC info returned We want to show both the access mode and size of the existing PVCs, when a user clicks on the dropdown to select which PVC to mount. The backend will need to provide this information to the frontend. We don't want to send the K8s list of PVCs since this will result in a lot of unnecessary data to be sent. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(front): Add proxy config for Rok When developing the Rok flavor locally we will need to be able to open the Rok chooser. This can be done by using Angular/webpack proxy to bring the exposed rok service and the app under the same domain. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Remove card from form The form of the app should not be a big card, but a normal form. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Install AceModule for yaml editing Install AceModule to allow users to edit yamls of objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * wa(front): Change the styling of form sections Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Create common volume components Component for: * New PVC and configuring its spec * Attaching an existing PVC in a Notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Update Rok form for new Volume API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Mark inputs as dirty when restoring Lab When the UI autofills the form with values from a JupyterLab snapshot then it should mark the touched fields as dirty. This way if a field has errors the UI will make that input red. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa: Update ConfigMap in manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(front): Fix format errors Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * profiles: Update the permissions for notebook idleness (#6335) Extend the Profiles Controller to give permissions to Notebooks controller for making GET requests to notebook's /api/kernels endpoint. Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Graceful handling of events (#6338) * notebooks: Handle events gracefully The controller is not exiting the reconciliation loop after it has re-emitted a Pod/STS Event as a Notebook Event. This results in the controller to later on try and GET a Notebook with the name of the Event that triggered the reconciliation loop. The controller should exit the reconciliation function once it has emitted the event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on deleted events We don't want to trigger the reconciliation function when an event gets deleted. If a Notebook would be deleted then the underlying events would be deleted as well, which results in the reconcile function to get triggered and try to GET Events and Notebooks with the name of the deleted event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Fix endless restarts (#6341) * notebooks: Update notebook if timestamp changed We don't want to be updating the spec of the notebook if the timestamp hasn't changed, since this will lead to constant updates and reconciliation loops. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Use a deep-copy of the notebook spec The controller should use a deep-copy of the notebook spec when calculating the spec for the StatefulSet. If not then we could update the notebook object without wanting it, since the spec could have been changed when calculating the STS spec. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add prefix env var only if missing The controller should be setting OR updating the NB_PREFIX env var. Previously it would always blindly append it to the spec, which could result in double entries for the same env var. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update tags for v1.5.0-rc.1 (#6343) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * fix error comparison between pointer and pointer in "CopyStatefulSetFields" (#6195) error comparison between pointer and pointer in "CopyStatefulSetFields" * [bugfix]: update unsupported links to latest pages (#6192) * centraldashboard: Add KServe overlay (#6383) Configure the dashboard to use the KServe app instead of the KFServing 0.6.1 one. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on Events deletion (#6391) The controller should not trigger the reconcile loop when an Event is deleted. Previously the controller would run the reconciliation loop on any event deletion. This commit updates it to not run the loop for ANY event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Create v1.5.0-rc.2 images (#6394) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * fixed typo * fixed typo * changed remove rc2 Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Co-authored-by: mofanke <54242816+mofanke@users.noreply.github.com> Co-authored-by: Jaeyeon Kim <anencore94@gmail.com>
chuckbelisle
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Sep 20, 2022
* releasing: Add WG-Notebooks leads to release owners (#5777)
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Specify commonLabels for tensorboard-controller (#5780)
* Remove jlewi as an approver (#5786)
Removing myself as an owner. This should lead to better auto-assignment of code reviews.
* Update notebook server base images (#5804)
* Update second layer docker images to new tags and some python deps (#5809)
* Update image tags and python packages in pytorch and tensorflow full dockerfiles (#5817)
* Add CI format checks for the Jupyter web app (#5811)
* jwa(front): Add npm rule for checking the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci: Add common tasks for format checks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(jwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix formatting
Run `npm run format:write` on frontend
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Include prettier in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Don't copy node_modules in Dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps: Add global dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Remove unused dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(make): Don't include dockerignore and cleanup
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* initial notebook server images README.md (#5818)
* tensorboard-controller: Fix scheduling unbound PVCs (#5819)
When the TB controller attempts to schedule a RWO PVC it checks its
accessModes in the PVC status. The controller panics if the list is
empty.
This commit adds a check to ensure the list is not empty.
Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
* Fix profile-controller CRD pruning issue (#5822)
* api: Add marker for preserving unknown fields in Plugins
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* manifests: Regenerate manifests
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Remove Logo Trademarks from the Jupyter Web App and make logos configurable (#5823)
* rebase: Make logos configurable in configmap and remove trademark references
Rebased to remove the changes to the package-lock.json
* review: add suggested changes and add image group section to README
* Make notebook limits configurable with a multiplication factor (#5815)
* Make notebook limits configurable with a multiplication factor
* Make limits configurable under advanced section
* run prettier to format frontend code
* fix formatting and add rounding in backend
* Return error if limit is smaller than request
* Allow disabling limitFactor by setting it to none
* review: remove camelCase in python backend
* fix: update spawner_ui_config.yaml in manifests directory
* review: fix setting limits backend
* review: remove unnecessary check from backend
* notebook-servers: Update JupyterLab and add Git Extension (#5846)
* chore: Add comment to reference RStudio license. (#5884)
* CI/CD: add kustomize build tests (#5919)
* Add CI format checks for the Volumes web app (#5820)
* vwa(front): Add npm script to check the formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update the package-lock.json
Run `npm install` to bring the package-lock.json up to date
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Remove unused dockerignore file
We have created a global dockerignore file for all the web apps in the
parent dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Don't copy node_modules in dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(make): Don't include dockerignore
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(vwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Copy only necessary files for build
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: Use docker context instead of cd ..
Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboard-controller: fix binding issue (#5925)
* JWA: Don't override assets with logos ConfigMap (#5942)
* jwa(front): Add static logos in the app
The app does not contain the logos' svgs in its source code/static
files. This results in the icons to not show when developing locally.
This commit adds the svgs found in the logos ConfigMap to the static
files of the app as well.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Change logos fetch url
Change the URLs of the logos from `static/assets/*` to
`static/assets/logos`.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(manifests): Don't override assets with logos
Mount the ConfigMap under the `static/assets/logos` directory to not
override the contents of the entire assets dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Make it possible to add Namespaced menu items (#5871)
* Make it possible to add Namespaced menu items
* Reduce the nesting levels
* FIX The number of gpu must be set as string in Kubernetes/Openshift (#5891)
* Update form.py
* Update form.py
* Update form-default.component.ts
* fix whitespace issue
* feat(jupyter): add fonts as assets to service (#5691)
* cwa(front): Ignore font files in assets
* feat(jupyter): add fonts as assets to service
* CRUD: fonts in common
* CWA: Remove link to css file
* jwa(front): Remove font assets from jupyter
Co-authored-by: Wendy Gaultier <wvgaultier@gmail.com>
* Update base notebook for Renovate compatibility (#5955)
* Update base notebook for Renovate compatibility
* Separate kubectl and S6 arch
* Update jupyter, rstudio and vs code notebook images + allow rstudio in iframe (#5961)
* Update jupyter, rstudio and vs code notebook images
* Remove sed and use substring removal
* Make menu bar scrollable again (#5964)
* [fix]: Make jupyter-web-app parse workspace volume MountPath (#5952)
* [fix]: Make jupyter-web-app parse workspace volume MountPath
- workspace volume path was fixed with "/home/jovyan"
- it should be enable to parse from jupyter-web-app-config's data
* change parsing key correctly
* Remove the f-strings in the Jupyter web app's backend (#5680)
* Notebook servers: Add explanation about kernel not connecting (#5920)
* fix(profile-controller): KNative probes (#5848)
Knative control-plane components need to probe certain paths of Knative
Pods, in order to function correctly. These paths are:
- /healthz
- /metrics
- /ready
- /wait-for-drain
For this reason, we extend the Profile Controller to apply an Istio
AuthorizationPolicy that allows traffic to these HTTP paths for Pods in
user namespaces, as per Knative's instructions:
https://knative.dev/docs/serving/istio-authorization/#allowing-access-from-system-pods-by-paths
This only fixes requests through the public ingress. Cluster-internal
traffic and predictor-transformer use-cases are not supported yet. We
continue discussing these in kubeflow#5965.
Refs kubeflow#5965
Refs kubeflow/kfserving#1558
Signed-off-by: Yurii Komar <subreptivus@gmail.com>
* feat(jupyter): Support hiding image registry/tag (#5681)
* feat(jupyter): Support hiding image registry/tag
* feat(jupyter): Support hiding VSCode/RStudio images registry/tag
* rebasing onto upstream master
* fix: formatting with prettier and set default hideRegistry=true
* fix: move hideRegistry and hideTag from spawnerFormDefaults.image
* fix whitespace
* add tooltip for images
Co-authored-by: JessicaBarh <jessicabarhoma@gmail.com>
* Update dockerfiles and make compatible with Renovate (#5968)
* Update dockerfiles and make compatible with Renovate
* Set memory for jupyter pytorch to the same as jupyter tensorflow
* Update protobuf
* Remove conda version and use substring expansion
* Update SQLAlchemy
* Update dill
* Create OWNERS file in .github folder for Renovate config + workflows (#5983)
* Extend deadline for PyTorch image building (#5991)
* Allow user to add/delete labels to user namespace using ConfigMap. Fix #5712 (#5761)
The profile-controller applies a hardcoded list of labels to Profile
namespaces. Make this list of labels configurable with a ConfigMap. The
new list of steps for the profile-controller is:
1. **(new)** Profile-controller starts and reads the file given by the
`--namespace-labels-path` CLI flag (defaults to
`/etc/profile-controller/namespace-labels.yaml`). This file contains
a YAML dict of label key/values to add to each Profile namespace.
2. Profile-controller creates namespace.
3. Profile-controller merges existing namespace labels with given
labels. A given label is applied ONLY if it doesn't exist already.
4. **(new)** If a given label value is empty (``), remove the label from
the namespace if it already exists.
We are using a ConfigMap instead of a plain CLI flag, so that users can
change the list of labels without restarting the profile-controller.
Closes #5712
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Co-authored-by: James Liu <jamxl@google.com>
Co-authored-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Update last batch of notebook server Dockerfiles (#5997)
* Update spawner_ui_config.yaml with new tags (#5998)
* Update images in spawner_ui_config.yaml
* Update manifest image tags
* CRUD web apps: i18n (#5880)
* feat(jupyter): add modules for translations
* feat(jupyter): fix path for translations + add GPU translations
* feat(jupyter): add translations
* feat(jupyter): add translations to form-default
* feat(jupyter): add translations to affinity/tolerations
* feat(jupyter): add translations to Image Pull Policy
* feat(jupyter): remove imports from app.module.ts + fix translations
* web-apps(front): add TranslationModule to common for jupyter
* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file
* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message
* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects
* feat(volume): add translations for volume
* feat(jupyter): refactor asset file
* Update asset files for all folders
* feat(tensorboards): add i18n
Update all asset files
* cwa: add new translations
* cwa: Add README documentation
* fix: formatting with prettier
* Fix tests
* Fix python format
* remove comment
Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>
* Remove deprecated JWA (#5959)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Sync spawner yaml from source to manifests (#5999)
* notebooks: Add additional PGP server for RStudio package validation (#6010)
* Change PGP server for RStudio validation to pgp.surfnet.nl
* Add as secondary keyserver
* Add support for ServiceAccountName and AutomountServiceAccountName to admission-webhook (#5939)
* WA: Use relative paths for fetching translation files (#6034)
* jwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Update CRUD web apps from Angular 8 to Angular 12 (#6004)
* common: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* common: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* common: remove entryComponents and replace TestBed.get with TestBed.inject
Edit files manually
* common: make compatible with Angular 9
Edit files manually
* common: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* update kubeflow-common project dependencies
* common: add @angular/localize
ng add @angular/localize
* jupyter: update angular core and cli 8
ng update @angular/core@8 @angular/cli@8
* jupyter: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* jupyter: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* jupyter: remove entryComponents
Edit file manually
* jupyter: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* jupyter: add @angular/localize
ng add @angular/localize
* tensorboards: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* tensorboards: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* tensorboards: remove entryComponents and replace TestBed.get with TestBed.inje…
Edit files manually
* tensorboards: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* tensorboards: add @angular/localize
ng add @angular/localize
* Fix tensorboards-web-app run-dev in makefile
Edit file manually
* volumes: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* volumes: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* volumes: remove entryComponents and replace TestBed.get with TestBe…
Edit files manually
* volumes: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* volumes: add @angular/localize
ng add @angular/localize
* common: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10 --force
* common: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* update kubeflow-common project dependencies
Edit file manually
* common: update fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* common: fix font location
Edit file manually
* jupyter: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* jupyter: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* jupyter: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* tensorboards: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* tensorboards: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* tensorboards: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* volumes: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* volumes: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* volumes: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* common: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* common: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* common: install @angular-devkit/core@11
npm install --save-dev @angular-devkit/core@11
* common: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* common: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* update kubeflow-common project dependencies
Edit file manually
* jupyter: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* jupyter: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* tensorboards: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* tensorboards: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* tensorboards: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* tensorboards: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* volumes: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* volumes: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* volumes: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* volumes: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* common: Fix CI failure
* jupyter: npm run format:write
npm run format:write
* volumes: npm run format:write
npm run format:write
* tensorboards: manually run prettier
prettier --write 'src/**/*.{js,ts,html,scss,css}'
* common: Fix MockComponent entryComponents for CI
Manually edit file
* common: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* common: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* common: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* update kubeflow-common project dependencies
Edit file manually
* common: fix Intl.DateTimeFormatOptions
Edit file manually. Type of defaultDateOptions and defaultTimeOptions needs to explicitly be set to Intl.DateTimeFormatOptions.
* jupyter: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* jupyter: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* tensorboards: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* tensorboards: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* tensorboards: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* volumes: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* volumes: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* volumes: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* common: update and audit packages
npm update && npm audit fix && npm i lodash-es@4.17.21 && npm i material-icons@0.7.3
* jupyter: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* tensorboards: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* volumes: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* jupyter: npm run format:write
npm run format:write
* lists roadmap in reverse chronological order (#6055)
Signed-off-by: Malini Bhandaru <mbhandaru@vmware.com>
* Correct missing predicates in controller watches. Fixes #5326 (#5873)
Co-authored-by: Filinto Duran <fduran@d2iq.com>
* fix(web-apps): Use Angular's i18n proposed implementation (#6065)
* jwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormImage
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAdvancedOptions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAffinityTolerations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormConfigurations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormCpuRam
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormDataVolumes
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormGpus
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FromName
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormWorkspaceVolume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Volume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize to peerDependencies
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Import $localize in library
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n RokService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ConfirmDialog
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ResourceTable
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n SnackBar
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-app(front): i18n NameNamespaceSelector
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Remove ngx-translate
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa: Update READMEs
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize when testing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* [CentralDashboard] Add entry for Models web app (#6085)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Interact with the namespace selector (#5995)
* Interact with the namespace selector
* Use namespace given as an argument
* Keep the index of selected item
* fix(jwa): Fix limits calculation when limitFactor is none (#6058)
* jwa(front): Don't allow NaN values in limits
The UI should always catch a NaN value and don't add it in the form.
Currently this is the case for the cpu/memory limits.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Limits should not be changed if dirty
If the user has manually edited the limits fields then the UI should not
try to automatically calculate them again, using the limitFactors.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix NaN in Kubeflow Notebooks (#6092)
* Fix NaN in Kubeflow Notebooks
* add a validation check for NaN values
* fix: validation check if value is None
* lint: fix line length
* add section for 1.4; small updates for 1.3 section (#6082)
* add section for 1.4; small updates for 1.3 section
* refer to training operators consistently; add link to Notebooks roadmap.
* address @Bobgy feedback regarding Kubeflow Pipelines portions of 1.4 roadmap
* Remove virtualservice timeout to prevent websocket disconnect (#6126)
In the existing version, the 'timeout: 300s' added to the notebook's virtual service would cause websockets to disconnect at the 5 minute mark, causing the Jupyter Notebook web terminal function to hang. This is described in https://github.com/kubeflow/kubeflow/issues/6124.
* fix(admission-webhook): attach namespace to pod request if pod does not have it (#6052)
* fix(admission-webhook): attach namespace to pod request if pod does not have it
* Apply suggestions from code review
Add more explicit logs
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
* Add more explicit log
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
* Fix notebook base image gpg keys (#6138)
* update links for new testing infra (#6144)
* Add more root OWNERS (#6146)
* Improve README for example-notebook-servers (#6165)
* jwa(front): Don't disable vendors with no GPUs (#6171)
JWA should not block users from selecting GPUs if the current cluster
nodes do not have any GPUs attached to them. We've seen users that have
autoscaled nodegroups for GPUs, so a GPU node will be added to the
cluster once a Pod has requested it.
Refs: arrikto/dev#1484
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Bump Golang version in PodDefaults, TensorBoard Controller and KFAM to 1.17 (#6180)
* kfam: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboards: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Update Notebooks README regarding custom packages (#6176)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix reference to PodPreset as PodDefault (#6184)
* fix: tensorboard-controller is killed due to out of memory (#6148)
* Update manager.yaml
* Update manager.yaml
* fix(web-apps): Use relative path for --deploy-url build. #5566 (#6206)
* fix(web-apps): Use relative path for --base-href build
* volume web app should use volume base-href
* Document for cutting Kubeflow website release. (#6198)
* Document for cutting Kubeflow website release.
* Update docs_dev/releasing.md
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* Update docs_dev/releasing.md
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* address comment
* canonical name
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* Change namespace label for Katib metrics collector injection (#6225)
* fix(backend): tensorboard-controller does not work because of missing permissions (#6216)
* add(web-apps): i18n Fr translations (#6122)
* chore(docs): It's better to refer to the cli documents, not repo's readme (#6239)
* fix(docs): Fix the 404 K8s docs link (#6236)
* nit: typo in README.md (#6211)
* web-apps(front) : change error msg for min (#6193)
* Centraldashboard/add uncaughtexception handler (#6203)
* Central dashboard - Add global uncaught exception handler
* fix comments
* Fix(frontend): Upgrade ts node to v4 (#6242)
* Upgrade ts-node to v10
* Update lock
* admission-webhook-manifests: Update the cert manager from v1alpha2 to v1 (#6230)
* Short term updates to Published Kubeflow Roadmap (#6248)
3 changes - Add info on Kubeflow 1.5 and 1.4.1. Update roadmap to show that Kubeflow 1.4 was delivered.
* Upgrade the google cloud monitoring node.js client (#6210)
* Upgrade the google cloud monitoring node.js client
* Update package-lock.json
* Upgrade TypeScript to v4
* Update package-lock.json
* run tslint
* fix dashboard sending malformed headers to kfam (#6186)
* correct typo - track to tracked (#6264)
corrected typo "track" to "tracked"
* centraldashboard: Update node and use latest-stable (#6260)
Change the tests to NOT fetch Chromium from the Edge branch, which is develop,
but instead use latest-stable. We saw that edge can have problems from times to
times.
In the same commit we also update the node version to fix CVEs with the current
v12.18.3 version that we had.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Tell user to select a namespace to access namespaced menu item (#6181)
* Fix unnecessary updates of istio AuthorizationPolicy (#6269)
* Introduce a basic proposals flow for more advanced features (#6272)
* Introduce a proposals dir for Notebooks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Move the proposals dir under components
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Secure access to KFAM (#6077)
* fix(notebooks) make culling work with multi-user (#5128) (#5980)
* JWA: Very basic E2E tests to run locally (#6005)
* web-apps(front): Add test attrs selectors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update gitignore for cypress files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Install cypress & npm scripts for e2e
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(e2e): Add first cypress tests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Update the README for e2e instructions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* chore: remove Bobgy from OWNERS
* frontend: Use responsive tables instead of cards (#6316)
* jwa(front): Make ng lint work by ignoring e2e/tsconfig.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Make the table responsive
We introduced all of our changes in the underlying TableComponent. This
component can then be either used independently or inside a material
card.
The changes we did in that component are:
1. Create Output() emitters, since this component can be used directly
2. The config object for a Table row now supports a `style` prop for
defining the list of CSS styles to be applied
2. Remove the truncate classes (small, medium, large) and only have
a boolean value. The user can define the width directly now via the
`style` property in the row's config
3. Modify the classes for aligning contents right and left
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Add table paginator
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Add padding to titlebar text
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Use bigger font for toolbar title
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Use responsive table and toolbar
We refactor both the index and form pages of the app to:
1. Add a top row toolbar with the title of the app and the button to
create a new Notebook
2. Replace the card with a responsive table that shows the items. The
component also has a paginator
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* vwa(front): Use responsive table and toolbar
This commit:
1. Adds a toolbar at the top of the index page with the title of the app
and the button to create a new volume
2. Replaces the card with a responsive table
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* twa(front): Use responsive table and toolbar
This commit:
1. Adds a toolbar at the top of the index page with the title of the app
and a button to create a new TensorBoard instance
2. Replaces the card with a resopnsive table
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* fix the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa(front): Add npm script for running unit tests in docker
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fix unit tests failing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Don't use asterisk in Dockerfiles (#6318)
* wa(docker): Don't copy node_modules
To ensure Kaniko is not copying stale node_moduels folders, even though
we have a dockerignore file, we are explicitly only copying the source
code.
We have seen the build system with Kaniko to fail, due to NFS stale
instances with files in node_modules and expect that this is the root
cause.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Update makefile to use global dockerignore
The dockerfile for TWA was copying over the local dockerignore. This was
overriding the global one we had for all the web apps.
This commit updates the Makefile of the app to use the global
dockerignore that all the apps should use.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6309)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump postcss from 7.0.16 to 7.0.39 in /components/centraldashboard (#6308)
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.16 to 7.0.39.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/7.0.39/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.16...7.0.39)
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/tensorboards/frontend (#6311)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/volumes/frontend (#6310)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/jupyter/frontend (#6312)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update images for the 1.5 rc0 release (#6319)
* Update the releasing version tag
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Run automated script for updating versions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270)
Provide a design doc as a proposal for extending Notebook Controller to
expose idleness for Jupyter. Our proposal is in markdown format and follows
the guidelines of the kubeflow/components/proposal/README.md guide.
You can view the #6270 issue in the following link:
https://github.com/kubeflow/kubeflow/issues/6270
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* review: change the title of the proposal
Change the title of the proposal to only include the
proposed new feature. The new title of the proposal
will now be "Expose Idleness Information for Jupyter
Notebooks".
* review: rename the proposal markdown file
We want to give a more specific name to the markdown
which contains the proposal. Since this proposal
emphasizes on a feature regarding the Jupyter Notebooks,
the new name will be:
20220121-jupyter-notebook-idleness.md
* Synchronize jupyter-web-application role with clusterrole (#6241)
* Update role.yaml
* Update role.yaml
* Update cluster-role.yaml
* Kubeflow Roadmap update - with 1.5 details (#6266)
* Kubeflow Roadmap update - with 1.5 details
These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads.
* correct formatting in KFP features
Moved KFP features under KFP Control Flow doc
* updating KFP section
updating KFP references with updates from KFP team
* Updated the 1.5 release date to March
updated the 1.5 release date to March
* Update ROADMAP.md
change Hyperparameter leader election to Katib leader election
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update ROADMAP.md
improve description and details of feature for metrics collector
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update Katib description for Early stopping in 1.5
updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297)
* notebooks: Update image's tag in make
Modify Makefile to update properly the TAG
based on the git TAG.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Expose last-activity
Extend the notebook-controller to:
* cull idle Notebook Servers based on their new `last-activity`
annotation
* expose the last activity of each Notebook Server as an annotation
on the metadata of the corresponding CR object
Modify notebook_controller.go to:
* update the Last Activity of each Notebook Server that has a
Running pod
* delete the Last Activity Annotation for every Notebook Server
that does not have a Running pod
Extend culler.go to:
* perform culling based on the new `last-activity` annotation and
not based on the `/api/status` endpoint.
* update the last activity of a Notebook Server, based on the
kernels' execution states.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Athanasios Markou <athamark@arrikto.com>
* notebooks: Introduce a DEV env var
We introduce a DEV ENV var to allow admins
develop and test on their local machine their
custom Notebook Controller.
We provide information and instructions inside
the components/notebook-controller/README.md.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add unit tests for last-activity
* Introduce new tests for allKernelsAreIdle()
* Extend the tests for NotebookIsIdle() and for
NotebookNeedsCulling().
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: UpdateNotebookLastActivityAnnotation()
Ensure that UpdateNotebookLastActivityAnnotation() does not return
"true". This function should not return any value.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* jwa: Rework the Storage API of the web app (#6321)
* wa(back): Add helper for deserializing JSON obj
In some cases we might need to construct Python k8s lib objects from the
JSONs that are provided by clients. I.e. the UI will be sending a PVC
object in json format, so the backend will need to create the
corresponding client.V1PersistentVolumeClaim object and submit it.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Serialization helper
Add helper function for converting a k8s-client object into a dict that
can be sent as an HTTP response.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Add dry run to Notebooks and PVCs
The backend will need to be able to create objects with dry-run, in
order to ensure they are valid. The backend will need to check that both
the Notebook and the PVCs can be created beforehand.
This way we avoid the scenario where we create PVCs but the Notebook
fails to be created, and the PVCs are never garbage collected.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Update kubernetes to 0.17
In order to support dry-run we must use the 0.17 version of the Python
k8s client.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Extend api module to patch pvcs
The backend will need to be able to PATCH PVCs in order to set the
ownerReference to the Notebook that mounts the PVCs.
Ref: arrikto/dev/issues/386#issuecomment-856700392
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Work with new Volumes API
The backend API should not add any more layers of abstractions on top of
the K8s API. The backend should expect the client/UI to be sending the
entire PVC spec of a new PVC.
Refs: arrikto/dev/issues/386
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Add unittests for new volumes API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Extend the PVC info returned
We want to show both the access mode and size of the existing PVCs, when
a user clicks on the dropdown to select which PVC to mount.
The backend will need to provide this information to the frontend. We
don't want to send the K8s list of PVCs since this will result in a lot
of unnecessary data to be sent.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(front): Add proxy config for Rok
When developing the Rok flavor locally we will need to be able to open
the Rok chooser. This can be done by using Angular/webpack proxy to
bring the exposed rok service and the app under the same domain.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Remove card from form
The form of the app should not be a big card, but a normal form.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Install AceModule for yaml editing
Install AceModule to allow users to edit yamls of objects.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* wa(front): Change the styling of form sections
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Create common volume components
Component for:
* New PVC and configuring its spec
* Attaching an existing PVC in a Notebook
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Update Rok form for new Volume API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Mark inputs as dirty when restoring Lab
When the UI autofills the form with values from a JupyterLab snapshot
then it should mark the touched fields as dirty. This way if a field has
errors the UI will make that input red.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa: Update ConfigMap in manifests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix format errors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* profiles: Update the permissions for notebook idleness (#6335)
Extend the Profiles Controller to give permissions to Notebooks
controller for making GET requests to notebook's /api/kernels endpoint.
Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Graceful handling of events (#6338)
* notebooks: Handle events gracefully
The controller is not exiting the reconciliation loop after it has
re-emitted a Pod/STS Event as a Notebook Event. This results in the
controller to later on try and GET a Notebook with the name of the Event
that triggered the reconciliation loop.
The controller should exit the reconciliation function once it has
emitted the event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on deleted events
We don't want to trigger the reconciliation function when an event gets
deleted.
If a Notebook would be deleted then the underlying events would
be deleted as well, which results in the reconcile function to get
triggered and try to GET Events and Notebooks with the name of the
deleted event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Fix endless restarts (#6341)
* notebooks: Update notebook if timestamp changed
We don't want to be updating the spec of the notebook if the timestamp
hasn't changed, since this will lead to constant updates and
reconciliation loops.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Use a deep-copy of the notebook spec
The controller should use a deep-copy of the notebook spec when
calculating the spec for the StatefulSet. If not then we could
update the notebook object without wanting it, since the spec could have
been changed when calculating the STS spec.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add prefix env var only if missing
The controller should be setting OR updating the NB_PREFIX env var.
Previously it would always blindly append it to the spec, which could
result in double entries for the same env var.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Update tags for v1.5.0-rc.1 (#6343)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fix error comparison between pointer and pointer in "CopyStatefulSetFields" (#6195)
error comparison between pointer and pointer in "CopyStatefulSetFields"
* [bugfix]: update unsupported links to latest pages (#6192)
* centraldashboard: Add KServe overlay (#6383)
Configure the dashboard to use the KServe app instead of the KFServing
0.6.1 one.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on Events deletion (#6391)
The controller should not trigger the reconcile loop when an Event is
deleted. Previously the controller would run the reconciliation loop on
any event deletion.
This commit updates it to not run the loop for ANY event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Create v1.5.0-rc.2 images (#6394)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* release: Images for the 1.5.0 tag (#6398)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* added env for app secure cookies (#6395)
* build(deps): bump github.com/gogo/protobuf from 1.1.1 to 1.3.2 in /components/tensorboard-controller (#6424)
Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.1.1 to 1.3.2.
- [Release notes](https://github.com/gogo/protobuf/releases)
- [Commits](https://github.com/gogo/protobuf/compare/v1.1.1...v1.3.2)
---
updated-dependencies:
- dependency-name: github.com/gogo/protobuf
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump notebook from 6.4.0 to 6.4.10 in /components/example-notebook-servers/jupyter (#6431)
Bumps [notebook](http://jupyter.org) from 6.4.0 to 6.4.10.
---
updated-dependencies:
- dependency-name: notebook
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/tensorboards/frontend (#6417)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/jupyter/frontend (#6429)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.8 in /components/crud-web-apps/tensorboards/frontend (#6357)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.8)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/volumes/frontend (#6358)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/jupyter/frontend (#6359)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump lodash-es from 4.17.11 to 4.17.21 in /components/crud-web-apps/tensorboards/frontend (#6402)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.21)
---
updated-dependencies:
- dependency-name: lodash-es
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6416)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/volumes/frontend (#6423)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump undefsafe from 2.0.2 to 2.0.5 in /components/centraldashboard (#6342)
Bumps [undefsafe](https://github.com/remy/undefsafe) from 2.0.2 to 2.0.5.
- [Release notes](https://github.com/remy/undefsafe/releases)
- [Commits](https://github.com/remy/undefsafe/compare/v2.0.2...v2.0.5)
---
updated-dependencies:
- dependency-name: undefsafe
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6378)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/tensorboards/frontend (#6379)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6386)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/tensorboards/frontend (#6387)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump moment from 2.24.0 to 2.29.2 in /components/centraldashboard (#6432)
Bumps [moment](https://github.com/moment/moment) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2)
---
updated-dependencies:
- dependency-name: moment
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/volumes/frontend (#6380)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.4.7 to 1.5.10 in /components/centraldashboard (#6377)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/volumes/frontend (#6388)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/jupyter/frontend (#6389)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/jupyter/frontend (#6441)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6437)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.1.23.…
chuckbelisle
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Sep 22, 2022
* releasing: Add WG-Notebooks leads to release owners (#5777)
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Specify commonLabels for tensorboard-controller (#5780)
* Remove jlewi as an approver (#5786)
Removing myself as an owner. This should lead to better auto-assignment of code reviews.
* Update notebook server base images (#5804)
* Update second layer docker images to new tags and some python deps (#5809)
* Update image tags and python packages in pytorch and tensorflow full dockerfiles (#5817)
* Add CI format checks for the Jupyter web app (#5811)
* jwa(front): Add npm rule for checking the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci: Add common tasks for format checks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(jwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix formatting
Run `npm run format:write` on frontend
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Include prettier in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Don't copy node_modules in Dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps: Add global dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Remove unused dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(make): Don't include dockerignore and cleanup
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* initial notebook server images README.md (#5818)
* tensorboard-controller: Fix scheduling unbound PVCs (#5819)
When the TB controller attempts to schedule a RWO PVC it checks its
accessModes in the PVC status. The controller panics if the list is
empty.
This commit adds a check to ensure the list is not empty.
Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
* Fix profile-controller CRD pruning issue (#5822)
* api: Add marker for preserving unknown fields in Plugins
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* manifests: Regenerate manifests
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Remove Logo Trademarks from the Jupyter Web App and make logos configurable (#5823)
* rebase: Make logos configurable in configmap and remove trademark references
Rebased to remove the changes to the package-lock.json
* review: add suggested changes and add image group section to README
* Make notebook limits configurable with a multiplication factor (#5815)
* Make notebook limits configurable with a multiplication factor
* Make limits configurable under advanced section
* run prettier to format frontend code
* fix formatting and add rounding in backend
* Return error if limit is smaller than request
* Allow disabling limitFactor by setting it to none
* review: remove camelCase in python backend
* fix: update spawner_ui_config.yaml in manifests directory
* review: fix setting limits backend
* review: remove unnecessary check from backend
* notebook-servers: Update JupyterLab and add Git Extension (#5846)
* chore: Add comment to reference RStudio license. (#5884)
* CI/CD: add kustomize build tests (#5919)
* Add CI format checks for the Volumes web app (#5820)
* vwa(front): Add npm script to check the formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update the package-lock.json
Run `npm install` to bring the package-lock.json up to date
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Remove unused dockerignore file
We have created a global dockerignore file for all the web apps in the
parent dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Don't copy node_modules in dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(make): Don't include dockerignore
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(vwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Copy only necessary files for build
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: Use docker context instead of cd ..
Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboard-controller: fix binding issue (#5925)
* JWA: Don't override assets with logos ConfigMap (#5942)
* jwa(front): Add static logos in the app
The app does not contain the logos' svgs in its source code/static
files. This results in the icons to not show when developing locally.
This commit adds the svgs found in the logos ConfigMap to the static
files of the app as well.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Change logos fetch url
Change the URLs of the logos from `static/assets/*` to
`static/assets/logos`.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(manifests): Don't override assets with logos
Mount the ConfigMap under the `static/assets/logos` directory to not
override the contents of the entire assets dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Make it possible to add Namespaced menu items (#5871)
* Make it possible to add Namespaced menu items
* Reduce the nesting levels
* FIX The number of gpu must be set as string in Kubernetes/Openshift (#5891)
* Update form.py
* Update form.py
* Update form-default.component.ts
* fix whitespace issue
* feat(jupyter): add fonts as assets to service (#5691)
* cwa(front): Ignore font files in assets
* feat(jupyter): add fonts as assets to service
* CRUD: fonts in common
* CWA: Remove link to css file
* jwa(front): Remove font assets from jupyter
Co-authored-by: Wendy Gaultier <wvgaultier@gmail.com>
* Update base notebook for Renovate compatibility (#5955)
* Update base notebook for Renovate compatibility
* Separate kubectl and S6 arch
* Update jupyter, rstudio and vs code notebook images + allow rstudio in iframe (#5961)
* Update jupyter, rstudio and vs code notebook images
* Remove sed and use substring removal
* Make menu bar scrollable again (#5964)
* [fix]: Make jupyter-web-app parse workspace volume MountPath (#5952)
* [fix]: Make jupyter-web-app parse workspace volume MountPath
- workspace volume path was fixed with "/home/jovyan"
- it should be enable to parse from jupyter-web-app-config's data
* change parsing key correctly
* Remove the f-strings in the Jupyter web app's backend (#5680)
* Notebook servers: Add explanation about kernel not connecting (#5920)
* fix(profile-controller): KNative probes (#5848)
Knative control-plane components need to probe certain paths of Knative
Pods, in order to function correctly. These paths are:
- /healthz
- /metrics
- /ready
- /wait-for-drain
For this reason, we extend the Profile Controller to apply an Istio
AuthorizationPolicy that allows traffic to these HTTP paths for Pods in
user namespaces, as per Knative's instructions:
https://knative.dev/docs/serving/istio-authorization/#allowing-access-from-system-pods-by-paths
This only fixes requests through the public ingress. Cluster-internal
traffic and predictor-transformer use-cases are not supported yet. We
continue discussing these in kubeflow#5965.
Refs kubeflow#5965
Refs kubeflow/kfserving#1558
Signed-off-by: Yurii Komar <subreptivus@gmail.com>
* feat(jupyter): Support hiding image registry/tag (#5681)
* feat(jupyter): Support hiding image registry/tag
* feat(jupyter): Support hiding VSCode/RStudio images registry/tag
* rebasing onto upstream master
* fix: formatting with prettier and set default hideRegistry=true
* fix: move hideRegistry and hideTag from spawnerFormDefaults.image
* fix whitespace
* add tooltip for images
Co-authored-by: JessicaBarh <jessicabarhoma@gmail.com>
* Update dockerfiles and make compatible with Renovate (#5968)
* Update dockerfiles and make compatible with Renovate
* Set memory for jupyter pytorch to the same as jupyter tensorflow
* Update protobuf
* Remove conda version and use substring expansion
* Update SQLAlchemy
* Update dill
* Create OWNERS file in .github folder for Renovate config + workflows (#5983)
* Extend deadline for PyTorch image building (#5991)
* Allow user to add/delete labels to user namespace using ConfigMap. Fix #5712 (#5761)
The profile-controller applies a hardcoded list of labels to Profile
namespaces. Make this list of labels configurable with a ConfigMap. The
new list of steps for the profile-controller is:
1. **(new)** Profile-controller starts and reads the file given by the
`--namespace-labels-path` CLI flag (defaults to
`/etc/profile-controller/namespace-labels.yaml`). This file contains
a YAML dict of label key/values to add to each Profile namespace.
2. Profile-controller creates namespace.
3. Profile-controller merges existing namespace labels with given
labels. A given label is applied ONLY if it doesn't exist already.
4. **(new)** If a given label value is empty (``), remove the label from
the namespace if it already exists.
We are using a ConfigMap instead of a plain CLI flag, so that users can
change the list of labels without restarting the profile-controller.
Closes #5712
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Co-authored-by: James Liu <jamxl@google.com>
Co-authored-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Update last batch of notebook server Dockerfiles (#5997)
* Update spawner_ui_config.yaml with new tags (#5998)
* Update images in spawner_ui_config.yaml
* Update manifest image tags
* CRUD web apps: i18n (#5880)
* feat(jupyter): add modules for translations
* feat(jupyter): fix path for translations + add GPU translations
* feat(jupyter): add translations
* feat(jupyter): add translations to form-default
* feat(jupyter): add translations to affinity/tolerations
* feat(jupyter): add translations to Image Pull Policy
* feat(jupyter): remove imports from app.module.ts + fix translations
* web-apps(front): add TranslationModule to common for jupyter
* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file
* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message
* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects
* feat(volume): add translations for volume
* feat(jupyter): refactor asset file
* Update asset files for all folders
* feat(tensorboards): add i18n
Update all asset files
* cwa: add new translations
* cwa: Add README documentation
* fix: formatting with prettier
* Fix tests
* Fix python format
* remove comment
Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>
* Remove deprecated JWA (#5959)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Sync spawner yaml from source to manifests (#5999)
* notebooks: Add additional PGP server for RStudio package validation (#6010)
* Change PGP server for RStudio validation to pgp.surfnet.nl
* Add as secondary keyserver
* Add support for ServiceAccountName and AutomountServiceAccountName to admission-webhook (#5939)
* WA: Use relative paths for fetching translation files (#6034)
* jwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Update CRUD web apps from Angular 8 to Angular 12 (#6004)
* common: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* common: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* common: remove entryComponents and replace TestBed.get with TestBed.inject
Edit files manually
* common: make compatible with Angular 9
Edit files manually
* common: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* update kubeflow-common project dependencies
* common: add @angular/localize
ng add @angular/localize
* jupyter: update angular core and cli 8
ng update @angular/core@8 @angular/cli@8
* jupyter: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* jupyter: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* jupyter: remove entryComponents
Edit file manually
* jupyter: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* jupyter: add @angular/localize
ng add @angular/localize
* tensorboards: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* tensorboards: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* tensorboards: remove entryComponents and replace TestBed.get with TestBed.inje…
Edit files manually
* tensorboards: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* tensorboards: add @angular/localize
ng add @angular/localize
* Fix tensorboards-web-app run-dev in makefile
Edit file manually
* volumes: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* volumes: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* volumes: remove entryComponents and replace TestBed.get with TestBe…
Edit files manually
* volumes: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* volumes: add @angular/localize
ng add @angular/localize
* common: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10 --force
* common: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* update kubeflow-common project dependencies
Edit file manually
* common: update fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* common: fix font location
Edit file manually
* jupyter: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* jupyter: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* jupyter: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* tensorboards: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* tensorboards: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* tensorboards: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* volumes: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* volumes: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* volumes: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* common: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* common: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* common: install @angular-devkit/core@11
npm install --save-dev @angular-devkit/core@11
* common: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* common: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* update kubeflow-common project dependencies
Edit file manually
* jupyter: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* jupyter: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* tensorboards: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* tensorboards: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* tensorboards: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* tensorboards: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* volumes: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* volumes: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* volumes: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* volumes: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* common: Fix CI failure
* jupyter: npm run format:write
npm run format:write
* volumes: npm run format:write
npm run format:write
* tensorboards: manually run prettier
prettier --write 'src/**/*.{js,ts,html,scss,css}'
* common: Fix MockComponent entryComponents for CI
Manually edit file
* common: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* common: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* common: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* update kubeflow-common project dependencies
Edit file manually
* common: fix Intl.DateTimeFormatOptions
Edit file manually. Type of defaultDateOptions and defaultTimeOptions needs to explicitly be set to Intl.DateTimeFormatOptions.
* jupyter: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* jupyter: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* tensorboards: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* tensorboards: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* tensorboards: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* volumes: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* volumes: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* volumes: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* common: update and audit packages
npm update && npm audit fix && npm i lodash-es@4.17.21 && npm i material-icons@0.7.3
* jupyter: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* tensorboards: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* volumes: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* jupyter: npm run format:write
npm run format:write
* lists roadmap in reverse chronological order (#6055)
Signed-off-by: Malini Bhandaru <mbhandaru@vmware.com>
* Correct missing predicates in controller watches. Fixes #5326 (#5873)
Co-authored-by: Filinto Duran <fduran@d2iq.com>
* fix(web-apps): Use Angular's i18n proposed implementation (#6065)
* jwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormImage
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAdvancedOptions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAffinityTolerations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormConfigurations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormCpuRam
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormDataVolumes
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormGpus
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FromName
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormWorkspaceVolume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Volume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize to peerDependencies
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Import $localize in library
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n RokService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ConfirmDialog
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ResourceTable
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n SnackBar
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-app(front): i18n NameNamespaceSelector
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Remove ngx-translate
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa: Update READMEs
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize when testing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* [CentralDashboard] Add entry for Models web app (#6085)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Interact with the namespace selector (#5995)
* Interact with the namespace selector
* Use namespace given as an argument
* Keep the index of selected item
* fix(jwa): Fix limits calculation when limitFactor is none (#6058)
* jwa(front): Don't allow NaN values in limits
The UI should always catch a NaN value and don't add it in the form.
Currently this is the case for the cpu/memory limits.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Limits should not be changed if dirty
If the user has manually edited the limits fields then the UI should not
try to automatically calculate them again, using the limitFactors.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix NaN in Kubeflow Notebooks (#6092)
* Fix NaN in Kubeflow Notebooks
* add a validation check for NaN values
* fix: validation check if value is None
* lint: fix line length
* add section for 1.4; small updates for 1.3 section (#6082)
* add section for 1.4; small updates for 1.3 section
* refer to training operators consistently; add link to Notebooks roadmap.
* address @Bobgy feedback regarding Kubeflow Pipelines portions of 1.4 roadmap
* Remove virtualservice timeout to prevent websocket disconnect (#6126)
In the existing version, the 'timeout: 300s' added to the notebook's virtual service would cause websockets to disconnect at the 5 minute mark, causing the Jupyter Notebook web terminal function to hang. This is described in https://github.com/kubeflow/kubeflow/issues/6124.
* fix(admission-webhook): attach namespace to pod request if pod does not have it (#6052)
* fix(admission-webhook): attach namespace to pod request if pod does not have it
* Apply suggestions from code review
Add more explicit logs
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
* Add more explicit log
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
* Fix notebook base image gpg keys (#6138)
* update links for new testing infra (#6144)
* Add more root OWNERS (#6146)
* Improve README for example-notebook-servers (#6165)
* jwa(front): Don't disable vendors with no GPUs (#6171)
JWA should not block users from selecting GPUs if the current cluster
nodes do not have any GPUs attached to them. We've seen users that have
autoscaled nodegroups for GPUs, so a GPU node will be added to the
cluster once a Pod has requested it.
Refs: arrikto/dev#1484
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Bump Golang version in PodDefaults, TensorBoard Controller and KFAM to 1.17 (#6180)
* kfam: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboards: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Update Notebooks README regarding custom packages (#6176)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix reference to PodPreset as PodDefault (#6184)
* fix: tensorboard-controller is killed due to out of memory (#6148)
* Update manager.yaml
* Update manager.yaml
* fix(web-apps): Use relative path for --deploy-url build. #5566 (#6206)
* fix(web-apps): Use relative path for --base-href build
* volume web app should use volume base-href
* Document for cutting Kubeflow website release. (#6198)
* Document for cutting Kubeflow website release.
* Update docs_dev/releasing.md
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* Update docs_dev/releasing.md
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* address comment
* canonical name
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* Change namespace label for Katib metrics collector injection (#6225)
* fix(backend): tensorboard-controller does not work because of missing permissions (#6216)
* add(web-apps): i18n Fr translations (#6122)
* chore(docs): It's better to refer to the cli documents, not repo's readme (#6239)
* fix(docs): Fix the 404 K8s docs link (#6236)
* nit: typo in README.md (#6211)
* web-apps(front) : change error msg for min (#6193)
* Centraldashboard/add uncaughtexception handler (#6203)
* Central dashboard - Add global uncaught exception handler
* fix comments
* Fix(frontend): Upgrade ts node to v4 (#6242)
* Upgrade ts-node to v10
* Update lock
* admission-webhook-manifests: Update the cert manager from v1alpha2 to v1 (#6230)
* Short term updates to Published Kubeflow Roadmap (#6248)
3 changes - Add info on Kubeflow 1.5 and 1.4.1. Update roadmap to show that Kubeflow 1.4 was delivered.
* Upgrade the google cloud monitoring node.js client (#6210)
* Upgrade the google cloud monitoring node.js client
* Update package-lock.json
* Upgrade TypeScript to v4
* Update package-lock.json
* run tslint
* fix dashboard sending malformed headers to kfam (#6186)
* correct typo - track to tracked (#6264)
corrected typo "track" to "tracked"
* centraldashboard: Update node and use latest-stable (#6260)
Change the tests to NOT fetch Chromium from the Edge branch, which is develop,
but instead use latest-stable. We saw that edge can have problems from times to
times.
In the same commit we also update the node version to fix CVEs with the current
v12.18.3 version that we had.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Tell user to select a namespace to access namespaced menu item (#6181)
* Fix unnecessary updates of istio AuthorizationPolicy (#6269)
* Introduce a basic proposals flow for more advanced features (#6272)
* Introduce a proposals dir for Notebooks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Move the proposals dir under components
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Secure access to KFAM (#6077)
* fix(notebooks) make culling work with multi-user (#5128) (#5980)
* JWA: Very basic E2E tests to run locally (#6005)
* web-apps(front): Add test attrs selectors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update gitignore for cypress files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Install cypress & npm scripts for e2e
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(e2e): Add first cypress tests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Update the README for e2e instructions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* chore: remove Bobgy from OWNERS
* frontend: Use responsive tables instead of cards (#6316)
* jwa(front): Make ng lint work by ignoring e2e/tsconfig.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Make the table responsive
We introduced all of our changes in the underlying TableComponent. This
component can then be either used independently or inside a material
card.
The changes we did in that component are:
1. Create Output() emitters, since this component can be used directly
2. The config object for a Table row now supports a `style` prop for
defining the list of CSS styles to be applied
2. Remove the truncate classes (small, medium, large) and only have
a boolean value. The user can define the width directly now via the
`style` property in the row's config
3. Modify the classes for aligning contents right and left
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Add table paginator
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Add padding to titlebar text
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Use bigger font for toolbar title
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Use responsive table and toolbar
We refactor both the index and form pages of the app to:
1. Add a top row toolbar with the title of the app and the button to
create a new Notebook
2. Replace the card with a responsive table that shows the items. The
component also has a paginator
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* vwa(front): Use responsive table and toolbar
This commit:
1. Adds a toolbar at the top of the index page with the title of the app
and the button to create a new volume
2. Replaces the card with a responsive table
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* twa(front): Use responsive table and toolbar
This commit:
1. Adds a toolbar at the top of the index page with the title of the app
and a button to create a new TensorBoard instance
2. Replaces the card with a resopnsive table
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* fix the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa(front): Add npm script for running unit tests in docker
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fix unit tests failing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Don't use asterisk in Dockerfiles (#6318)
* wa(docker): Don't copy node_modules
To ensure Kaniko is not copying stale node_moduels folders, even though
we have a dockerignore file, we are explicitly only copying the source
code.
We have seen the build system with Kaniko to fail, due to NFS stale
instances with files in node_modules and expect that this is the root
cause.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Update makefile to use global dockerignore
The dockerfile for TWA was copying over the local dockerignore. This was
overriding the global one we had for all the web apps.
This commit updates the Makefile of the app to use the global
dockerignore that all the apps should use.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6309)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump postcss from 7.0.16 to 7.0.39 in /components/centraldashboard (#6308)
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.16 to 7.0.39.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/7.0.39/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.16...7.0.39)
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/tensorboards/frontend (#6311)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/volumes/frontend (#6310)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/jupyter/frontend (#6312)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update images for the 1.5 rc0 release (#6319)
* Update the releasing version tag
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Run automated script for updating versions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270)
Provide a design doc as a proposal for extending Notebook Controller to
expose idleness for Jupyter. Our proposal is in markdown format and follows
the guidelines of the kubeflow/components/proposal/README.md guide.
You can view the #6270 issue in the following link:
https://github.com/kubeflow/kubeflow/issues/6270
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* review: change the title of the proposal
Change the title of the proposal to only include the
proposed new feature. The new title of the proposal
will now be "Expose Idleness Information for Jupyter
Notebooks".
* review: rename the proposal markdown file
We want to give a more specific name to the markdown
which contains the proposal. Since this proposal
emphasizes on a feature regarding the Jupyter Notebooks,
the new name will be:
20220121-jupyter-notebook-idleness.md
* Synchronize jupyter-web-application role with clusterrole (#6241)
* Update role.yaml
* Update role.yaml
* Update cluster-role.yaml
* Kubeflow Roadmap update - with 1.5 details (#6266)
* Kubeflow Roadmap update - with 1.5 details
These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads.
* correct formatting in KFP features
Moved KFP features under KFP Control Flow doc
* updating KFP section
updating KFP references with updates from KFP team
* Updated the 1.5 release date to March
updated the 1.5 release date to March
* Update ROADMAP.md
change Hyperparameter leader election to Katib leader election
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update ROADMAP.md
improve description and details of feature for metrics collector
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update Katib description for Early stopping in 1.5
updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297)
* notebooks: Update image's tag in make
Modify Makefile to update properly the TAG
based on the git TAG.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Expose last-activity
Extend the notebook-controller to:
* cull idle Notebook Servers based on their new `last-activity`
annotation
* expose the last activity of each Notebook Server as an annotation
on the metadata of the corresponding CR object
Modify notebook_controller.go to:
* update the Last Activity of each Notebook Server that has a
Running pod
* delete the Last Activity Annotation for every Notebook Server
that does not have a Running pod
Extend culler.go to:
* perform culling based on the new `last-activity` annotation and
not based on the `/api/status` endpoint.
* update the last activity of a Notebook Server, based on the
kernels' execution states.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Athanasios Markou <athamark@arrikto.com>
* notebooks: Introduce a DEV env var
We introduce a DEV ENV var to allow admins
develop and test on their local machine their
custom Notebook Controller.
We provide information and instructions inside
the components/notebook-controller/README.md.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add unit tests for last-activity
* Introduce new tests for allKernelsAreIdle()
* Extend the tests for NotebookIsIdle() and for
NotebookNeedsCulling().
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: UpdateNotebookLastActivityAnnotation()
Ensure that UpdateNotebookLastActivityAnnotation() does not return
"true". This function should not return any value.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* jwa: Rework the Storage API of the web app (#6321)
* wa(back): Add helper for deserializing JSON obj
In some cases we might need to construct Python k8s lib objects from the
JSONs that are provided by clients. I.e. the UI will be sending a PVC
object in json format, so the backend will need to create the
corresponding client.V1PersistentVolumeClaim object and submit it.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Serialization helper
Add helper function for converting a k8s-client object into a dict that
can be sent as an HTTP response.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Add dry run to Notebooks and PVCs
The backend will need to be able to create objects with dry-run, in
order to ensure they are valid. The backend will need to check that both
the Notebook and the PVCs can be created beforehand.
This way we avoid the scenario where we create PVCs but the Notebook
fails to be created, and the PVCs are never garbage collected.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Update kubernetes to 0.17
In order to support dry-run we must use the 0.17 version of the Python
k8s client.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Extend api module to patch pvcs
The backend will need to be able to PATCH PVCs in order to set the
ownerReference to the Notebook that mounts the PVCs.
Ref: arrikto/dev/issues/386#issuecomment-856700392
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Work with new Volumes API
The backend API should not add any more layers of abstractions on top of
the K8s API. The backend should expect the client/UI to be sending the
entire PVC spec of a new PVC.
Refs: arrikto/dev/issues/386
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Add unittests for new volumes API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Extend the PVC info returned
We want to show both the access mode and size of the existing PVCs, when
a user clicks on the dropdown to select which PVC to mount.
The backend will need to provide this information to the frontend. We
don't want to send the K8s list of PVCs since this will result in a lot
of unnecessary data to be sent.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(front): Add proxy config for Rok
When developing the Rok flavor locally we will need to be able to open
the Rok chooser. This can be done by using Angular/webpack proxy to
bring the exposed rok service and the app under the same domain.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Remove card from form
The form of the app should not be a big card, but a normal form.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Install AceModule for yaml editing
Install AceModule to allow users to edit yamls of objects.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* wa(front): Change the styling of form sections
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Create common volume components
Component for:
* New PVC and configuring its spec
* Attaching an existing PVC in a Notebook
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Update Rok form for new Volume API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Mark inputs as dirty when restoring Lab
When the UI autofills the form with values from a JupyterLab snapshot
then it should mark the touched fields as dirty. This way if a field has
errors the UI will make that input red.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa: Update ConfigMap in manifests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix format errors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* profiles: Update the permissions for notebook idleness (#6335)
Extend the Profiles Controller to give permissions to Notebooks
controller for making GET requests to notebook's /api/kernels endpoint.
Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Graceful handling of events (#6338)
* notebooks: Handle events gracefully
The controller is not exiting the reconciliation loop after it has
re-emitted a Pod/STS Event as a Notebook Event. This results in the
controller to later on try and GET a Notebook with the name of the Event
that triggered the reconciliation loop.
The controller should exit the reconciliation function once it has
emitted the event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on deleted events
We don't want to trigger the reconciliation function when an event gets
deleted.
If a Notebook would be deleted then the underlying events would
be deleted as well, which results in the reconcile function to get
triggered and try to GET Events and Notebooks with the name of the
deleted event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Fix endless restarts (#6341)
* notebooks: Update notebook if timestamp changed
We don't want to be updating the spec of the notebook if the timestamp
hasn't changed, since this will lead to constant updates and
reconciliation loops.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Use a deep-copy of the notebook spec
The controller should use a deep-copy of the notebook spec when
calculating the spec for the StatefulSet. If not then we could
update the notebook object without wanting it, since the spec could have
been changed when calculating the STS spec.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add prefix env var only if missing
The controller should be setting OR updating the NB_PREFIX env var.
Previously it would always blindly append it to the spec, which could
result in double entries for the same env var.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Update tags for v1.5.0-rc.1 (#6343)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fix error comparison between pointer and pointer in "CopyStatefulSetFields" (#6195)
error comparison between pointer and pointer in "CopyStatefulSetFields"
* [bugfix]: update unsupported links to latest pages (#6192)
* centraldashboard: Add KServe overlay (#6383)
Configure the dashboard to use the KServe app instead of the KFServing
0.6.1 one.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on Events deletion (#6391)
The controller should not trigger the reconcile loop when an Event is
deleted. Previously the controller would run the reconciliation loop on
any event deletion.
This commit updates it to not run the loop for ANY event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Create v1.5.0-rc.2 images (#6394)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* release: Images for the 1.5.0 tag (#6398)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* added env for app secure cookies (#6395)
* build(deps): bump github.com/gogo/protobuf from 1.1.1 to 1.3.2 in /components/tensorboard-controller (#6424)
Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.1.1 to 1.3.2.
- [Release notes](https://github.com/gogo/protobuf/releases)
- [Commits](https://github.com/gogo/protobuf/compare/v1.1.1...v1.3.2)
---
updated-dependencies:
- dependency-name: github.com/gogo/protobuf
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump notebook from 6.4.0 to 6.4.10 in /components/example-notebook-servers/jupyter (#6431)
Bumps [notebook](http://jupyter.org) from 6.4.0 to 6.4.10.
---
updated-dependencies:
- dependency-name: notebook
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/tensorboards/frontend (#6417)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/jupyter/frontend (#6429)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.8 in /components/crud-web-apps/tensorboards/frontend (#6357)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.8)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/volumes/frontend (#6358)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/jupyter/frontend (#6359)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump lodash-es from 4.17.11 to 4.17.21 in /components/crud-web-apps/tensorboards/frontend (#6402)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.21)
---
updated-dependencies:
- dependency-name: lodash-es
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6416)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/volumes/frontend (#6423)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump undefsafe from 2.0.2 to 2.0.5 in /components/centraldashboard (#6342)
Bumps [undefsafe](https://github.com/remy/undefsafe) from 2.0.2 to 2.0.5.
- [Release notes](https://github.com/remy/undefsafe/releases)
- [Commits](https://github.com/remy/undefsafe/compare/v2.0.2...v2.0.5)
---
updated-dependencies:
- dependency-name: undefsafe
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6378)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/tensorboards/frontend (#6379)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6386)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/tensorboards/frontend (#6387)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump moment from 2.24.0 to 2.29.2 in /components/centraldashboard (#6432)
Bumps [moment](https://github.com/moment/moment) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2)
---
updated-dependencies:
- dependency-name: moment
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/volumes/frontend (#6380)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.4.7 to 1.5.10 in /components/centraldashboard (#6377)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/volumes/frontend (#6388)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/jupyter/frontend (#6389)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/jupyter/frontend (#6441)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6437)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3…
chuckbelisle
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Oct 11, 2022
* releasing: Add WG-Notebooks leads to release owners (#5777)
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Specify commonLabels for tensorboard-controller (#5780)
* Remove jlewi as an approver (#5786)
Removing myself as an owner. This should lead to better auto-assignment of code reviews.
* Update notebook server base images (#5804)
* Update second layer docker images to new tags and some python deps (#5809)
* Update image tags and python packages in pytorch and tensorflow full dockerfiles (#5817)
* Add CI format checks for the Jupyter web app (#5811)
* jwa(front): Add npm rule for checking the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci: Add common tasks for format checks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(jwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix formatting
Run `npm run format:write` on frontend
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Include prettier in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Don't copy node_modules in Dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps: Add global dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Remove unused dockerignore file
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(make): Don't include dockerignore and cleanup
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* initial notebook server images README.md (#5818)
* tensorboard-controller: Fix scheduling unbound PVCs (#5819)
When the TB controller attempts to schedule a RWO PVC it checks its
accessModes in the PVC status. The controller panics if the list is
empty.
This commit adds a check to ensure the list is not empty.
Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
* Fix profile-controller CRD pruning issue (#5822)
* api: Add marker for preserving unknown fields in Plugins
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* manifests: Regenerate manifests
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Remove Logo Trademarks from the Jupyter Web App and make logos configurable (#5823)
* rebase: Make logos configurable in configmap and remove trademark references
Rebased to remove the changes to the package-lock.json
* review: add suggested changes and add image group section to README
* Make notebook limits configurable with a multiplication factor (#5815)
* Make notebook limits configurable with a multiplication factor
* Make limits configurable under advanced section
* run prettier to format frontend code
* fix formatting and add rounding in backend
* Return error if limit is smaller than request
* Allow disabling limitFactor by setting it to none
* review: remove camelCase in python backend
* fix: update spawner_ui_config.yaml in manifests directory
* review: fix setting limits backend
* review: remove unnecessary check from backend
* notebook-servers: Update JupyterLab and add Git Extension (#5846)
* chore: Add comment to reference RStudio license. (#5884)
* CI/CD: add kustomize build tests (#5919)
* Add CI format checks for the Volumes web app (#5820)
* vwa(front): Add npm script to check the formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update the package-lock.json
Run `npm install` to bring the package-lock.json up to date
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Fix formatting
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Remove unused dockerignore file
We have created a global dockerignore file for all the web apps in the
parent dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(docker): Don't copy node_modules in dockerfile
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(make): Don't include dockerignore
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* ci(vwa): Add format check tasks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(docker): Copy only necessary files for build
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: Use docker context instead of cd ..
Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboard-controller: fix binding issue (#5925)
* JWA: Don't override assets with logos ConfigMap (#5942)
* jwa(front): Add static logos in the app
The app does not contain the logos' svgs in its source code/static
files. This results in the icons to not show when developing locally.
This commit adds the svgs found in the logos ConfigMap to the static
files of the app as well.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Change logos fetch url
Change the URLs of the logos from `static/assets/*` to
`static/assets/logos`.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(manifests): Don't override assets with logos
Mount the ConfigMap under the `static/assets/logos` directory to not
override the contents of the entire assets dir.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Make it possible to add Namespaced menu items (#5871)
* Make it possible to add Namespaced menu items
* Reduce the nesting levels
* FIX The number of gpu must be set as string in Kubernetes/Openshift (#5891)
* Update form.py
* Update form.py
* Update form-default.component.ts
* fix whitespace issue
* feat(jupyter): add fonts as assets to service (#5691)
* cwa(front): Ignore font files in assets
* feat(jupyter): add fonts as assets to service
* CRUD: fonts in common
* CWA: Remove link to css file
* jwa(front): Remove font assets from jupyter
Co-authored-by: Wendy Gaultier <wvgaultier@gmail.com>
* Update base notebook for Renovate compatibility (#5955)
* Update base notebook for Renovate compatibility
* Separate kubectl and S6 arch
* Update jupyter, rstudio and vs code notebook images + allow rstudio in iframe (#5961)
* Update jupyter, rstudio and vs code notebook images
* Remove sed and use substring removal
* Make menu bar scrollable again (#5964)
* [fix]: Make jupyter-web-app parse workspace volume MountPath (#5952)
* [fix]: Make jupyter-web-app parse workspace volume MountPath
- workspace volume path was fixed with "/home/jovyan"
- it should be enable to parse from jupyter-web-app-config's data
* change parsing key correctly
* Remove the f-strings in the Jupyter web app's backend (#5680)
* Notebook servers: Add explanation about kernel not connecting (#5920)
* fix(profile-controller): KNative probes (#5848)
Knative control-plane components need to probe certain paths of Knative
Pods, in order to function correctly. These paths are:
- /healthz
- /metrics
- /ready
- /wait-for-drain
For this reason, we extend the Profile Controller to apply an Istio
AuthorizationPolicy that allows traffic to these HTTP paths for Pods in
user namespaces, as per Knative's instructions:
https://knative.dev/docs/serving/istio-authorization/#allowing-access-from-system-pods-by-paths
This only fixes requests through the public ingress. Cluster-internal
traffic and predictor-transformer use-cases are not supported yet. We
continue discussing these in kubeflow#5965.
Refs kubeflow#5965
Refs kubeflow/kfserving#1558
Signed-off-by: Yurii Komar <subreptivus@gmail.com>
* feat(jupyter): Support hiding image registry/tag (#5681)
* feat(jupyter): Support hiding image registry/tag
* feat(jupyter): Support hiding VSCode/RStudio images registry/tag
* rebasing onto upstream master
* fix: formatting with prettier and set default hideRegistry=true
* fix: move hideRegistry and hideTag from spawnerFormDefaults.image
* fix whitespace
* add tooltip for images
Co-authored-by: JessicaBarh <jessicabarhoma@gmail.com>
* Update dockerfiles and make compatible with Renovate (#5968)
* Update dockerfiles and make compatible with Renovate
* Set memory for jupyter pytorch to the same as jupyter tensorflow
* Update protobuf
* Remove conda version and use substring expansion
* Update SQLAlchemy
* Update dill
* Create OWNERS file in .github folder for Renovate config + workflows (#5983)
* Extend deadline for PyTorch image building (#5991)
* Allow user to add/delete labels to user namespace using ConfigMap. Fix #5712 (#5761)
The profile-controller applies a hardcoded list of labels to Profile
namespaces. Make this list of labels configurable with a ConfigMap. The
new list of steps for the profile-controller is:
1. **(new)** Profile-controller starts and reads the file given by the
`--namespace-labels-path` CLI flag (defaults to
`/etc/profile-controller/namespace-labels.yaml`). This file contains
a YAML dict of label key/values to add to each Profile namespace.
2. Profile-controller creates namespace.
3. Profile-controller merges existing namespace labels with given
labels. A given label is applied ONLY if it doesn't exist already.
4. **(new)** If a given label value is empty (``), remove the label from
the namespace if it already exists.
We are using a ConfigMap instead of a plain CLI flag, so that users can
change the list of labels without restarting the profile-controller.
Closes #5712
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Co-authored-by: James Liu <jamxl@google.com>
Co-authored-by: Yannis Zarkadas <yanniszark@arrikto.com>
* Update last batch of notebook server Dockerfiles (#5997)
* Update spawner_ui_config.yaml with new tags (#5998)
* Update images in spawner_ui_config.yaml
* Update manifest image tags
* CRUD web apps: i18n (#5880)
* feat(jupyter): add modules for translations
* feat(jupyter): fix path for translations + add GPU translations
* feat(jupyter): add translations
* feat(jupyter): add translations to form-default
* feat(jupyter): add translations to affinity/tolerations
* feat(jupyter): add translations to Image Pull Policy
* feat(jupyter): remove imports from app.module.ts + fix translations
* web-apps(front): add TranslationModule to common for jupyter
* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file
* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message
* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects
* feat(volume): add translations for volume
* feat(jupyter): refactor asset file
* Update asset files for all folders
* feat(tensorboards): add i18n
Update all asset files
* cwa: add new translations
* cwa: Add README documentation
* fix: formatting with prettier
* Fix tests
* Fix python format
* remove comment
Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>
* Remove deprecated JWA (#5959)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Sync spawner yaml from source to manifests (#5999)
* notebooks: Add additional PGP server for RStudio package validation (#6010)
* Change PGP server for RStudio validation to pgp.surfnet.nl
* Add as secondary keyserver
* Add support for ServiceAccountName and AutomountServiceAccountName to admission-webhook (#5939)
* WA: Use relative paths for fetching translation files (#6034)
* jwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Use relative path for i18n json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Update CRUD web apps from Angular 8 to Angular 12 (#6004)
* common: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* common: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* common: remove entryComponents and replace TestBed.get with TestBed.inject
Edit files manually
* common: make compatible with Angular 9
Edit files manually
* common: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* update kubeflow-common project dependencies
* common: add @angular/localize
ng add @angular/localize
* jupyter: update angular core and cli 8
ng update @angular/core@8 @angular/cli@8
* jupyter: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* jupyter: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* jupyter: remove entryComponents
Edit file manually
* jupyter: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* jupyter: add @angular/localize
ng add @angular/localize
* tensorboards: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* tensorboards: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* tensorboards: remove entryComponents and replace TestBed.get with TestBed.inje…
Edit files manually
* tensorboards: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* tensorboards: add @angular/localize
ng add @angular/localize
* Fix tensorboards-web-app run-dev in makefile
Edit file manually
* volumes: update angular core and cli to 9
ng update @angular/core@9 @angular/cli@9
* volumes: update material, cdk and cdk-experimental to 9
ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9
* volumes: remove entryComponents and replace TestBed.get with TestBe…
Edit files manually
* volumes: update fontawesome to 0.6.0
npm i @fortawesome/angular-fontawesome@0.6.0
* volumes: add @angular/localize
ng add @angular/localize
* common: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10 --force
* common: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* update kubeflow-common project dependencies
Edit file manually
* common: update fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* common: fix font location
Edit file manually
* jupyter: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* jupyter: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* jupyter: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* tensorboards: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* tensorboards: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* tensorboards: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* volumes: update angular-fontawesome to 0.7.0
npm i @fortawesome/angular-fontawesome@0.7.0
* volumes: update angular core and cli to 10
ng update @angular/core@10 @angular/cli@10
* volumes: update material, cdk and cdk-experimental to 10
ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10
* common: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* common: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* common: install @angular-devkit/core@11
npm install --save-dev @angular-devkit/core@11
* common: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* common: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* update kubeflow-common project dependencies
Edit file manually
* jupyter: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* jupyter: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* tensorboards: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* tensorboards: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* tensorboards: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* tensorboards: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* volumes: update angular-fontawesome to 0.8.2
npm i @fortawesome/angular-fontawesome@0.8.2
* volumes: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* volumes: update angular core and cli to 11
ng update @angular/core@11 @angular/cli@11
* volumes: update material, cdk and cdk-experimental to 11
ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11
* common: Fix CI failure
* jupyter: npm run format:write
npm run format:write
* volumes: npm run format:write
npm run format:write
* tensorboards: manually run prettier
prettier --write 'src/**/*.{js,ts,html,scss,css}'
* common: Fix MockComponent entryComponents for CI
Manually edit file
* common: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* common: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* common: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* update kubeflow-common project dependencies
Edit file manually
* common: fix Intl.DateTimeFormatOptions
Edit file manually. Type of defaultDateOptions and defaultTimeOptions needs to explicitly be set to Intl.DateTimeFormatOptions.
* jupyter: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* jupyter: update codelyzer to 6.0.2
npm i codelyzer@6.0.2
* jupyter: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* jupyter: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* tensorboards: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* tensorboards: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* tensorboards: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* volumes: update angular-fontawesome to 0.9.0
npm i @fortawesome/angular-fontawesome@0.9.0
* volumes: update angular core and cli to 12
ng update @angular/core@12 @angular/cli@12
* volumes: update material, cdk and cdk-experimental to 12
ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12
* common: update and audit packages
npm update && npm audit fix && npm i lodash-es@4.17.21 && npm i material-icons@0.7.3
* jupyter: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* tensorboards: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* volumes: update and audit packages
npm update && npm audit fix && npm i material-icons@0.7.3
* jupyter: npm run format:write
npm run format:write
* lists roadmap in reverse chronological order (#6055)
Signed-off-by: Malini Bhandaru <mbhandaru@vmware.com>
* Correct missing predicates in controller watches. Fixes #5326 (#5873)
Co-authored-by: Filinto Duran <fduran@d2iq.com>
* fix(web-apps): Use Angular's i18n proposed implementation (#6065)
* jwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormImage
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAdvancedOptions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormAffinityTolerations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormConfigurations
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormCpuRam
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormDataVolumes
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormGpus
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FromName
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n FormWorkspaceVolume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Volume
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize to peerDependencies
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Import $localize in library
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n RokService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ConfirmDialog
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n ResourceTable
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n SnackBar
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-app(front): i18n NameNamespaceSelector
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Remove ngx-translate
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(back): Don't parse keys in status
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): i18n Form
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* vwa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(back): Revert backend messages
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n rules in package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Add i18n for french in angular.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n Index
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n BackendService
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): i18n App
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Update translation language files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa(front): Remove ngx-translate from package.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa: Update READMEs
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* web-apps(front): Add localize when testing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* [CentralDashboard] Add entry for Models web app (#6085)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Interact with the namespace selector (#5995)
* Interact with the namespace selector
* Use namespace given as an argument
* Keep the index of selected item
* fix(jwa): Fix limits calculation when limitFactor is none (#6058)
* jwa(front): Don't allow NaN values in limits
The UI should always catch a NaN value and don't add it in the form.
Currently this is the case for the cpu/memory limits.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Limits should not be changed if dirty
If the user has manually edited the limits fields then the UI should not
try to automatically calculate them again, using the limitFactors.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix NaN in Kubeflow Notebooks (#6092)
* Fix NaN in Kubeflow Notebooks
* add a validation check for NaN values
* fix: validation check if value is None
* lint: fix line length
* add section for 1.4; small updates for 1.3 section (#6082)
* add section for 1.4; small updates for 1.3 section
* refer to training operators consistently; add link to Notebooks roadmap.
* address @Bobgy feedback regarding Kubeflow Pipelines portions of 1.4 roadmap
* Remove virtualservice timeout to prevent websocket disconnect (#6126)
In the existing version, the 'timeout: 300s' added to the notebook's virtual service would cause websockets to disconnect at the 5 minute mark, causing the Jupyter Notebook web terminal function to hang. This is described in https://github.com/kubeflow/kubeflow/issues/6124.
* fix(admission-webhook): attach namespace to pod request if pod does not have it (#6052)
* fix(admission-webhook): attach namespace to pod request if pod does not have it
* Apply suggestions from code review
Add more explicit logs
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
* Add more explicit log
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>
* Fix notebook base image gpg keys (#6138)
* update links for new testing infra (#6144)
* Add more root OWNERS (#6146)
* Improve README for example-notebook-servers (#6165)
* jwa(front): Don't disable vendors with no GPUs (#6171)
JWA should not block users from selecting GPUs if the current cluster
nodes do not have any GPUs attached to them. We've seen users that have
autoscaled nodegroups for GPUs, so a GPU node will be added to the
cluster once a Pod has requested it.
Refs: arrikto/dev#1484
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Bump Golang version in PodDefaults, TensorBoard Controller and KFAM to 1.17 (#6180)
* kfam: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* tensorboards: Upgrade go to 1.17
Update to a more recent docker image that has a newer version of
openssl.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Update Notebooks README regarding custom packages (#6176)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix reference to PodPreset as PodDefault (#6184)
* fix: tensorboard-controller is killed due to out of memory (#6148)
* Update manager.yaml
* Update manager.yaml
* fix(web-apps): Use relative path for --deploy-url build. #5566 (#6206)
* fix(web-apps): Use relative path for --base-href build
* volume web app should use volume base-href
* Document for cutting Kubeflow website release. (#6198)
* Document for cutting Kubeflow website release.
* Update docs_dev/releasing.md
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* Update docs_dev/releasing.md
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* address comment
* canonical name
Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>
* Change namespace label for Katib metrics collector injection (#6225)
* fix(backend): tensorboard-controller does not work because of missing permissions (#6216)
* add(web-apps): i18n Fr translations (#6122)
* chore(docs): It's better to refer to the cli documents, not repo's readme (#6239)
* fix(docs): Fix the 404 K8s docs link (#6236)
* nit: typo in README.md (#6211)
* web-apps(front) : change error msg for min (#6193)
* Centraldashboard/add uncaughtexception handler (#6203)
* Central dashboard - Add global uncaught exception handler
* fix comments
* Fix(frontend): Upgrade ts node to v4 (#6242)
* Upgrade ts-node to v10
* Update lock
* admission-webhook-manifests: Update the cert manager from v1alpha2 to v1 (#6230)
* Short term updates to Published Kubeflow Roadmap (#6248)
3 changes - Add info on Kubeflow 1.5 and 1.4.1. Update roadmap to show that Kubeflow 1.4 was delivered.
* Upgrade the google cloud monitoring node.js client (#6210)
* Upgrade the google cloud monitoring node.js client
* Update package-lock.json
* Upgrade TypeScript to v4
* Update package-lock.json
* run tslint
* fix dashboard sending malformed headers to kfam (#6186)
* correct typo - track to tracked (#6264)
corrected typo "track" to "tracked"
* centraldashboard: Update node and use latest-stable (#6260)
Change the tests to NOT fetch Chromium from the Edge branch, which is develop,
but instead use latest-stable. We saw that edge can have problems from times to
times.
In the same commit we also update the node version to fix CVEs with the current
v12.18.3 version that we had.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Tell user to select a namespace to access namespaced menu item (#6181)
* Fix unnecessary updates of istio AuthorizationPolicy (#6269)
* Introduce a basic proposals flow for more advanced features (#6272)
* Introduce a proposals dir for Notebooks
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Move the proposals dir under components
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Secure access to KFAM (#6077)
* fix(notebooks) make culling work with multi-user (#5128) (#5980)
* JWA: Very basic E2E tests to run locally (#6005)
* web-apps(front): Add test attrs selectors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Update gitignore for cypress files
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Install cypress & npm scripts for e2e
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(e2e): Add first cypress tests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa: Update the README for e2e instructions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* chore: remove Bobgy from OWNERS
* frontend: Use responsive tables instead of cards (#6316)
* jwa(front): Make ng lint work by ignoring e2e/tsconfig.json
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Make the table responsive
We introduced all of our changes in the underlying TableComponent. This
component can then be either used independently or inside a material
card.
The changes we did in that component are:
1. Create Output() emitters, since this component can be used directly
2. The config object for a Table row now supports a `style` prop for
defining the list of CSS styles to be applied
2. Remove the truncate classes (small, medium, large) and only have
a boolean value. The user can define the width directly now via the
`style` property in the row's config
3. Modify the classes for aligning contents right and left
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Add table paginator
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Add padding to titlebar text
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* web-apps(front): Use bigger font for toolbar title
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Use responsive table and toolbar
We refactor both the index and form pages of the app to:
1. Add a top row toolbar with the title of the app and the button to
create a new Notebook
2. Replace the card with a responsive table that shows the items. The
component also has a paginator
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* vwa(front): Use responsive table and toolbar
This commit:
1. Adds a toolbar at the top of the index page with the title of the app
and the button to create a new volume
2. Replaces the card with a responsive table
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* twa(front): Use responsive table and toolbar
This commit:
1. Adds a toolbar at the top of the index page with the title of the app
and a button to create a new TensorBoard instance
2. Replaces the card with a resopnsive table
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* fix the format
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* wa(front): Add npm script for running unit tests in docker
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fix unit tests failing
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Don't use asterisk in Dockerfiles (#6318)
* wa(docker): Don't copy node_modules
To ensure Kaniko is not copying stale node_moduels folders, even though
we have a dockerignore file, we are explicitly only copying the source
code.
We have seen the build system with Kaniko to fail, due to NFS stale
instances with files in node_modules and expect that this is the root
cause.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* twa: Update makefile to use global dockerignore
The dockerfile for TWA was copying over the local dockerignore. This was
overriding the global one we had for all the web apps.
This commit updates the Makefile of the app to use the global
dockerignore that all the apps should use.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6309)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump postcss from 7.0.16 to 7.0.39 in /components/centraldashboard (#6308)
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.16 to 7.0.39.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/7.0.39/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.16...7.0.39)
---
updated-dependencies:
- dependency-name: postcss
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/tensorboards/frontend (#6311)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/volumes/frontend (#6310)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/jupyter/frontend (#6312)
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: log4js
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update images for the 1.5 rc0 release (#6319)
* Update the releasing version tag
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Run automated script for updating versions
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270)
Provide a design doc as a proposal for extending Notebook Controller to
expose idleness for Jupyter. Our proposal is in markdown format and follows
the guidelines of the kubeflow/components/proposal/README.md guide.
You can view the #6270 issue in the following link:
https://github.com/kubeflow/kubeflow/issues/6270
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* review: change the title of the proposal
Change the title of the proposal to only include the
proposed new feature. The new title of the proposal
will now be "Expose Idleness Information for Jupyter
Notebooks".
* review: rename the proposal markdown file
We want to give a more specific name to the markdown
which contains the proposal. Since this proposal
emphasizes on a feature regarding the Jupyter Notebooks,
the new name will be:
20220121-jupyter-notebook-idleness.md
* Synchronize jupyter-web-application role with clusterrole (#6241)
* Update role.yaml
* Update role.yaml
* Update cluster-role.yaml
* Kubeflow Roadmap update - with 1.5 details (#6266)
* Kubeflow Roadmap update - with 1.5 details
These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads.
* correct formatting in KFP features
Moved KFP features under KFP Control Flow doc
* updating KFP section
updating KFP references with updates from KFP team
* Updated the 1.5 release date to March
updated the 1.5 release date to March
* Update ROADMAP.md
change Hyperparameter leader election to Katib leader election
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update ROADMAP.md
improve description and details of feature for metrics collector
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update Katib description for Early stopping in 1.5
updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297)
* notebooks: Update image's tag in make
Modify Makefile to update properly the TAG
based on the git TAG.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Expose last-activity
Extend the notebook-controller to:
* cull idle Notebook Servers based on their new `last-activity`
annotation
* expose the last activity of each Notebook Server as an annotation
on the metadata of the corresponding CR object
Modify notebook_controller.go to:
* update the Last Activity of each Notebook Server that has a
Running pod
* delete the Last Activity Annotation for every Notebook Server
that does not have a Running pod
Extend culler.go to:
* perform culling based on the new `last-activity` annotation and
not based on the `/api/status` endpoint.
* update the last activity of a Notebook Server, based on the
kernels' execution states.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Athanasios Markou <athamark@arrikto.com>
* notebooks: Introduce a DEV env var
We introduce a DEV ENV var to allow admins
develop and test on their local machine their
custom Notebook Controller.
We provide information and instructions inside
the components/notebook-controller/README.md.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add unit tests for last-activity
* Introduce new tests for allKernelsAreIdle()
* Extend the tests for NotebookIsIdle() and for
NotebookNeedsCulling().
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: UpdateNotebookLastActivityAnnotation()
Ensure that UpdateNotebookLastActivityAnnotation() does not return
"true". This function should not return any value.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* jwa: Rework the Storage API of the web app (#6321)
* wa(back): Add helper for deserializing JSON obj
In some cases we might need to construct Python k8s lib objects from the
JSONs that are provided by clients. I.e. the UI will be sending a PVC
object in json format, so the backend will need to create the
corresponding client.V1PersistentVolumeClaim object and submit it.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Serialization helper
Add helper function for converting a k8s-client object into a dict that
can be sent as an HTTP response.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Add dry run to Notebooks and PVCs
The backend will need to be able to create objects with dry-run, in
order to ensure they are valid. The backend will need to check that both
the Notebook and the PVCs can be created beforehand.
This way we avoid the scenario where we create PVCs but the Notebook
fails to be created, and the PVCs are never garbage collected.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Update kubernetes to 0.17
In order to support dry-run we must use the 0.17 version of the Python
k8s client.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Extend api module to patch pvcs
The backend will need to be able to PATCH PVCs in order to set the
ownerReference to the Notebook that mounts the PVCs.
Ref: arrikto/dev/issues/386#issuecomment-856700392
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Work with new Volumes API
The backend API should not add any more layers of abstractions on top of
the K8s API. The backend should expect the client/UI to be sending the
entire PVC spec of a new PVC.
Refs: arrikto/dev/issues/386
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Add unittests for new volumes API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Extend the PVC info returned
We want to show both the access mode and size of the existing PVCs, when
a user clicks on the dropdown to select which PVC to mount.
The backend will need to provide this information to the frontend. We
don't want to send the K8s list of PVCs since this will result in a lot
of unnecessary data to be sent.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(front): Add proxy config for Rok
When developing the Rok flavor locally we will need to be able to open
the Rok chooser. This can be done by using Angular/webpack proxy to
bring the exposed rok service and the app under the same domain.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Remove card from form
The form of the app should not be a big card, but a normal form.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Install AceModule for yaml editing
Install AceModule to allow users to edit yamls of objects.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* wa(front): Change the styling of form sections
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Create common volume components
Component for:
* New PVC and configuring its spec
* Attaching an existing PVC in a Notebook
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Update Rok form for new Volume API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Mark inputs as dirty when restoring Lab
When the UI autofills the form with values from a JupyterLab snapshot
then it should mark the touched fields as dirty. This way if a field has
errors the UI will make that input red.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa: Update ConfigMap in manifests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix format errors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* profiles: Update the permissions for notebook idleness (#6335)
Extend the Profiles Controller to give permissions to Notebooks
controller for making GET requests to notebook's /api/kernels endpoint.
Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Graceful handling of events (#6338)
* notebooks: Handle events gracefully
The controller is not exiting the reconciliation loop after it has
re-emitted a Pod/STS Event as a Notebook Event. This results in the
controller to later on try and GET a Notebook with the name of the Event
that triggered the reconciliation loop.
The controller should exit the reconciliation function once it has
emitted the event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on deleted events
We don't want to trigger the reconciliation function when an event gets
deleted.
If a Notebook would be deleted then the underlying events would
be deleted as well, which results in the reconcile function to get
triggered and try to GET Events and Notebooks with the name of the
deleted event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Fix endless restarts (#6341)
* notebooks: Update notebook if timestamp changed
We don't want to be updating the spec of the notebook if the timestamp
hasn't changed, since this will lead to constant updates and
reconciliation loops.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Use a deep-copy of the notebook spec
The controller should use a deep-copy of the notebook spec when
calculating the spec for the StatefulSet. If not then we could
update the notebook object without wanting it, since the spec could have
been changed when calculating the STS spec.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add prefix env var only if missing
The controller should be setting OR updating the NB_PREFIX env var.
Previously it would always blindly append it to the spec, which could
result in double entries for the same env var.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Update tags for v1.5.0-rc.1 (#6343)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fix error comparison between pointer and pointer in "CopyStatefulSetFields" (#6195)
error comparison between pointer and pointer in "CopyStatefulSetFields"
* [bugfix]: update unsupported links to latest pages (#6192)
* centraldashboard: Add KServe overlay (#6383)
Configure the dashboard to use the KServe app instead of the KFServing
0.6.1 one.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on Events deletion (#6391)
The controller should not trigger the reconcile loop when an Event is
deleted. Previously the controller would run the reconciliation loop on
any event deletion.
This commit updates it to not run the loop for ANY event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Create v1.5.0-rc.2 images (#6394)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* release: Images for the 1.5.0 tag (#6398)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* added env for app secure cookies (#6395)
* build(deps): bump github.com/gogo/protobuf from 1.1.1 to 1.3.2 in /components/tensorboard-controller (#6424)
Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.1.1 to 1.3.2.
- [Release notes](https://github.com/gogo/protobuf/releases)
- [Commits](https://github.com/gogo/protobuf/compare/v1.1.1...v1.3.2)
---
updated-dependencies:
- dependency-name: github.com/gogo/protobuf
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump notebook from 6.4.0 to 6.4.10 in /components/example-notebook-servers/jupyter (#6431)
Bumps [notebook](http://jupyter.org) from 6.4.0 to 6.4.10.
---
updated-dependencies:
- dependency-name: notebook
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/tensorboards/frontend (#6417)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/jupyter/frontend (#6429)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.8 in /components/crud-web-apps/tensorboards/frontend (#6357)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.8)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/volumes/frontend (#6358)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/jupyter/frontend (#6359)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump lodash-es from 4.17.11 to 4.17.21 in /components/crud-web-apps/tensorboards/frontend (#6402)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.21)
---
updated-dependencies:
- dependency-name: lodash-es
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6416)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/volumes/frontend (#6423)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump undefsafe from 2.0.2 to 2.0.5 in /components/centraldashboard (#6342)
Bumps [undefsafe](https://github.com/remy/undefsafe) from 2.0.2 to 2.0.5.
- [Release notes](https://github.com/remy/undefsafe/releases)
- [Commits](https://github.com/remy/undefsafe/compare/v2.0.2...v2.0.5)
---
updated-dependencies:
- dependency-name: undefsafe
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6378)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/tensorboards/frontend (#6379)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6386)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/tensorboards/frontend (#6387)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump moment from 2.24.0 to 2.29.2 in /components/centraldashboard (#6432)
Bumps [moment](https://github.com/moment/moment) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2)
---
updated-dependencies:
- dependency-name: moment
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/volumes/frontend (#6380)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.4.7 to 1.5.10 in /components/centraldashboard (#6377)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/volumes/frontend (#6388)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/jupyter/frontend (#6389)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/jupyter/frontend (#6441)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6437)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/c…
chuckbelisle
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Jul 11, 2023
* release: Images for the 1.5.0 tag (#6398)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* added env for app secure cookies (#6395)
* build(deps): bump github.com/gogo/protobuf from 1.1.1 to 1.3.2 in /components/tensorboard-controller (#6424)
Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.1.1 to 1.3.2.
- [Release notes](https://github.com/gogo/protobuf/releases)
- [Commits](https://github.com/gogo/protobuf/compare/v1.1.1...v1.3.2)
---
updated-dependencies:
- dependency-name: github.com/gogo/protobuf
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump notebook from 6.4.0 to 6.4.10 in /components/example-notebook-servers/jupyter (#6431)
Bumps [notebook](http://jupyter.org) from 6.4.0 to 6.4.10.
---
updated-dependencies:
- dependency-name: notebook
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/tensorboards/frontend (#6417)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/jupyter/frontend (#6429)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.8 in /components/crud-web-apps/tensorboards/frontend (#6357)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.8)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/volumes/frontend (#6358)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/jupyter/frontend (#6359)
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)
---
updated-dependencies:
- dependency-name: ajv
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump lodash-es from 4.17.11 to 4.17.21 in /components/crud-web-apps/tensorboards/frontend (#6402)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.21)
---
updated-dependencies:
- dependency-name: lodash-es
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6416)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/volumes/frontend (#6423)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump undefsafe from 2.0.2 to 2.0.5 in /components/centraldashboard (#6342)
Bumps [undefsafe](https://github.com/remy/undefsafe) from 2.0.2 to 2.0.5.
- [Release notes](https://github.com/remy/undefsafe/releases)
- [Commits](https://github.com/remy/undefsafe/compare/v2.0.2...v2.0.5)
---
updated-dependencies:
- dependency-name: undefsafe
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6378)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/tensorboards/frontend (#6379)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6386)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/tensorboards/frontend (#6387)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump moment from 2.24.0 to 2.29.2 in /components/centraldashboard (#6432)
Bumps [moment](https://github.com/moment/moment) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2)
---
updated-dependencies:
- dependency-name: moment
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/volumes/frontend (#6380)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.4.7 to 1.5.10 in /components/centraldashboard (#6377)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/volumes/frontend (#6388)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/jupyter/frontend (#6389)
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)
---
updated-dependencies:
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/jupyter/frontend (#6441)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6437)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.1.23...3.3.2)
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/volumes/frontend (#6439)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump shelljs from 0.8.3 to 0.8.5 in /components/centraldashboard (#6284)
Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.3 to 0.8.5.
- [Release notes](https://github.com/shelljs/shelljs/releases)
- [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/shelljs/shelljs/compare/v0.8.3...v0.8.5)
---
updated-dependencies:
- dependency-name: shelljs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump shelljs from 0.8.4 to 0.8.5 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6285)
Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5.
- [Release notes](https://github.com/shelljs/shelljs/releases)
- [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5)
---
updated-dependencies:
- dependency-name: shelljs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/volumes/frontend (#6442)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.1.23...3.3.2)
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/tensorboards/frontend (#6443)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.1.23...3.3.2)
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump tensorflow from 2.5.0 to 2.5.3 in /components/example-notebook-servers/jupyter-tensorflow (#6445)
Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.5.0 to 2.5.3.
- [Release notes](https://github.com/tensorflow/tensorflow/releases)
- [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md)
- [Commits](https://github.com/tensorflow/tensorflow/compare/v2.5.0...v2.5.3)
---
updated-dependencies:
- dependency-name: tensorflow
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/jupyter/frontend (#6381)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6438)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump follow-redirects from 1.9.0 to 1.14.9 in /components/centraldashboard (#6440)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.9.0 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.9.0...v1.14.9)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump async from 2.6.3 to 2.6.4 in /components/crud-web-apps/tensorboards/frontend (#6446)
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump async from 2.6.3 to 2.6.4 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6447)
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump async from 2.6.3 to 2.6.4 in /components/crud-web-apps/jupyter/frontend (#6448)
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump shelljs from 0.8.4 to 0.8.5 in /components/crud-web-apps/tensorboards/frontend (#6286)
Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5.
- [Release notes](https://github.com/shelljs/shelljs/releases)
- [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5)
---
updated-dependencies:
- dependency-name: shelljs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump shelljs from 0.8.4 to 0.8.5 in /components/crud-web-apps/volumes/frontend (#6287)
Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5.
- [Release notes](https://github.com/shelljs/shelljs/releases)
- [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5)
---
updated-dependencies:
- dependency-name: shelljs
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump node-fetch from 2.6.0 to 2.6.7 in /components/centraldashboard (#6307)
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.0 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md)
- [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.0...v2.6.7)
---
updated-dependencies:
- dependency-name: node-fetch
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/jupyter/frontend (#6444)
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.1.23...3.3.2)
---
updated-dependencies:
- dependency-name: nanoid
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump async from 2.6.3 to 2.6.4 in /components/crud-web-apps/volumes/frontend (#6449)
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix kubernetes python client to v22.6.0 (#6422)
Co-authored-by: Benjamin Tan <benjamin.tan@tech.jago.com>
* Support K8s 1.22 in notebook controller (#6374)
Fix https://github.com/kubeflow/kubeflow/issues/6366
Migrating to Kubebuilder v3 leads to the following changes:
- Add .dockerignore file.
- Upgrade Go version from v1.15 to v1.17.
- Adapt Makefile.
- Add image (build + push) target to makefile.
- Upgrade EnvTest to use K8s v1.22.
- Update PROJECT template.
- Migrate CRD apiVersion from v1beta to v1.
- Add livenessProbe and readinessProbe to controller manager.
- Upgrade controller-runtime from v0.2.0 to v0.11.0.
Other changes:
- Build image using public.ecr.aws registry instead of gcr.io.
- Update README.md documentation.
- Update 3rd party licences.
- Fix notebook.spec description.
- Add 3 sample notebooks (v1, v1alpha1 and v1beta1).
Signed-off-by: Samuel Veloso <svelosol@redhat.com>
* Fix vendortooltip typo (#6426)
* Cherry-pick latest commits to the 1.5-branch (#6354)
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295)
* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270)
Provide a design doc as a proposal for extending Notebook Controller to
expose idleness for Jupyter. Our proposal is in markdown format and follows
the guidelines of the kubeflow/components/proposal/README.md guide.
You can view the #6270 issue in the following link:
https://github.com/kubeflow/kubeflow/issues/6270
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* review: change the title of the proposal
Change the title of the proposal to only include the
proposed new feature. The new title of the proposal
will now be "Expose Idleness Information for Jupyter
Notebooks".
* review: rename the proposal markdown file
We want to give a more specific name to the markdown
which contains the proposal. Since this proposal
emphasizes on a feature regarding the Jupyter Notebooks,
the new name will be:
20220121-jupyter-notebook-idleness.md
* Synchronize jupyter-web-application role with clusterrole (#6241)
* Update role.yaml
* Update role.yaml
* Update cluster-role.yaml
* Kubeflow Roadmap update - with 1.5 details (#6266)
* Kubeflow Roadmap update - with 1.5 details
These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads.
* correct formatting in KFP features
Moved KFP features under KFP Control Flow doc
* updating KFP section
updating KFP references with updates from KFP team
* Updated the 1.5 release date to March
updated the 1.5 release date to March
* Update ROADMAP.md
change Hyperparameter leader election to Katib leader election
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update ROADMAP.md
improve description and details of feature for metrics collector
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* Update Katib description for Early stopping in 1.5
updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297)
* notebooks: Update image's tag in make
Modify Makefile to update properly the TAG
based on the git TAG.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Expose last-activity
Extend the notebook-controller to:
* cull idle Notebook Servers based on their new `last-activity`
annotation
* expose the last activity of each Notebook Server as an annotation
on the metadata of the corresponding CR object
Modify notebook_controller.go to:
* update the Last Activity of each Notebook Server that has a
Running pod
* delete the Last Activity Annotation for every Notebook Server
that does not have a Running pod
Extend culler.go to:
* perform culling based on the new `last-activity` annotation and
not based on the `/api/status` endpoint.
* update the last activity of a Notebook Server, based on the
kernels' execution states.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Athanasios Markou <athamark@arrikto.com>
* notebooks: Introduce a DEV env var
We introduce a DEV ENV var to allow admins
develop and test on their local machine their
custom Notebook Controller.
We provide information and instructions inside
the components/notebook-controller/README.md.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add unit tests for last-activity
* Introduce new tests for allKernelsAreIdle()
* Extend the tests for NotebookIsIdle() and for
NotebookNeedsCulling().
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* review: UpdateNotebookLastActivityAnnotation()
Ensure that UpdateNotebookLastActivityAnnotation() does not return
"true". This function should not return any value.
Signed-off-by: Athanasios Markou <athamark@arrikto.com>
* jwa: Rework the Storage API of the web app (#6321)
* wa(back): Add helper for deserializing JSON obj
In some cases we might need to construct Python k8s lib objects from the
JSONs that are provided by clients. I.e. the UI will be sending a PVC
object in json format, so the backend will need to create the
corresponding client.V1PersistentVolumeClaim object and submit it.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Serialization helper
Add helper function for converting a k8s-client object into a dict that
can be sent as an HTTP response.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Add dry run to Notebooks and PVCs
The backend will need to be able to create objects with dry-run, in
order to ensure they are valid. The backend will need to check that both
the Notebook and the PVCs can be created beforehand.
This way we avoid the scenario where we create PVCs but the Notebook
fails to be created, and the PVCs are never garbage collected.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Update kubernetes to 0.17
In order to support dry-run we must use the 0.17 version of the Python
k8s client.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* wa(back): Extend api module to patch pvcs
The backend will need to be able to PATCH PVCs in order to set the
ownerReference to the Notebook that mounts the PVCs.
Ref: arrikto/dev/issues/386#issuecomment-856700392
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Work with new Volumes API
The backend API should not add any more layers of abstractions on top of
the K8s API. The backend should expect the client/UI to be sending the
entire PVC spec of a new PVC.
Refs: arrikto/dev/issues/386
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Add unittests for new volumes API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(back): Extend the PVC info returned
We want to show both the access mode and size of the existing PVCs, when
a user clicks on the dropdown to select which PVC to mount.
The backend will need to provide this information to the frontend. We
don't want to send the K8s list of PVCs since this will result in a lot
of unnecessary data to be sent.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>
* jwa(front): Add proxy config for Rok
When developing the Rok flavor locally we will need to be able to open
the Rok chooser. This can be done by using Angular/webpack proxy to
bring the exposed rok service and the app under the same domain.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Remove card from form
The form of the app should not be a big card, but a normal form.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Install AceModule for yaml editing
Install AceModule to allow users to edit yamls of objects.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* wa(front): Change the styling of form sections
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Create common volume components
Component for:
* New PVC and configuring its spec
* Attaching an existing PVC in a Notebook
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Update Rok form for new Volume API
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa(front): Mark inputs as dirty when restoring Lab
When the UI autofills the form with values from a JupyterLab snapshot
then it should mark the touched fields as dirty. This way if a field has
errors the UI will make that input red.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>
* jwa: Update ConfigMap in manifests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* jwa(front): Fix format errors
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* profiles: Update the permissions for notebook idleness (#6335)
Extend the Profiles Controller to give permissions to Notebooks
controller for making GET requests to notebook's /api/kernels endpoint.
Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Graceful handling of events (#6338)
* notebooks: Handle events gracefully
The controller is not exiting the reconciliation loop after it has
re-emitted a Pod/STS Event as a Notebook Event. This results in the
controller to later on try and GET a Notebook with the name of the Event
that triggered the reconciliation loop.
The controller should exit the reconciliation function once it has
emitted the event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on deleted events
We don't want to trigger the reconciliation function when an event gets
deleted.
If a Notebook would be deleted then the underlying events would
be deleted as well, which results in the reconcile function to get
triggered and try to GET Events and Notebooks with the name of the
deleted event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Fix endless restarts (#6341)
* notebooks: Update notebook if timestamp changed
We don't want to be updating the spec of the notebook if the timestamp
hasn't changed, since this will lead to constant updates and
reconciliation loops.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Use a deep-copy of the notebook spec
The controller should use a deep-copy of the notebook spec when
calculating the spec for the StatefulSet. If not then we could
update the notebook object without wanting it, since the spec could have
been changed when calculating the STS spec.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Add prefix env var only if missing
The controller should be setting OR updating the NB_PREFIX env var.
Previously it would always blindly append it to the spec, which could
result in double entries for the same env var.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Update tags for v1.5.0-rc.1 (#6343)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
* fix error comparison between pointer and pointer in "CopyStatefulSetFields" (#6195)
error comparison between pointer and pointer in "CopyStatefulSetFields"
* [bugfix]: update unsupported links to latest pages (#6192)
* centraldashboard: Add KServe overlay (#6383)
Configure the dashboard to use the KServe app instead of the KFServing
0.6.1 one.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* notebooks: Don't reconcile on Events deletion (#6391)
The controller should not trigger the reconcile loop when an Event is
deleted. Previously the controller would run the reconciliation loop on
any event deletion.
This commit updates it to not run the loop for ANY event.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* releasing: Create v1.5.0-rc.2 images (#6394)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* fixed typo
* fixed typo
* changed remove rc2
Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Co-authored-by: mofanke <54242816+mofanke@users.noreply.github.com>
Co-authored-by: Jaeyeon Kim <anencore94@gmail.com>
* notebooks: notebook controller config RESTClient QPS and Burst in com… (#6453)
* AIP-5879 Admission Webhook 1.22 Compatibility (#6459)
* init
* update dependancies
* refine
* update webhook
* update readme and makefile
* KF conformance test driver (#6478)
* (Draft) KF conformance test framework
* Add env var to support debug output.
* Adressed code review comments.
* Moved tests from 1.0 to 1.5 folder.
* 1st update of Kubeflow Roadmap for Kubeflow 1.6 (#6456)
* 1st update of Kubeflow Roadmap for Kubeflow 1.6
@annajung @kimwnasptd @DomFleischmann I have created this PR as a quick way to update the Kubeflow Roadmap to include KF 1.6. My view is that we can update this in a simple way and then add more details if needed. Please review, improve as you see needed. Thanks. Jsoh
* accept anna's updates to ROADMAP.md
Co-authored-by: Anna <antheaj@vmware.com>
* Added Themes section
added Themes section and moved K8s 1.22 support to themes, removed x.y.z version details from each working group roadmap
* fixed formatting, removed version on Notebook
fixed formatting, removed version placeholder on Notebook, removed 1.22 support statement at end of 1.6 sections (as we have added it to the Themes section)
* Added link to KFP CLI design doc
Added link to KFP CLI design doc
Co-authored-by: Anna <antheaj@vmware.com>
* Add GH actions to push images to a DockerHub registry after a merge (#6510)
* Add a github action to build & push JWA docker image after a merge. (#6502)
* Add a github action to build & push TWA docker images after a merge. (#6502)
* Add a github action to build & push VWA docker images after a merge. (#6502)
* Add a github action to build & push Tensorboard Controller docker image after a merge. (#6502)
* Add a github action to build & push Profile Controller docker image after a merge. (#6502)
* Add a github action to build & push PodDefaults docker image after a merge. (#6502)
* Add a github action to build & push Notebook Server docker images after a merge. (#6502)
* Add a github action to build & push Notebook Controller docker image after a merge. (#6502)
* Add a github action to build & push KFAM docker image after a merge. (#6502)
* Add a github action to build & push Central Dashboard docker image after a merge. (#6502)
* Update CentralDashboard GH action after review comments.
* Add a path for the common code in JWA Gh action after review comment.
* Update KFAM GH action after review comments.
* Update JWA GH action after review comments.
* Update Notebook Controller GH action after review comments.
* Update Notebook Server GH action after review comments.
* Update PodDefaults GH action after review comments.
* Update Profile Controller GH action after review comments.
* Update Tensorboard Controller GH action after review comments.
* Update TWA GH action after review comments.
* Update VWA GH action after review comments.
* Update credentials in all GH actions.
* Pin alpine repository version (#6494)
With the `latest-stable` version of alpine package repository, an attempt to build central dashboard image fails with:
```
=> ERROR [build 3/7] RUN apk add --no-cache bash@stable chromium@stable nss@stable freetype@stable harfbuzz@stable ttf-freefont@stable libstdc++@stable 4.4s
------
> [build 3/7] RUN apk add --no-cache bash@stable chromium@stable nss@stable freetype@stable harfbuzz@stable ttf-freefont@stable libstdc++@stable:
#7 0.940 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
#7 1.239 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
#7 1.803 fetch http://nl.alpinelinux.org/alpine/latest-stable/community/x86_64/APKINDEX.tar.gz
#7 2.701 fetch http://nl.alpinelinux.org/alpine/latest-stable/main/x86_64/APKINDEX.tar.gz
#7 3.630 ERROR: unable to select packages:
#7 4.065 so:libmbedcrypto.so.7 (no such package):
#7 4.065 required by: librist-0.2.6-r1[so:libmbedcrypto.so.7]
------
executor failed running [/bin/sh -c apk add --no-cache bash@stable chromium@stable nss@stable freetype@stable harfbuzz@stable ttf-freefont@stable libstdc++@stable]: exit code: 4
make: *** [Makefile:42: build] Error 1
```
* feat(Jupyter): Show group one or two only if images exists (#6482)
* Upgrade API version of `Tensorboard` CRD to `v1` (#6406)
* Migrate tensorboard-controller to Kubebuilder v3
* Fix paths inside Docker context
* Remove test dependency from docker-build
* Switch to kustomize 3.2.0, fix image tag
* Fix namePrefix
* Rename deployments, remove namespaces
* Add runAsUser
* Make tensorboard image and istio gateway configurable
* Add GH actions for building manifests at any pull request (#6524)
* Add GH actions for building manifests at any pull request.
* Change names of GH actions and specify the manifests path.
* Fix manifests path in Profile Controller GH action.
* update jupyterlab to 3.4.3 (#6527)
* notebooks: Allow notebook controller to patch events (#6523)
* Fix typos in GH actions that build and push Docker images (#6541)
* Make GH actions build images on PR and push only on merge (#6543)
* Make GH actions build images on PR and push only on merge.
* Fix typo from rebase.
* Add GH actions for applying manifests at any pull request (#6530)
* Add GH actions for applying manifests at any PR.
* Add scripts for all the KinD GH actions.
* Give permission to run the scripts.
* Modify GH actions to use scripts for installations.
* Address review comments.
* Change GH actions based on review comments.
* Add newlines at the end of the script files.
* jwa: Expose a last-activity column (#6544)
We want to extend JWA to have a column for showing the `Last activity`
of a Notebook CR.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Reword image name in TWA Gh action (#6547)
* Fix VWA path in Gh action for building image (#6549)
* Add GH action for publishing all images when VERSION is updated (#6537)
* Add GH action for publishing all images when version is updated.
* Fix typos in GH action for building all images.
* Fix typo in tensorboards image.
* Update install command for code server extension (#6554)
Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
* Introduce a mechanism to build all Kubeflow images (#6555)
* build: Update components makefiles for building
We'll create a top-level Makefile under components/ dir
that has the following rules:
* build-all:
To build all images locally
* push-all:
* We can use a specific REGISTRY and retag the images
* Push all the images
This top-level Makefile will run the sub-Makefiles that every
component has for building and pushing the images.
We modified every sub-Makefile as follows:
* We don't use a registry in images by default
* Removed unused rules and vars
* Use the --dirty flag of git describe in TAG
--dirty[=<mark>]
Describe the working tree. It means describe HEAD and
appends <mark> (-dirty by default) if the working tree
is dirty.
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Create makefiles for notebook servers
The common starting point of building the notebook-server
images are the following 4 *base* images:
- base
- codeserver
- jupyter
- rstudio
All other server images need to build on top of them. We'll
dynamically pass the base images in every Dockerfile by
using an ARG IMG. We can set the value of this ARG during
docker build with the --build-arg CLI argument.
This way we build both the base images with a tag locally,
and then we pass that image as arg via the Makefile and build the rest
So we modified our building procedure as follows:
1. Build the base image since everything starts from there
2. Pass the base image as an ARG in the Dockerfiles of
jupyter, codeserver, rstudio images and build on top
3. Pass the base images in all other server images and build
on top
For that we will:
1. Create a Makefile for each of the notebook servers, in each folder
a. Each makefile will be responsible for building the bases and use args for passing them on
2. Use the central Makefile to call each Makefile from above
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* cherry-pick: Notebook server upstream fixes
Relevant upstream PR: https://github.com/kubeflow/kubeflow/pull/6466/files
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Fix Makefiles
- Remove build-gcp and build-gcr rules as we don't use them anywhere in
the project
- Fix code conficts
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Fix Dockerfiles for notbook-server images
We remove the previous logic of using already built images as bases.
The users must use only the Makefiles to pass the appropriate BASE_IMG
and build the images correctly.
Thus, we have Makefiles everywhere that:
- Can build any base image
- If an image requires another notebook base, then we first build that one using its makefile,
and then use it as docker ARG for building the next one
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Fix notebook-controller Makefile
Removed a misplaced "|" char that breaks the Makefile
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Update GH action workflows
* Update workflow for notebook-server images:
- Add a step for building all images by using the
central-Makefile under components/example-notebook-servers/ dir.
- Add a step for pushing all images by using the
central-Makefile under components/example-notebook-servers/ dir.
* Update workflow for all Kubeflow images:
- Add a step for building & pushing all images by using the
top-level Makefile under components/ dir.
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Remove completely ECR references from images
Replace everywhere the "public.ecr.aws/j1r0q0g6/notebooks/notebook-servers"
prefix with "kubeflownotebookswg"
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* build: Fix GH actions for Kubeflow components
Fix GH actions to use the updated make rules
when building the Kubeflow component images.
Remove the "docker.io" prefix when building with
GH action workflows
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* proposals: Show objects from all namespaces (#6531)
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* Add support for `command` and `args` in `PodDefault` (#6542)
* Add support for setting custom "command" and "args" for Notebook servers (#20)
* Support command and args in PodDefault
* Improve logging, refactoring
* Add unit test for setCommandAndArgs, fix broken tests
* Cleanup
* Support K8s 1.22 in profile controller (#6491)
* profile-controller: Delete old kubebuilder v1 project
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: Initialize Kubebuilder v3 project
go module name:
github.com/kubeflow/kubeflow/components/profile-controller
project domain:
kubeflow.org
Changes:
* Go Version got upgraded from v1.15 to v1.17
* With Kubebuilder V3 our project dependencies got
updated to a more up-to-date version.
* controller-runtime library got updated from v0.2.0 to v0.12.1.
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: create placeholder API types and controller logic files
We created the Profile API types
v1: kubebuilder create api --version v1 kind Profile
v1beta1: kubebuilder create api --version v1beta1 Profile
We copied over the API definitions from the old project
to the new one
(Note: Currently KFAM uses the v1beta1 version of Profile
to provide fine-grain user-namespace level access control)
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: copy controllers logic from old project to the new one
* Copied the files under controller/ dir from the old to our new project
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: Code modifications to fix profile-controller
With Kubebuilder V3 the dependencies of our project got updated
to a more up-to-date version. Newer versions of certain packages
resulted to broken code parts that we had to fix. More specifically:
* In this project we are using a namespace-labels-data ConfigMap
to set certain labels on every Profile namespace. Every change in
this ConfigMap produces an event and for every event we construct
a list of reconcile.Requests that contains the name and namespace
of every Profile in our system.
Thus we introduced a mapEventToRequest MapFunc (profile_controller.go)
that maps an event to reconcile requests for all Profiles. This change
was necessary because controller-runtime library got updated from v0.6.3
to v0.12.1
* Kubebuilder V3 introduced for the profile-controller:
1) a livenessprobe (/healthz) on port :8081
2) a readinessProbe (/readyz) on port :8081
We have a conflict here as KFAM Service uses the :8081 port as well.
Therefore, we switched the port to :9876 for the above Probes.
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: Fix manifests, Makefile, Dockerfile
Makefile:
* Add image (build + push) target
* Add test-overlays target
* Build image using public.ecr.aws registry instead of gcr.io.
Dockerfile:
* fix Dockerfile to build our controller correclty
Manifests
* Add base/ and overlays/ manifests
* Fix the manifests to be in sync with upstream
other changes:
Update README.md file
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: Add test files
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* profile-controller: Fix Makefile
* Set the correct IMG:TAG
* Remove test dependency
Signed-off-by: Apotolos Gerakaris <apoger@arrikto.com>
* Fix typo in notebook_controller.go (#6577)
* Use controller-gen for PodDefaults (#6578)
* poddefaults: Use controller-gen for generation
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Generate deepcopy files
Use the `make generate` make rule to automatically generate the deepcopy
files.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Generate CRD
Use the controller-gen to generate the CRD, instead of manually updating
it.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* crud-web-apps: Migrate from tslint to eslint (#6464)
* build: Migrate tslint to eslint
* crud webapps - migrate tslint to eslint
* fix npm versions
* fix npm deps
* Reload certificates in admission-webhook (#6581)
Reload server certificates if they are changed on disk. Use certwatcher
from controller-runtime that already implements this functionality.
Closes #5560.
Signed-off-by: Manolis Androulidakis <manolis@arrikto.com>
* Create separate workflows for each notebook server (#6571)
* Add separate GH actions for all notebook servers.
* Keep only the workflows for the images that appear in JWA's ConfigMap.
* Ensure workflows trigger when the base image files change.
* crud-web-apps: Apply ng lint (#6580)
* Fix ng lint (#6586)
* fix lint errors
* fix lint
* Update package-lock.json
* Update package-lock.json
* Add workflow for frontend lint
* Fix legacy of Python version information in README files. (#6561)
* Update few packages and images to fix critical CVEs in centraldashboard component (#6559)
Signed-off-by: MessKon <messiskon@gmail.com>
* Bump Jupyter web app to Python 3.8. (#6562)
* Fix(Jupyter): Fix the ImageGroup object path (#6596)
* notebooks: Fix notebook endless restarts (#6337) (#6603)
* Cast nvidia.com/gpu value as string respective of K8s Resource Spec (#6051)
* Fix #6616: Typo on New Notebook page (#6620)
* JWA(front): Fix image group one and two not showing (#6625)
Fix image group one and two not showing in JWA's New notebook form, even
when the avaialable config provides value for them.
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
* fix Profile Plugins functionality (#6624)
* fix profile plugin loading
* add proper sample
* add GH action for unit tests
* rename GH job name
* Fix #6528: Mirroring Pod conditions to Notebook (#6619)
* Fix #6528: Mirroring Pod conditions to Notebook
* Added missing fields which are part of PodConditions into NotebookConditions
* Added suggested changes
* Fix #6056: Update Notebook status properly (#6628)
* Fix #6056: Update Notebook status properly
Signed-off-by: Apostolos Gerakaris apoger@arrikto.com
* Added suggested code changes
Signed-off-by: Apostolos Gerakaris apoger@arrikto.com
* notebook-controller: Add unit tests
*Introduce basic unit tests for "createNotebookStatus" function
*Add GH action for unit tests
Signed-off-by: Apostolos Gerakaris apoger@arrikto.com
* Fix PodCoditionsMirroringToNotebook & Unit-tests
We encountered an error during testing. It seems that
the pod.status.conditions.condition.LastProbeTime remains
always null and so the controller ends up applying a Notebook
CR instance with null condition values.
Relevant Issues:
*https://github.com/kubernetes/kubernetes/issues/109958
*https://github.com/kubernetes/kubernetes/issues/79402
*https://github.com/kubernetes/kubernetes/issues/14393
Fix: Check if the Pod's condition.LastProbeTime
and condition.LastTransitionTime timestamp fields are null.
If so, initialize them so we dont end up applying
a Notebook instance with null condition values.
Other changes:
*Fix basic unit tests
*Introduced a unit test for the case where Notebook's Pod
is unschedulable
Signed-off-by: Apostolos Gerakaris apoger@arrikto.com
Signed-off-by: Apostolos Gerakaris apoger@arrikto.com
* Fix invalid kustomization patch introduced for profile-controller manager (#6604)
* update stablebot configs (#6634)
* Extend PodDefaults for support for imagePullSecrets (#6600)
* poddefaults: add imagepullsecrets
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* poddefaults: Generate CRD/deepcopy files
Run make generate and make manifests to generate the correct CRD and
deepcopy files.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
* update Kubeflow roadmap to show delivery of v1.6 (#6637)
* update Kubeflow roadmap to show delivery of v1.6
* Update ROADMAP.md
Co-authored-by: Anna <antheaj@vmware.com>
* Update ROADMAP.md
Co-authored-by: Anna <antheaj@vmware.com>
Co-authored-by: Anna <antheaj@vmware.com>
* Fix notebook culling (#6659)
The notebook controller writes the last-activity annotation
before culling the Notebook, however, doesn't remove this
annotation before start. This causes the Notebook to be culled
again before is has a chance to start.
Fix:
* calculate correctly the podFound variable and ensure its value
its true only if the Pod is actually found. This way the culling
annotation will be removed when there is no Pod.
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* centraldashboard: Format code (#6671)
Format centraldashboard's code based on the eslint configuration.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* Docker -> OCI Update form-image.component.html (#6673)
Docker is dead and superseeded by OCI on all common Platforms
* chore(icons): the model icon is grey instead of black (#6656)
* build(deps): bump jose from 2.0.5 to 2.0.6 in /components/crud-web-apps/jupyter/frontend (#6654)
Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](https://github.com/panva/jose/compare/v2.0.5...v2.0.6)
---
updated-dependencies:
- dependency-name: jose
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump jszip from 3.6.0 to 3.10.1 in /components/crud-web-apps/volumes/frontend (#6640)
Bumps [jszip](https://github.com/Stuk/jszip) from 3.6.0 to 3.10.1.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md)
- [Commits](https://github.com/Stuk/jszip/compare/v3.6.0...v3.10.1)
---
updated-dependencies:
- dependency-name: jszip
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* kwa(front): Fixes needed for Katib unit tests (#6676)
* Fixes needed for Katib unit tests to run successfully.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* centraldashboard: Show objects from all namespaces (#6674)
* centraldashboard: Introduce onAllNamespacesSelected
Introduce the onAllNamespacesSelected method in centraldashboard's
library. It is going to notify other UIs that a user selects the
"All namespace" option in centraldashboard.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* centraldashboard: Add support for the "All namespace" option
Introduce the "All namespace" option in centraldashboard's namespace
selector. When a user selects this option the centraldashboard is
using its library in order to modify the UIs inside the iframe.
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* fixup! centraldashboard: Add support for the "All namespace" option
Signed-off-by: Tasos Alexiou <tasos@arrikto.com>
* Add quotes to notebook_template.yaml namespace field. (#6655)
* build(deps): bump jszip from 3.6.0 to 3.10.1 in /components/crud-web-apps/jupyter/frontend (#6641)
Bumps [jszip](https://github.com/Stuk/jszip) from 3.6.0 to 3.10.1.
- [Release notes](https://github.com/Stuk/jszip/releases)
- [Changelog](https://github.com/Stuk/jszip/blob/main/CHANGES.md)
- [Commits](https://github.com/Stuk/jszip/compare/v3.6.0...v3.10.1)
---
updated-dependencies:
- dependency-name: jszip
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump jose from 2.0.5 to 2.0.6 in /components/crud-web-apps/tensorboards/frontend (#6652)
Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](https://github.com/panva/jose/compare/v2.0.5...v2.0.6)
---
updated-dependencies:
- dependency-name: jose
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump jose from 2.0.5 to 2.0.6 in /components/crud-web-apps/volumes/frontend (#6653)
Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](https://github.com/panva/jose/compare/v2.0.5...v2.0.6)
---
updated-dependencies:
- dependency-name: jose
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(volume name): update formCtrl.get() (#6681)
The Angular code for `<app-form-data-volumes>` was missing `.value`.
* Remove unused python imports. (#6595)
* [vwa-datetime] Showing dates in main page uniformly in VWA (#6683)
* vwa(back): Modify age column to be a timestamp
* Modify the backend to send a timestamp as is without doing any formatting.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Use DateTimeValue class in age column
* Use DateTimeValue class in TableConfig for age column instead of PropertyValue one.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* Make admission-webhook port number configurable (#6692)
Previously the webhook listened on a fixed port, 4443, which can clash
with other services when the webhook is run on the host network in
Kubernetes, which is required when using some CNI implementations,
notably Calico on EKS [1].
Enable configuration of the webhook listen port via the program flags.
[1] https://projectcalico.docs.tigera.io/getting-started/kubernetes/managed-public-cloud/eks#install-eks-with-calico-networking
Signed-off-by: Steve Larkin <steve.larkin@gmail.com>
Signed-off-by: Steve Larkin <steve.larkin@gmail.com>
* build(deps): bump socket.io-parser and karma in /components/centraldashboard (#6691)
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) to 4.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be updated together.
Updates `socket.io-parser` from 3.2.0 to 4.2.1
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-parser/compare/3.2.0...4.2.1)
Updates `karma` from 4.3.0 to 6.4.1
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v4.3.0...v6.4.1)
---
updated-dependencies:
- dependency-name: socket.io-parser
dependency-type: indirect
- dependency-name: karma
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [wa-age-column-improvements] Improvements in the web app's age column (#6694)
* web-apps(front): Rename Age header in WAs
* Rename Age header to Created at.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Right-align date columns in WAs
* Make date columns to be right-aligned.
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
* [wa-upgrade-k8s-client] Upgrade @kubernetes/client-node in wa frontends (#6696)
* jwa(front): Upgrade @kubernetes/client-node module
* Upgrade @kubernetes/client-node module, so that to include
quantityToScalar function directly from kubernetes js module.
* Set allowSyntheticDefaultImports flag to true to allow 'import x
from y' when a module doesn't have a default export.
Signed-off-by: Elena Zioga <elena@arrik…
javyxu
pushed a commit
to javyxu/kubeflow
that referenced
this pull request
Sep 10, 2023
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (kubeflow#6261) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6295) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6270) Provide a design doc as a proposal for extending Notebook Controller to expose idleness for Jupyter. Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide. You can view the kubeflow#6270 issue in the following link: kubeflow#6270 Signed-off-by: Athanasios Markou <athamark@arrikto.com> * review: change the title of the proposal Change the title of the proposal to only include the proposed new feature. The new title of the proposal will now be "Expose Idleness Information for Jupyter Notebooks". * review: rename the proposal markdown file We want to give a more specific name to the markdown which contains the proposal. Since this proposal emphasizes on a feature regarding the Jupyter Notebooks, the new name will be: 20220121-jupyter-notebook-idleness.md * Synchronize jupyter-web-application role with clusterrole (kubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml * Kubeflow Roadmap update - with 1.5 details (kubeflow#6266) * Kubeflow Roadmap update - with 1.5 details These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads. * correct formatting in KFP features Moved KFP features under KFP Control Flow doc * updating KFP section updating KFP references with updates from KFP team * Updated the 1.5 release date to March updated the 1.5 release date to March * Update ROADMAP.md change Hyperparameter leader election to Katib leader election Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update ROADMAP.md improve description and details of feature for metrics collector Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Katib description for Early stopping in 1.5 updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * notebooks: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6297) * notebooks: Update image's tag in make Modify Makefile to update properly the TAG based on the git TAG. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Expose last-activity Extend the notebook-controller to: * cull idle Notebook Servers based on their new `last-activity` annotation * expose the last activity of each Notebook Server as an annotation on the metadata of the corresponding CR object Modify notebook_controller.go to: * update the Last Activity of each Notebook Server that has a Running pod * delete the Last Activity Annotation for every Notebook Server that does not have a Running pod Extend culler.go to: * perform culling based on the new `last-activity` annotation and not based on the `/api/status` endpoint. * update the last activity of a Notebook Server, based on the kernels' execution states. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Athanasios Markou <athamark@arrikto.com> * notebooks: Introduce a DEV env var We introduce a DEV ENV var to allow admins develop and test on their local machine their custom Notebook Controller. We provide information and instructions inside the components/notebook-controller/README.md. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add unit tests for last-activity * Introduce new tests for allKernelsAreIdle() * Extend the tests for NotebookIsIdle() and for NotebookNeedsCulling(). Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: UpdateNotebookLastActivityAnnotation() Ensure that UpdateNotebookLastActivityAnnotation() does not return "true". This function should not return any value. Signed-off-by: Athanasios Markou <athamark@arrikto.com> * jwa: Rework the Storage API of the web app (kubeflow#6321) * wa(back): Add helper for deserializing JSON obj In some cases we might need to construct Python k8s lib objects from the JSONs that are provided by clients. I.e. the UI will be sending a PVC object in json format, so the backend will need to create the corresponding client.V1PersistentVolumeClaim object and submit it. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Serialization helper Add helper function for converting a k8s-client object into a dict that can be sent as an HTTP response. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Add dry run to Notebooks and PVCs The backend will need to be able to create objects with dry-run, in order to ensure they are valid. The backend will need to check that both the Notebook and the PVCs can be created beforehand. This way we avoid the scenario where we create PVCs but the Notebook fails to be created, and the PVCs are never garbage collected. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Update kubernetes to 0.17 In order to support dry-run we must use the 0.17 version of the Python k8s client. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Extend api module to patch pvcs The backend will need to be able to PATCH PVCs in order to set the ownerReference to the Notebook that mounts the PVCs. Ref: arrikto/dev/issues/386#issuecomment-856700392 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Work with new Volumes API The backend API should not add any more layers of abstractions on top of the K8s API. The backend should expect the client/UI to be sending the entire PVC spec of a new PVC. Refs: arrikto/dev/issues/386 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Add unittests for new volumes API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Extend the PVC info returned We want to show both the access mode and size of the existing PVCs, when a user clicks on the dropdown to select which PVC to mount. The backend will need to provide this information to the frontend. We don't want to send the K8s list of PVCs since this will result in a lot of unnecessary data to be sent. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(front): Add proxy config for Rok When developing the Rok flavor locally we will need to be able to open the Rok chooser. This can be done by using Angular/webpack proxy to bring the exposed rok service and the app under the same domain. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Remove card from form The form of the app should not be a big card, but a normal form. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Install AceModule for yaml editing Install AceModule to allow users to edit yamls of objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * wa(front): Change the styling of form sections Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Create common volume components Component for: * New PVC and configuring its spec * Attaching an existing PVC in a Notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Update Rok form for new Volume API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Mark inputs as dirty when restoring Lab When the UI autofills the form with values from a JupyterLab snapshot then it should mark the touched fields as dirty. This way if a field has errors the UI will make that input red. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa: Update ConfigMap in manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(front): Fix format errors Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * profiles: Update the permissions for notebook idleness (kubeflow#6335) Extend the Profiles Controller to give permissions to Notebooks controller for making GET requests to notebook's /api/kernels endpoint. Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Graceful handling of events (kubeflow#6338) * notebooks: Handle events gracefully The controller is not exiting the reconciliation loop after it has re-emitted a Pod/STS Event as a Notebook Event. This results in the controller to later on try and GET a Notebook with the name of the Event that triggered the reconciliation loop. The controller should exit the reconciliation function once it has emitted the event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on deleted events We don't want to trigger the reconciliation function when an event gets deleted. If a Notebook would be deleted then the underlying events would be deleted as well, which results in the reconcile function to get triggered and try to GET Events and Notebooks with the name of the deleted event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Fix endless restarts (kubeflow#6341) * notebooks: Update notebook if timestamp changed We don't want to be updating the spec of the notebook if the timestamp hasn't changed, since this will lead to constant updates and reconciliation loops. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Use a deep-copy of the notebook spec The controller should use a deep-copy of the notebook spec when calculating the spec for the StatefulSet. If not then we could update the notebook object without wanting it, since the spec could have been changed when calculating the STS spec. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add prefix env var only if missing The controller should be setting OR updating the NB_PREFIX env var. Previously it would always blindly append it to the spec, which could result in double entries for the same env var. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update tags for v1.5.0-rc.1 (kubeflow#6343) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
javyxu
pushed a commit
to javyxu/kubeflow
that referenced
this pull request
Oct 1, 2023
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (kubeflow#6261) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6295) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6270) Provide a design doc as a proposal for extending Notebook Controller to expose idleness for Jupyter. Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide. You can view the kubeflow#6270 issue in the following link: kubeflow#6270 Signed-off-by: Athanasios Markou <athamark@arrikto.com> * review: change the title of the proposal Change the title of the proposal to only include the proposed new feature. The new title of the proposal will now be "Expose Idleness Information for Jupyter Notebooks". * review: rename the proposal markdown file We want to give a more specific name to the markdown which contains the proposal. Since this proposal emphasizes on a feature regarding the Jupyter Notebooks, the new name will be: 20220121-jupyter-notebook-idleness.md * Synchronize jupyter-web-application role with clusterrole (kubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml * Kubeflow Roadmap update - with 1.5 details (kubeflow#6266) * Kubeflow Roadmap update - with 1.5 details These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads. * correct formatting in KFP features Moved KFP features under KFP Control Flow doc * updating KFP section updating KFP references with updates from KFP team * Updated the 1.5 release date to March updated the 1.5 release date to March * Update ROADMAP.md change Hyperparameter leader election to Katib leader election Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update ROADMAP.md improve description and details of feature for metrics collector Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Katib description for Early stopping in 1.5 updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * notebooks: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6297) * notebooks: Update image's tag in make Modify Makefile to update properly the TAG based on the git TAG. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Expose last-activity Extend the notebook-controller to: * cull idle Notebook Servers based on their new `last-activity` annotation * expose the last activity of each Notebook Server as an annotation on the metadata of the corresponding CR object Modify notebook_controller.go to: * update the Last Activity of each Notebook Server that has a Running pod * delete the Last Activity Annotation for every Notebook Server that does not have a Running pod Extend culler.go to: * perform culling based on the new `last-activity` annotation and not based on the `/api/status` endpoint. * update the last activity of a Notebook Server, based on the kernels' execution states. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Athanasios Markou <athamark@arrikto.com> * notebooks: Introduce a DEV env var We introduce a DEV ENV var to allow admins develop and test on their local machine their custom Notebook Controller. We provide information and instructions inside the components/notebook-controller/README.md. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add unit tests for last-activity * Introduce new tests for allKernelsAreIdle() * Extend the tests for NotebookIsIdle() and for NotebookNeedsCulling(). Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: UpdateNotebookLastActivityAnnotation() Ensure that UpdateNotebookLastActivityAnnotation() does not return "true". This function should not return any value. Signed-off-by: Athanasios Markou <athamark@arrikto.com> * jwa: Rework the Storage API of the web app (kubeflow#6321) * wa(back): Add helper for deserializing JSON obj In some cases we might need to construct Python k8s lib objects from the JSONs that are provided by clients. I.e. the UI will be sending a PVC object in json format, so the backend will need to create the corresponding client.V1PersistentVolumeClaim object and submit it. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Serialization helper Add helper function for converting a k8s-client object into a dict that can be sent as an HTTP response. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Add dry run to Notebooks and PVCs The backend will need to be able to create objects with dry-run, in order to ensure they are valid. The backend will need to check that both the Notebook and the PVCs can be created beforehand. This way we avoid the scenario where we create PVCs but the Notebook fails to be created, and the PVCs are never garbage collected. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Update kubernetes to 0.17 In order to support dry-run we must use the 0.17 version of the Python k8s client. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Extend api module to patch pvcs The backend will need to be able to PATCH PVCs in order to set the ownerReference to the Notebook that mounts the PVCs. Ref: arrikto/dev/issues/386#issuecomment-856700392 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Work with new Volumes API The backend API should not add any more layers of abstractions on top of the K8s API. The backend should expect the client/UI to be sending the entire PVC spec of a new PVC. Refs: arrikto/dev/issues/386 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Add unittests for new volumes API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Extend the PVC info returned We want to show both the access mode and size of the existing PVCs, when a user clicks on the dropdown to select which PVC to mount. The backend will need to provide this information to the frontend. We don't want to send the K8s list of PVCs since this will result in a lot of unnecessary data to be sent. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(front): Add proxy config for Rok When developing the Rok flavor locally we will need to be able to open the Rok chooser. This can be done by using Angular/webpack proxy to bring the exposed rok service and the app under the same domain. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Remove card from form The form of the app should not be a big card, but a normal form. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Install AceModule for yaml editing Install AceModule to allow users to edit yamls of objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * wa(front): Change the styling of form sections Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Create common volume components Component for: * New PVC and configuring its spec * Attaching an existing PVC in a Notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Update Rok form for new Volume API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Mark inputs as dirty when restoring Lab When the UI autofills the form with values from a JupyterLab snapshot then it should mark the touched fields as dirty. This way if a field has errors the UI will make that input red. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa: Update ConfigMap in manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(front): Fix format errors Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * profiles: Update the permissions for notebook idleness (kubeflow#6335) Extend the Profiles Controller to give permissions to Notebooks controller for making GET requests to notebook's /api/kernels endpoint. Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Graceful handling of events (kubeflow#6338) * notebooks: Handle events gracefully The controller is not exiting the reconciliation loop after it has re-emitted a Pod/STS Event as a Notebook Event. This results in the controller to later on try and GET a Notebook with the name of the Event that triggered the reconciliation loop. The controller should exit the reconciliation function once it has emitted the event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on deleted events We don't want to trigger the reconciliation function when an event gets deleted. If a Notebook would be deleted then the underlying events would be deleted as well, which results in the reconcile function to get triggered and try to GET Events and Notebooks with the name of the deleted event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Fix endless restarts (kubeflow#6341) * notebooks: Update notebook if timestamp changed We don't want to be updating the spec of the notebook if the timestamp hasn't changed, since this will lead to constant updates and reconciliation loops. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Use a deep-copy of the notebook spec The controller should use a deep-copy of the notebook spec when calculating the spec for the StatefulSet. If not then we could update the notebook object without wanting it, since the spec could have been changed when calculating the STS spec. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add prefix env var only if missing The controller should be setting OR updating the NB_PREFIX env var. Previously it would always blindly append it to the spec, which could result in double entries for the same env var. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update tags for v1.5.0-rc.1 (kubeflow#6343) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
YuriJin-Unity
pushed a commit
to Unity-Technologies/kubeflow
that referenced
this pull request
Mar 25, 2024
* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (kubeflow#6261) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6295) * proposal: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6270) Provide a design doc as a proposal for extending Notebook Controller to expose idleness for Jupyter. Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide. You can view the kubeflow#6270 issue in the following link: kubeflow#6270 Signed-off-by: Athanasios Markou <athamark@arrikto.com> * review: change the title of the proposal Change the title of the proposal to only include the proposed new feature. The new title of the proposal will now be "Expose Idleness Information for Jupyter Notebooks". * review: rename the proposal markdown file We want to give a more specific name to the markdown which contains the proposal. Since this proposal emphasizes on a feature regarding the Jupyter Notebooks, the new name will be: 20220121-jupyter-notebook-idleness.md * Synchronize jupyter-web-application role with clusterrole (kubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml * Kubeflow Roadmap update - with 1.5 details (kubeflow#6266) * Kubeflow Roadmap update - with 1.5 details These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group. This is an initial proposal that needs review by the working group leads. * correct formatting in KFP features Moved KFP features under KFP Control Flow doc * updating KFP section updating KFP references with updates from KFP team * Updated the 1.5 release date to March updated the 1.5 release date to March * Update ROADMAP.md change Hyperparameter leader election to Katib leader election Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update ROADMAP.md improve description and details of feature for metrics collector Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Katib description for Early stopping in 1.5 updating with Andrey's suggestion (but without the world proper). * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * notebooks: Extend Notebook Controller to expose idleness for Jupyter (kubeflow#6297) * notebooks: Update image's tag in make Modify Makefile to update properly the TAG based on the git TAG. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Expose last-activity Extend the notebook-controller to: * cull idle Notebook Servers based on their new `last-activity` annotation * expose the last activity of each Notebook Server as an annotation on the metadata of the corresponding CR object Modify notebook_controller.go to: * update the Last Activity of each Notebook Server that has a Running pod * delete the Last Activity Annotation for every Notebook Server that does not have a Running pod Extend culler.go to: * perform culling based on the new `last-activity` annotation and not based on the `/api/status` endpoint. * update the last activity of a Notebook Server, based on the kernels' execution states. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Athanasios Markou <athamark@arrikto.com> * notebooks: Introduce a DEV env var We introduce a DEV ENV var to allow admins develop and test on their local machine their custom Notebook Controller. We provide information and instructions inside the components/notebook-controller/README.md. Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add unit tests for last-activity * Introduce new tests for allKernelsAreIdle() * Extend the tests for NotebookIsIdle() and for NotebookNeedsCulling(). Signed-off-by: Athanasios Markou <athamark@arrikto.com> Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * review: UpdateNotebookLastActivityAnnotation() Ensure that UpdateNotebookLastActivityAnnotation() does not return "true". This function should not return any value. Signed-off-by: Athanasios Markou <athamark@arrikto.com> * jwa: Rework the Storage API of the web app (kubeflow#6321) * wa(back): Add helper for deserializing JSON obj In some cases we might need to construct Python k8s lib objects from the JSONs that are provided by clients. I.e. the UI will be sending a PVC object in json format, so the backend will need to create the corresponding client.V1PersistentVolumeClaim object and submit it. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Serialization helper Add helper function for converting a k8s-client object into a dict that can be sent as an HTTP response. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Add dry run to Notebooks and PVCs The backend will need to be able to create objects with dry-run, in order to ensure they are valid. The backend will need to check that both the Notebook and the PVCs can be created beforehand. This way we avoid the scenario where we create PVCs but the Notebook fails to be created, and the PVCs are never garbage collected. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Update kubernetes to 0.17 In order to support dry-run we must use the 0.17 version of the Python k8s client. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * wa(back): Extend api module to patch pvcs The backend will need to be able to PATCH PVCs in order to set the ownerReference to the Notebook that mounts the PVCs. Ref: arrikto/dev/issues/386#issuecomment-856700392 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Work with new Volumes API The backend API should not add any more layers of abstractions on top of the K8s API. The backend should expect the client/UI to be sending the entire PVC spec of a new PVC. Refs: arrikto/dev/issues/386 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Add unittests for new volumes API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(back): Extend the PVC info returned We want to show both the access mode and size of the existing PVCs, when a user clicks on the dropdown to select which PVC to mount. The backend will need to provide this information to the frontend. We don't want to send the K8s list of PVCs since this will result in a lot of unnecessary data to be sent. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com> * jwa(front): Add proxy config for Rok When developing the Rok flavor locally we will need to be able to open the Rok chooser. This can be done by using Angular/webpack proxy to bring the exposed rok service and the app under the same domain. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Remove card from form The form of the app should not be a big card, but a normal form. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Install AceModule for yaml editing Install AceModule to allow users to edit yamls of objects. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * wa(front): Change the styling of form sections Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Create common volume components Component for: * New PVC and configuring its spec * Attaching an existing PVC in a Notebook Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Update Rok form for new Volume API Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa(front): Mark inputs as dirty when restoring Lab When the UI autofills the form with values from a JupyterLab snapshot then it should mark the touched fields as dirty. This way if a field has errors the UI will make that input red. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Reviewed-by: Tasos Alexiou <tasos@arrikto.com> * jwa: Update ConfigMap in manifests Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * jwa(front): Fix format errors Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * profiles: Update the permissions for notebook idleness (kubeflow#6335) Extend the Profiles Controller to give permissions to Notebooks controller for making GET requests to notebook's /api/kernels endpoint. Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Graceful handling of events (kubeflow#6338) * notebooks: Handle events gracefully The controller is not exiting the reconciliation loop after it has re-emitted a Pod/STS Event as a Notebook Event. This results in the controller to later on try and GET a Notebook with the name of the Event that triggered the reconciliation loop. The controller should exit the reconciliation function once it has emitted the event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Don't reconcile on deleted events We don't want to trigger the reconciliation function when an event gets deleted. If a Notebook would be deleted then the underlying events would be deleted as well, which results in the reconcile function to get triggered and try to GET Events and Notebooks with the name of the deleted event. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Fix endless restarts (kubeflow#6341) * notebooks: Update notebook if timestamp changed We don't want to be updating the spec of the notebook if the timestamp hasn't changed, since this will lead to constant updates and reconciliation loops. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Use a deep-copy of the notebook spec The controller should use a deep-copy of the notebook spec when calculating the spec for the StatefulSet. If not then we could update the notebook object without wanting it, since the spec could have been changed when calculating the STS spec. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Add prefix env var only if missing The controller should be setting OR updating the NB_PREFIX env var. Previously it would always blindly append it to the spec, which could result in double entries for the same env var. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update tags for v1.5.0-rc.1 (kubeflow#6343) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…ubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…ubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…ubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…ubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…ubeflow#6241) * Update role.yaml * Update role.yaml * Update cluster-role.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role should be in line with
kubeflow/components/crud-web-apps/jupyter/manifests/base/cluster-role.yaml
Line 24 in d43aee1
@thesuperzapper