Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete tf-cnn-benchmarks.jsonnet; there is now an example prototype. #967

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jun 11, 2018

  • We no longer need the tf-cnn-benchmarks.jsonnet prototype; we now
    have an examples package that has a simple TF job that uses
    TFCNN by default.
  • Update the instructions on running the TFCNN job.

/assign @ankushagarwal


This change is Reviewable

@ankushagarwal
Copy link
Contributor

/lgtm
/approve

@pdmack
Copy link
Member

pdmack commented Jun 11, 2018

/retest

* We no longer need the tf-cnn-benchmarks.jsonnet prototype; we now
  have an examples package that has a simple TF job that uses
  TFCNN by default.
* Update the instructions on running the TFCNN job.
@jlewi
Copy link
Contributor Author

jlewi commented Jun 11, 2018

@pdmack @ankushagarwal Could someone please re-LGTM? I had to sync to get latest changes.

@pdmack
Copy link
Member

pdmack commented Jun 11, 2018

/lgtm

@jlewi
Copy link
Contributor Author

jlewi commented Jun 11, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ankushagarwal,jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack
Copy link
Member

pdmack commented Jun 12, 2018

/test all

@k8s-ci-robot k8s-ci-robot merged commit f7a6833 into kubeflow:master Jun 12, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
…ubeflow#967)

* We no longer need the tf-cnn-benchmarks.jsonnet prototype; we now
  have an examples package that has a simple TF job that uses
  TFCNN by default.
* Update the instructions on running the TFCNN job.
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* OWNERS for pipeline folder

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants