logout tab is not working

[muratyarali]

Validation Checklist

• Is this a Kubeflow issue?
• Are you posting in the right repository ?
• Did you follow the Kubeflow installation guideline ?
• Is the issue report properly structured and detailed with version numbers?
• Is this for Kubeflow development ?
• Would you like to work on this issue?
• You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Version

1.9

Describe your issue

I recently installed Kubeflow v1.9.1-RC.2, and the logout tab on the Kubeflow UI is unresponsive. Clicking it does nothing, but reloading the page takes me to the login page.

Steps to reproduce the issue

1. Push the logout tab on the Kubeflow UI. You will see it is unresponsive.
   2.Reload the page and go to the login page

Put here any screenshots or videos (optional)

No response

[juliusvonkohout]

Did this happen in RC1 as well?

[tarekabouzeid]

Hi @juliusvonkohout ,
I confirm the same exact behavior as well in rc2, haven't tested that in rc1.

[juliusvonkohout]

@thesuperzapper do you know about this? I think we had and fixed this problem before.

Could it be that we need to merge kubeflow/kubeflow#7631 and that there was a hotfix in kubeflow/manifest as well?

There is also https://github.com/kubeflow/manifests/blob/master/common/oauth2-proxy/components/central-dashboard/patches/deployment.logout-url.yaml

@tarekabouzeid @muratyarali can you apply the patch and check whether it should be oauth2/logout or oauth2/sign_out?

[thesuperzapper]

@juliusvonkohout we actually just need to change the central dashboard so that it uses a GET request (with a basic <a> tag) rather than using some fancy JS to do a POS in the background.

[juliusvonkohout]

@thesuperzapper can you patch this then in kubeflow/kubeflow and sent me a tag for synchronization?

Nevertheless i still do not like oauth2/logout vs. oauth2/sign_out and will remove one of them.

[juliusvonkohout]

CC also @kromanow94 @MaxKavun

[kromanow94]

Hey, @MaxKavun and my expertise resolves mostly around backend. But, with some guidance, we can provide help. Let us know if this is something you're interested in.

[juliusvonkohout]

We should also extend the test here to cover this https://github.com/kubeflow/manifests/blob/master/.github/workflows/dex_test.yaml.

[juliusvonkohout]

An there is also kubeflow/kubeflow#7624 for reference

[juliusvonkohout]

And another one kubeflow/dashboard#57

[thesuperzapper]

As I was saying in #2895 (comment).

If anyone wants to raise a PR on the central dashboard in the kubeflow/kubeflow repo to change the logout button to a simple <a> tag (which uses a GET rather than a POST), then the redirect will work properly.

[juliusvonkohout]

closed by https://github.com/kubeflow/kubeflow/pull/7654/files
and i released https://github.com/kubeflow/manifests/releases/tag/v1.9.1-rc.3