-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Katib manifests for Kubeflow 1.1 #1239
Katib manifests for Kubeflow 1.1 #1239
Conversation
I changed image tag from 5df1bd2 to 917164a. 917164a should have most recent changes and contains SDK for Katib which we mentioned on the website. List of images: https://console.cloud.google.com/gcr/images/kubeflow-images-public/GLOBAL/katib/v1alpha3/katib-controller. |
This has all the latest fixes |
@andreyvelich @johnugeorge can one of you please /approve this? |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, krishnadurai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andreyvelich I got error when running manifests/tests/stacks/examples/alice/test_data/expected/~g_v1_configmap_katib-config.yaml Lines 6 to 38 in 6e0925a
manifests/tests/stacks/generic/test_data/expected/~g_v1_configmap_katib-config.yaml Lines 6 to 38 in 6e0925a
If this is the case, do you mind if I create a PR to fix them? |
Which issue is resolved by this Pull Request:
Part of: kubeflow/katib#1211.
Description of your changes:
This is the manifests changes for Katib in Kubeflow 1.1.
I updated images version to the latest commit and I made few changes according to the Katib release issue.
/assign @jlewi @johnugeorge @gaocegege
Checklist:
cd manifests/tests
make generate-changed-only
make test