Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Katib image tag to ce89cbf on master #1440

Merged

Conversation

andreyvelich
Copy link
Member

I changed Katib image tag from kubeflow/katib@c3b38d8 to kubeflow/katib@ce89cbf for master manifest branch.

This PR: kubeflow/katib#1223 fixes problems with deleting extra Trials.

/assign @johnugeorge @gaocegege
/cc @idahoakl @jlewi

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@k8s-ci-robot
Copy link
Contributor

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: idahoakl.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

I changed Katib image tag from kubeflow/katib@c3b38d8 to kubeflow/katib@ce89cbf for master manifest branch.

This PR: kubeflow/katib#1223 fixes problems with deleting extra Trials.

/assign @johnugeorge @gaocegege
/cc @idahoakl @jlewi

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla google-cla bot added the cla: yes label Jul 31, 2020
@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit c2f1132 into kubeflow:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants