Update Notebook OWNERS #1599
Merged
Update Notebook OWNERS #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@kimwnasptd can you please review? |
|
/lgtm |
|
/retest |
thesuperzapper
force-pushed
the
thesuperzapper_owner
branch
from
57dff80
to
c478532
Compare
|
@kimwnasptd I had to rebase to fix the tests, can you LGTM? |
thesuperzapper
force-pushed
the
thesuperzapper_owner
branch
from
c478532
to
27da4b0
Compare
thesuperzapper
changed the title
|
After realising that people need to be an OWNER in "tests" folder, I have updated the commit to add me and @kimwnasptd there as-well. |
|
@Jeffwan can you please LGTM this (for the tests folder) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, kimwnasptd, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be an approver so that I can resolve issues with @kimwnasptd (we are both leads of the Notebook WG)