Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dex kustomizations readability #2590

Conversation

kromanow94
Copy link
Contributor

The overlays for ldap and github were not taken into consideration because atm they don't work because the dex's base kustimization doesn't define dex-parameters CM anymore.

These changes shouldn't cause any differences in generated manifests.

Description of your changes:
Implementing changes discussed here: #2586 (comment)

Checklist:

  • test if there are no differences in generated manifest
    $ git reset --hard
    HEAD is now at 2d047ae6 Improve dex kustomizations readability
    
    $ kustomize build common/dex/overlays/istio/ > dex.overlay.istio.improve-dex-kustomization-readability.yaml
    $ kustomize build common/dex/base/ > dex.overlay.base.improve-dex-kustomization-readability.yaml
    
    $ git checkout master
    $ git log -1
    commit ed4caf3e26060f626571b421185326257777576c (HEAD -> master, origin/master)
    Author:     Aleksey Karpov <86011874+alekseyolg@users.noreply.github.com>
    AuthorDate: Tue Jan 2 19:49:15 2024 +0300
    Commit:     GitHub <noreply@github.com>
    CommitDate: Tue Jan 2 16:49:15 2024 +0000
    
        Fixes dex for kustomize 5 (#2586)
    
        * Fixes user-namespace for kustomize 5
    
        * Fixes dex for kustomize 5
    $ kustomize build common/dex/base/ > dex.overlay.base.master.yaml
    $ kustomize build common/dex/overlays/istio/ > dex.overlay.istio.master.yaml
    
    $ diff dex.overlay.base.improve-dex-kustomization-readability.yaml dex.overlay.base.master.yaml
    $ diff dex.overlay.istio.improve-dex-kustomization-readability.yaml dex.overlay.istio.master.yaml
    

The overlays for ldap and github were not taken into consideration because atm they don't work
because the dex's base kustimization doesn't define dex-parameters anymore.
@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, kromanow94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6c80eb2 into kubeflow:master Jan 3, 2024
4 checks passed
@kromanow94 kromanow94 deleted the improve-dex-kustomization-readability branch January 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants