Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kind 1.27 and fix the integration tests #2637

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Mar 4, 2024

Update to Kind 1.27 such that we have a supported upgrade path from 1.8.0 on Kubernetes 1.26 -> 1.8.1 on Kubernetes 1.26 -> 1.8.1 on Kubernetes 1.27 -> 1.9 on Kubernetes 1.27 -> Kubernetes 1.29

@juliusvonkohout juliusvonkohout self-assigned this Mar 4, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

@andreyvelich in kubeflow/katib#2256 (comment) says that they already support 1.27. Maybe our tests are outdated

See also #2602

@juliusvonkohout
Copy link
Member Author

- name: Create katib experiment
run: |
kubectl create namespace kubeflow-user
kubectl label namespace kubeflow-user katib.kubeflow.org/metrics-collector-injection=enabled
kubectl apply -f tests/gh-actions/kf-objects/katib_test.yaml
echo "Waiting for Experiment to become Running..."
kubectl wait --for=condition=Running experiments.kubeflow.org -n kubeflow-user --all --timeout 300s
echo "Waiting for all Trials to become Succeeded..."
kubectl wait --for=condition=Succeeded trials.kubeflow.org -n kubeflow-user --all --timeout 300s
echo "Waiting for the Experiment to become Succeeded..."
kubectl wait --for=condition=Succeeded experiments.kubeflow.org -n kubeflow-user --all --timeout 300s

and or

https://github.com/kubeflow/manifests/blob/39bac597c9a0b3011db520e40b15f0974f765a0f/tests/gh-actions/kf-objects/katib_test.yaml

might have to be updated

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

@andreyvelich in kubeflow/katib#2256 (comment) says that they already support 1.27. Maybe our tests are outdated

See also #2602

Yea, that's right. The katib already supports the K8s v1.27.

@juliusvonkohout
Copy link
Member Author

@tenzen-y can you provide us a modern test file than that finishes in 2 minutes on Kubernetes 1.27?

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

@tenzen-y can you provide us a modern test file than that finishes in 2 minutes on Kubernetes 1.27?

We're using the same test as #2637 (comment)

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

@juliusvonkohout Oh, I found that this repository uses the docker.io/kubeflowkatib/mxnet-mnist:latest here:

image: docker.io/kubeflowkatib/mxnet-mnist:latest

But the image wouldn't work well since the MXNet project has already been closed. So, once kubeflow/katib#2267 is merged, I can share a new example with you.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Mar 4, 2024
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout changed the title Update to Kind 1.27 Update to Kind 1.27 and fix the integration tests Mar 4, 2024
@juliusvonkohout
Copy link
Member Author

@tenzen-y i crafted something very fast from your latest PR, since the tests must run in 2 minutes. Seems to be good now.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM perspective of Katib.

@@ -1,78 +1,56 @@
---
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

This is duplicated.

@juliusvonkohout juliusvonkohout merged commit fae22e1 into master Mar 4, 2024
19 of 20 checks passed
juliusvonkohout added a commit that referenced this pull request Mar 4, 2024
* update to Kind 1.27

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update katib test

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update katib test

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* increase test pipeline timeout from 60 to 120 seconds

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
juliusvonkohout added a commit that referenced this pull request Mar 4, 2024
* update to Kind 1.27



* update katib test



* update katib test



* increase test pipeline timeout from 60 to 120 seconds



---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout deleted the update-kind-127 branch March 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants