Fix kserve upgrade script and update kserve diagram #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
fix-kserve-upgrade-script
branch
from
bea94c1 to
1ff865f
Compare
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
sivanantha321
force-pushed
the
fix-kserve-upgrade-script
branch
from
603cd13 to
18a0776
Compare
|
Hhm on a first glimpse it looks as if there are synchronisation scripts in two places. @rimolive we probably should take a closer look |
|
It is definitely not perfect, but at least an improvement. Ill remove the makefile in another PR since we have the synchronization script. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, sivanantha321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
juliusvonkohout
pushed a commit
that referenced
this pull request
May 13, 2024
* Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
google-oss-prow bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
google-oss-prow bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * update readme (#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Fixes for dco changes (#2713) * Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
6 tasks
doncorsean
pushed a commit
to doncorsean/kubeflow-manifests
that referenced
this pull request
Jul 18, 2024
* Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
doncorsean
pushed a commit
to doncorsean/kubeflow-manifests
that referenced
this pull request
Jul 18, 2024
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
rimolive
pushed a commit
to rimolive/manifests
that referenced
this pull request
Aug 19, 2024
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Fixes for dco changes (kubeflow#2713) * Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Kserve recently renamed the release artifact from kserve-runtimes.yaml to kserve-cluster-resources.yaml. However, the Makefile still references the old one. This PR resolves this issue.
This PR also updates the kserve diagram.
Description of your changes:
Checklist:
Make sure you have installed kustomize == 5.2.1+
make generate-changed-onlymake test