Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the Trivy scanning workflow to upload artifacts #2860

Conversation

hansinikarunarathne
Copy link
Member

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I added the new step to upload Trivy results artifacts.
By default, GitHub Actions artifacts are retained for 90 days before they are automatically deleted. However, you can adjust the retention period as needed. For more information, refer to the GitHub documentation on configuring the retention period for GitHub Actions artifacts and logs.

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you!

@google-oss-prow google-oss-prow bot added the lgtm label Aug 27, 2024
@tarilabs tarilabs removed their assignment Aug 27, 2024
@juliusvonkohout
Copy link
Member

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 271dfee into kubeflow:master Aug 27, 2024
7 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
* add step Upload trivy scanned_results to trivy.yaml

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

* fix linting issues

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

---------

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants