Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracker] next steps ModelRegistry Custom Storage Initializer #33

Open
5 tasks
tarilabs opened this issue Mar 8, 2024 · 3 comments
Open
5 tasks

[tracker] next steps ModelRegistry Custom Storage Initializer #33

tarilabs opened this issue Mar 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@tarilabs
Copy link
Member

tarilabs commented Mar 8, 2024

  • Add image build directive in the model registry root Makefile (re-using csi Makefile)
  • update KServe website, following this: Add ModelRegistry custom storage intializer example kserve/website#346
    to show integration of CSI image here in KF/model-registry instead of the current placeholder of the exampleimage: abc/model-registry-storage-initializer:latest (should read eventually something like image: kubeflow/model-registry-storage-initializer:latest)
  • Set container image registry
  • Add some testing focusing on the MR interaction using testcontainers (mocking the download itself)

Stretch goals:

  • Use kiota (or other openapi code-generators) to autogenerate the client, this will make the CSI less dependent on the internal model registry implementation (this will also make the CSI just tied to the openapi spec rather than MR version)

See previous work on this topic:

If you-reading-this-issue start to work on any of these points, kindly notify by creating a relevant issue, assign it to yourself and reach out to confirm scope with the maintainers :)

@tarilabs tarilabs added the enhancement New feature or request label Mar 8, 2024
rkubis pushed a commit to rkubis/model-registry that referenced this issue Mar 27, 2024
[pull] main from kubeflow:main
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tarilabs
Copy link
Member Author

this is being worked with: #154

@lampajr
Copy link
Member

lampajr commented Sep 2, 2024

Stretch goal being tracked by #338

@tarilabs I think that all non-stretch goals (except for "update KServe website") can be considered as done/completed so I think you can tick the corresponding boxes in this PR's description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants