Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch and create registered models #129

Merged

Conversation

ederign
Copy link
Member

@ederign ederign commented Jun 7, 2024

In this PR:

  • GET /v1/model-registry/{model_registry_id}/registered_models
  • POST /v1/model-registry/{model_registry_id}/registered_models
  • HTTP client

Description

This commit sits on top of #128 . The diff of this PR is on f434394

With those two PRs, I can work on the frontend basic functionality (fetch and create registered models). \o/

How Has This Been Tested?

There are a few things that you need to do to test this:

  • Create at least one service
kind: Service
apiVersion: v1
metadata:
  labels:
    app: metadata
  name: model-registry
spec:
  selector:
    component: model-registry-server
  type: ClusterIP
  ports:
  - port: 8080
    protocol: TCP
    appProtocol: http
    name: http-api
  - port: 9090
    protocol: TCP
    appProtocol: grpc
    name: grpc-api%
  • Run MR backend via docker compose:
docker compose -f docker-compose.yaml up
  • Forward service IP to docker compose
kubectl describe service/model-registry | grep IP
IP:                10.96.87.69

sudo ifconfig lo0 alias 10.96.87.69 # this will fw service IP to MR docker compose endpoint
  • Run the app
make run
execute the curl calls described on README.MD
image

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@ederign ederign changed the title Bff fetch create registered model feat: fetch and create registered models Jun 7, 2024
@ederign
Copy link
Member Author

ederign commented Jun 10, 2024

I'll rebase this PR asap.

In this PR:
- GET /v1/model-registry/{model_registry_id}/registered_models
- POST /v1/model-registry/{model_registry_id}/registered_models
- HTTP client

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@ederign ederign force-pushed the bff-fetch-create-registeredModel branch from f434394 to 2addd32 Compare June 12, 2024 19:11
@ederign
Copy link
Member Author

ederign commented Jun 12, 2024

@tarilabs we are ready to review!

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this poses the basis for create/list of RegisteredModel entity, plus handing of K8s Service representing a Model Registry, for BFF scope

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ce4a545 into kubeflow:main Jun 14, 2024
11 checks passed
mzhl1111 pushed a commit to mzhl1111/model-registry that referenced this pull request Jul 1, 2024
In this PR:
- GET /v1/model-registry/{model_registry_id}/registered_models
- POST /v1/model-registry/{model_registry_id}/registered_models
- HTTP client

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: muzhouliu <sllzhlv77@gmail.com>
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request Jul 10, 2024
The low-level client gets moved to core. Previous docs get moved into
reference.

The client submodule is underscored to make it "private", thus only
letting the user import it from the MR module directly, i.e.

```py
from model_registry import ModelRegistry
# but now
# from model_registry.client import ModelRegistry
```

Core tests are moved into a separate file, while the previous
`test_client` file now has tests for the new frontend behavior.

Related: kubeflow#129
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
tarilabs pushed a commit to tarilabs/model-registry that referenced this pull request Oct 5, 2024
[pull] main from kubeflow:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants