-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch and create registered models #129
feat: fetch and create registered models #129
Conversation
I'll rebase this PR asap. |
In this PR: - GET /v1/model-registry/{model_registry_id}/registered_models - POST /v1/model-registry/{model_registry_id}/registered_models - HTTP client Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
f434394
to
2addd32
Compare
@tarilabs we are ready to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this poses the basis for create/list of RegisteredModel entity, plus handing of K8s Service representing a Model Registry, for BFF scope
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR: - GET /v1/model-registry/{model_registry_id}/registered_models - POST /v1/model-registry/{model_registry_id}/registered_models - HTTP client Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> Signed-off-by: muzhouliu <sllzhlv77@gmail.com>
The low-level client gets moved to core. Previous docs get moved into reference. The client submodule is underscored to make it "private", thus only letting the user import it from the MR module directly, i.e. ```py from model_registry import ModelRegistry # but now # from model_registry.client import ModelRegistry ``` Core tests are moved into a separate file, while the previous `test_client` file now has tests for the new frontend behavior. Related: kubeflow#129 Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
[pull] main from kubeflow:main
In this PR:
Description
This commit sits on top of #128 . The diff of this PR is on f434394
With those two PRs, I can work on the frontend basic functionality (fetch and create registered models). \o/
How Has This Been Tested?
There are a few things that you need to do to test this:
Merge criteria: