Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump grpc to 1.65.0 #191

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Bump grpc to 1.65.0 #191

merged 2 commits into from
Jul 16, 2024

Conversation

isinyaaa
Copy link
Contributor

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

dependabot bot and others added 2 commits July 15, 2024 15:06
@dependabot @isinyaaa
build(deps): bump google.golang.org/grpc from 1.63.2 to 1.65.0
530bf79 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.2 to 1.65.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.63.2...v1.65.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@isinyaaa
Ignore DialContext usage
1fa7ae1 
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
@tarilabs tarilabs mentioned this pull request Jul 16, 2024
Closed
tarilabs
tarilabs approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this and tracking #194

this is the best way for the most-immediate time being, and per suggestion in #194 a refactor could be scheduled for later

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 16, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 282c275 into kubeflow:main Jul 16, 2024
14 checks passed
@isinyaaa isinyaaa deleted the push-utwkxpmuxmmt branch July 16, 2024 14:24
@tarilabs tarilabs mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ckadner ckadner Awaiting requested review from ckadner

@rareddy rareddy Awaiting requested review from rareddy

Assignees

@tarilabs tarilabs

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isinyaaa @tarilabs