Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: build: simplify action #271

Merged
merged 1 commit into from
Aug 19, 2024
Merged

GHA: build: simplify action #271

merged 1 commit into from
Aug 19, 2024

Conversation

isinyaaa
Copy link
Contributor

No need to setup protoc twice. make build also invokes deps.

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@isinyaaa
GHA: build: simplify action
922a722 
No need to setup protoc twice. `make build` also invokes `deps`.

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
@isinyaaa
Copy link
Contributor Author

cc: @tarilabs

@tarilabs
Copy link
Member

good catch!

tarilabs
tarilabs approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @isinyaaa

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 19, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 22c93da into kubeflow:main Aug 19, 2024
14 checks passed
@isinyaaa isinyaaa deleted the push-rnnluvkzpxoy branch August 19, 2024 12:52
@tarilabs tarilabs mentioned this pull request Aug 22, 2024
Merged
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
@isinyaaa @Al-Pragliola
GHA: build: simplify action (kubeflow#271)
d525830 
No need to setup protoc twice. `make build` also invokes `deps`.

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@ckadner ckadner Awaiting requested review from ckadner

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@tarilabs tarilabs

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isinyaaa @tarilabs