Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app context and revamps App.tsx #289

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Aug 21, 2024

Description

Add a High Level context (TBD the content of the context itself) to load before dashboard init.
Also added some utils to make sure we persist some of the data.

How Has This Been Tested?

Change the harcoded values from the customHook to get different screens.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@lucferbux
Copy link
Contributor Author

@Griffin-Sullivan I wanna merge your PR first so then i can refactor the imports to the right format.
Also, I'm gonna add the first cypress tests to cover the loading and error state, will do once merged the other PR.

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things that don't matter. I tested the different states and they loaded properly. userError = true, configError = true, loading = true, and normal. Not sure how we can test browser storage at the moment so can't speak on that, but the code looks good to me.

clients/ui/frontend/src/app/App.tsx Outdated Show resolved Hide resolved
clients/ui/frontend/src/app/App.tsx Outdated Show resolved Hide resolved
@lucferbux lucferbux force-pushed the mod-arch-10568 branch 2 times, most recently from f175d33 to ecb96ce Compare August 22, 2024 14:43
@alexcreasy
Copy link
Contributor

/approve

@alexcreasy
Copy link
Contributor

/lgtm

@alexcreasy
Copy link
Contributor

/approve cancel

@alexcreasy
Copy link
Contributor

@lucferbux just needs the test failure fixed

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on this until we discuss a few things!

Signed-off-by: lucferbux <lferrnan@redhat.com>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Aug 26, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 26, 2024
@google-oss-prow google-oss-prow bot merged commit abed26a into kubeflow:main Aug 26, 2024
14 checks passed
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Signed-off-by: lucferbux <lferrnan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants