-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app context and revamps App.tsx #289
Conversation
@Griffin-Sullivan I wanna merge your PR first so then i can refactor the imports to the right format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things that don't matter. I tested the different states and they loaded properly. userError = true, configError = true, loading = true, and normal. Not sure how we can test browser storage at the moment so can't speak on that, but the code looks good to me.
1fd1adf
to
0fd38ba
Compare
f175d33
to
ecb96ce
Compare
ecb96ce
to
3741a4d
Compare
/approve |
/lgtm |
/approve cancel |
@lucferbux just needs the test failure fixed |
3741a4d
to
1ef0d15
Compare
1ef0d15
to
f2efd6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on this until we discuss a few things!
Signed-off-by: lucferbux <lferrnan@redhat.com>
f2efd6c
to
b240367
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: lucferbux <lferrnan@redhat.com>
Description
Add a High Level context (TBD the content of the context itself) to load before dashboard init.
Also added some utils to make sure we persist some of the data.
How Has This Been Tested?
Change the harcoded values from the customHook to get different screens.
Merge criteria: