Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mod arch OpenAPI spec #316

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Aug 27, 2024

Description

How Has This Been Tested?

Merge criteria:

Add API specficiation for UI Modular Architecture project

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Tested that the swagger is generating the UI in: https://editor-next.swagger.io/?url=https://raw.githubusercontent.com/lucferbux/model-registry/mod-arch-10569/clients/ui/api/openapi/mod-arch.yaml

Signed-off-by: lucferbux <lferrnan@redhat.com>
@lucferbux lucferbux marked this pull request as ready for review August 27, 2024 14:50
@ederign
Copy link
Member

ederign commented Aug 28, 2024

@lucferbux, thank you for your PR. To double-check something, we are temporarily hardcoding the OPenAPI spec.

I'm assuming that as soon as the BFF has the Stub API implementations, we will automatically generate this file. Is that correct?

@lucferbux
Copy link
Contributor Author

@lucferbux, thank you for your PR. To double-check something, we are temporarily hardcoding the OPenAPI spec.

I'm assuming that as soon as the BFF has the Stub API implementations, we will automatically generate this file. Is that correct?

Yes, that's right. The idea would be auto generate it once the backend is set up.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Aug 28, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 28, 2024
@google-oss-prow google-oss-prow bot merged commit 1dd9af5 into kubeflow:main Aug 28, 2024
14 checks passed
Al-Pragliola pushed a commit to Al-Pragliola/model-registry that referenced this pull request Sep 3, 2024
Signed-off-by: lucferbux <lferrnan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants