Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: refactor by splitting impl for each model #371

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

isinyaaa
Copy link
Contributor

@isinyaaa isinyaaa commented Sep 9, 2024

Description

Splits the core layer implementation. Each file now handles a separate model and has its own test file.

No functional changes happened at all.

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @isinyaaa for this refactor, I can understand this simplifies maintenance as we've outgrown from the original scope since.

/lgtm

But before merging this kindly consider:

  1. Add "refactor" in the commit title,

this way we make clear the intent is just refactoring per your PR description.
Maybe core: refactor by splitting impl for each model or similar?

  1. Add in the commit message something ~like:
a quick bookmark to browse core api impl before this refactor is: https://github.com/kubeflow/model-registry/blob/969056f07f08925ec7b23f67d84cee6a11b58078/pkg/core/core.go
but the entire history can be browsed in the repo/on github

this way if we keep an handy bookmark link in the commit but of course the full history remains browsable locally and online and github.

@google-oss-prow google-oss-prow bot added the lgtm label Sep 10, 2024
@tarilabs tarilabs changed the title core: split impl for each model core: refactor by splitting impl for each model Sep 10, 2024
@google-oss-prow google-oss-prow bot removed the lgtm label Sep 10, 2024
@isinyaaa isinyaaa requested a review from tarilabs September 10, 2024 13:21
A quick bookmark to browse core api impl before this refactor is [1] but
the entire history can be browsed in the repo/on github.

[1]: https://github.com/kubeflow/model-registry/blob/969056f07f08925ec7b23f67d84cee6a11b58078/pkg/core/core.go

Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per #371 (review)

thank you @isinyaaa

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 10, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 31a6460 into kubeflow:main Sep 10, 2024
15 checks passed
@isinyaaa isinyaaa deleted the push-lzmkypqyyvrt branch September 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants