-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: refactor by splitting impl for each model #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @isinyaaa for this refactor, I can understand this simplifies maintenance as we've outgrown from the original scope since.
/lgtm
But before merging this kindly consider:
- Add "refactor" in the commit title,
this way we make clear the intent is just refactoring per your PR description.
Maybe core: refactor by splitting impl for each model
or similar?
- Add in the commit message something ~like:
a quick bookmark to browse core api impl before this refactor is: https://github.com/kubeflow/model-registry/blob/969056f07f08925ec7b23f67d84cee6a11b58078/pkg/core/core.go
but the entire history can be browsed in the repo/on github
this way if we keep an handy bookmark link in the commit but of course the full history remains browsable locally and online and github.
76fabb9
to
ffe5f43
Compare
A quick bookmark to browse core api impl before this refactor is [1] but the entire history can be browsed in the repo/on github. [1]: https://github.com/kubeflow/model-registry/blob/969056f07f08925ec7b23f67d84cee6a11b58078/pkg/core/core.go Signed-off-by: Isabella do Amaral <idoamara@redhat.com>
ffe5f43
to
9bc661b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Splits the core layer implementation. Each file now handles a separate model and has its own test file.
No functional changes happened at all.
How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes