Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds remaining endpoints for UI PoC #397

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Sep 17, 2024

Description

  • Improves API test accuracy and simplicity - tests now go through the full router handler to validate the URL etc.
  • Adds many more endpoints, including all required for first UI PoC -- see the updated README for details including example curls for testing
  • All Endpoints work in mock mode
  • All Endpoints aside from PATCH endpoints work in live cluster

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@alexcreasy alexcreasy changed the title Adds remaining endpoints for UI PoC [HOLD] Adds remaining endpoints for UI PoC Sep 17, 2024
@alexcreasy
Copy link
Contributor Author

/hold

@alexcreasy alexcreasy changed the title [HOLD] Adds remaining endpoints for UI PoC Adds remaining endpoints for UI PoC Sep 17, 2024
@alexcreasy
Copy link
Contributor Author

/unhold

@alexcreasy alexcreasy force-pushed the api-endpoints branch 2 times, most recently from b98ae52 to 1df0ad5 Compare September 17, 2024 15:37
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
…odel

Signed-off-by: Alex Creasy <alex@creasy.dev>
…odel

Signed-off-by: Alex Creasy <alex@creasy.dev>
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a super comprehensive review, but I did test the mocks are working and changes look fine to me. Lots of test improvements so I'm not to worried about this one since we will be heavily testing things manually as we develop the UI.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Sep 18, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 18, 2024
@google-oss-prow google-oss-prow bot merged commit 8dbc2e7 into kubeflow:main Sep 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants