-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds remaining endpoints for UI PoC #397
Conversation
/hold |
7fbbe5c
to
e0ef370
Compare
/unhold |
b98ae52
to
1df0ad5
Compare
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
…odel Signed-off-by: Alex Creasy <alex@creasy.dev>
…odel Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
Signed-off-by: Alex Creasy <alex@creasy.dev>
1df0ad5
to
20561b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a super comprehensive review, but I did test the mocks are working and changes look fine to me. Lots of test improvements so I'm not to worried about this one since we will be heavily testing things manually as we develop the UI.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, Griffin-Sullivan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description
How Has This Been Tested?
Merge criteria:
DCO
check)If you have UI changes