Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong indentation in makefile rule recipe #51

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix wrong indentation in makefile rule recipe #51

merged 1 commit into from
Mar 26, 2024

Conversation

tarilabs
Copy link
Member

wrong indentation of Makefile rule recipe as invoked by CI/GHA

How Has This Been Tested?

Invoking make docker/login locally

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@tarilabs
fix wrong indentation in makefile rule recipe
52302c4 
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
rareddy
rareddy approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 26, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rareddy, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 36cc191 into kubeflow:main Mar 26, 2024
11 checks passed
rkubis added a commit to rkubis/model-registry that referenced this pull request Apr 23, 2024
@rkubis
Merge pull request kubeflow#51 from tonyxrmdavidson/removetrustyAI
8b5da49 
This commit will remove Trusty-ai from the deployment
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request May 22, 2024
@tarilabs @lampajr
Define the Model Registry OpenAPI (kubeflow#51)
ae4ca20 
* Define the Model Registry OpenAPI

Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update api/openapi/modelregistry.yml

Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@rareddy rareddy

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @rareddy