Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lucferbux and Griffin-Sullivan as approvers in the UI #579

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

lucferbux
Copy link
Contributor

Description

Add @lucferbux and @Griffin-Sullivan as approvers in the UI repo

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: lucferbux <lferrnan@redhat.com>
@lucferbux
Copy link
Contributor Author

@tarilabs @ederign I think we have enough contributions to make ourselves as approvers, this will help in our velocity when part of the team is out.

@tarilabs
Copy link
Member

this adds in clients/ui scope which

/lgtm

I leave to @ederign for approval, thanks!

@tarilabs
Copy link
Member

update. please make sure you are a KF member first. Once that it's done, we can merge this

@ederign
Copy link
Member

ederign commented Nov 21, 2024

Proposal for membership for @lucferbux kubeflow/internal-acls#726

@ederign
Copy link
Member

ederign commented Nov 21, 2024

Proposal for membership for @Griffin-Sullivan kubeflow/internal-acls#728

@lucferbux lucferbux marked this pull request as ready for review November 21, 2024 14:55
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Nov 21, 2024

/lgtm thank you @lucferbux and @Griffin-Sullivan for all the hard work on model registry!

@ederign
Copy link
Member

ederign commented Nov 21, 2024

/lgtm

@ederign
Copy link
Member

ederign commented Nov 21, 2024

/verify-owners

1 similar comment
@lucferbux
Copy link
Contributor Author

/verify-owners

@google-oss-prow google-oss-prow bot merged commit 71e7bc2 into kubeflow:main Nov 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants