Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: test python client connection #91

Merged
merged 1 commit into from
May 16, 2024
Merged

GHA: test python client connection #91

merged 1 commit into from
May 16, 2024

Conversation

isinyaaa
Copy link
Contributor

Description

Test Python client connectivity with the latest client.

How Has This Been Tested?

Tested by deploying a KinD cluster locally using the same setup.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@isinyaaa
GHA: test python client connection
7616d79 
Signed-off-by: Isabella Basso do Amaral <idoamara@redhat.com>
@isinyaaa isinyaaa requested a review from rareddy May 14, 2024 21:41
tarilabs
tarilabs approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

to start with, and we can always progressively iterate, for instance if QE folks could help us extend the RobotFramework testing which already incorporates some Python SDK calls

/approve

@google-oss-prow google-oss-prow bot added the lgtm label May 16, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ee5ae40 into kubeflow:main May 16, 2024
10 checks passed
@tarilabs tarilabs mentioned this pull request May 16, 2024
Merged
@isinyaaa isinyaaa deleted the py-conn-test branch May 16, 2024 12:58
dhirajsb pushed a commit to dhirajsb/model-registry-kfp that referenced this pull request May 22, 2024
@rareddy
Adding the tracker template for issue creation (kubeflow#91)
eb05f45 
Signed-off-by: Ramesh Reddy <rareddy@jboss.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@Tomcli Tomcli Awaiting requested review from Tomcli

@rareddy rareddy Awaiting requested review from rareddy

Assignees

@tarilabs tarilabs

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isinyaaa @rareddy @tarilabs