Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add ns filter to podLister #622

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix: add ns filter to podLister #622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea538e
add ns filter to podLister
kuizhiqing Feb 5, 2024
85f78c3
Merge branch 'kubeflow:master' into fix-podlist-ns
kuizhiqing Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controller/mpi_job_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ func (c *MPIJobController) getRunningWorkerPods(mpiJob *kubeflow.MPIJob) ([]*cor
if err != nil {
return nil, err
}
podFullList, err := c.podLister.List(selector)
podFullList, err := c.podLister.Pods(mpiJob.Namespace).List(selector)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -956,7 +956,7 @@ func (c *MPIJobController) getOrCreateWorker(mpiJob *kubeflow.MPIJob) ([]*corev1
if err != nil {
return nil, err
}
podFullList, err := c.podLister.List(selector)
podFullList, err := c.podLister.Pods(mpiJob.Namespace).List(selector)
if err != nil {
return nil, err
}
Expand Down
Loading