This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
MXNet Operator: Consolidate manifests #91
Merged
google-oss-robot
merged 3 commits into
kubeflow:master
from
arrikto:feature-consolidate-manifests
Mar 18, 2021
Merged
MXNet Operator: Consolidate manifests #91
google-oss-robot
merged 3 commits into
kubeflow:master
from
arrikto:feature-consolidate-manifests
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
cc @kubeflow/wg-training-leads |
/retest |
Delete old manifests. Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
yanniszark
force-pushed
the
feature-consolidate-manifests
branch
from
March 17, 2021 17:14
42f5b07
to
983fce3
Compare
gaocegege
reviewed
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @kubeflow/wg-training-leads
terrytangyuan
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan, yanniszark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Umbrella-Issue: kubeflow/manifests#1769
MXNet Operator
Current manifests structure
Explanation
mxnet-operator
came from kubeflow/manifestsbase
andoverlays
already existed in the repoapplication
overlays contain Application CRs, which we want to move away from (Why do we need kubernetes-sigs/application controller in Kubeflow? manifests#1715 (comment))We'll add a
kubeflow
overlay to the existingoverlays
folder, which will importoverlays/v1
, as that's the version of upstream manifests.Recommended end state