Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

MXNet Operator: Consolidate manifests #91

Merged

Conversation

yanniszark
Copy link
Contributor

Umbrella-Issue: kubeflow/manifests#1769

MXNet Operator

Current manifests structure

.
├── base
├── mxnet-operator
│   ├── base
│   └── overlays
│       └── application
└── overlays
    ├── v1
    └── v1beta1

Explanation

We'll add a kubeflow overlay to the existing overlays folder, which will import overlays/v1, as that's the version of upstream manifests.

Recommended end state

.
├── base
└── overlays
    ├── kubeflow
    ├── v1
    └── v1beta1

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@yanniszark
Copy link
Contributor Author

cc @kubeflow/wg-training-leads

@yanniszark
Copy link
Contributor Author

/retest

Delete old manifests.

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@yanniszark yanniszark force-pushed the feature-consolidate-manifests branch from 42f5b07 to 983fce3 Compare March 17, 2021 17:14
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @kubeflow/wg-training-leads

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants