-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add action to enforce semantic PR titles #14
Conversation
I think I'd prefer a conventional commit bot over this. There's 21.5k lines of Javascript in this PR, and only about 100 lines of it is handwritten, the rest are dependencies! Anyways, it does not look wrong to me, so /lgtm |
@jiridanek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you @jiridanek , for reviewing. |
@Adembc can you make a new PR that only does the "validate PR titles" part, because we havent really decided on the labels for release notes generation yet. If you do that, please update to the latest version of the |
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
…d of disalowScopes Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@thesuperzapper done 8202eec |
@Adembc thanks! Lets look into a few things after this:
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I raised the same PR #158 into the |
This PR introduces a new GitHub Actions workflow to enforce semantic pull request titles for better clarity and consistency in the development process.