Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add action to enforce semantic PR titles #14

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

Adembc
Copy link
Contributor

@Adembc Adembc commented Jun 3, 2024

This PR introduces a new GitHub Actions workflow to enforce semantic pull request titles for better clarity and consistency in the development process.

@jiridanek
Copy link
Member

jiridanek commented Jun 20, 2024

I think I'd prefer a conventional commit bot over this. There's 21.5k lines of Javascript in this PR, and only about 100 lines of it is handwritten, the rest are dependencies! Anyways, it does not look wrong to me, so

/lgtm

Copy link

@jiridanek: changing LGTM is restricted to collaborators

In response to this:

I think I'd prefer a conventional commit bot over this. There's 21.5k lines of Javascript in this PR! Anyways, it does not look wrong to me, so

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Adembc
Copy link
Contributor Author

Adembc commented Jun 20, 2024

Thank you @jiridanek , for reviewing.
We discussed this issue in our last meeting and decided to create a new branch for the conventional-release-labels GHA code. @thesuperzapper will take care of this, and I will update this PR to reference it using kubeflow/notebooks/PATH@BRANCH.

@thesuperzapper thesuperzapper added the area/ci area - related to ci label Jul 18, 2024
@thesuperzapper thesuperzapper added this to the Repo Setup milestone Jul 18, 2024
@thesuperzapper thesuperzapper self-assigned this Jul 18, 2024
@thesuperzapper thesuperzapper removed this from the Repo Setup milestone Jul 18, 2024
@thesuperzapper thesuperzapper added the project/repo-setup project - repo setup and health label Jul 18, 2024
@thesuperzapper
Copy link
Member

@Adembc can you make a new PR that only does the "validate PR titles" part, because we havent really decided on the labels for release notes generation yet.

If you do that, please update to the latest version of the amannn/action-semantic-pull-request action, as there are new versions since this PR was made.

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
…d of disalowScopes

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@Adembc
Copy link
Contributor Author

Adembc commented Dec 11, 2024

@thesuperzapper done 8202eec

@thesuperzapper thesuperzapper changed the title ci: add action for semantic PR titles and apply labels ci: add action to enforce semantic PR titles Dec 11, 2024
@thesuperzapper
Copy link
Member

@Adembc thanks!

Lets look into a few things after this:

  1. Making a similar PR into the main branch
  2. Doing the "apply labels" step using the outputs feature of the amannn/action-semantic-pull-request step:
    • Remove all relevant labels, apply the ones that correspond to the type/scope.
    • We would probably need to use a custom actions/github-script, or we could use the same fork of the conventional-release-labels step as we previously were.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 11, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 346a74e into kubeflow:notebooks-v2 Dec 11, 2024
2 checks passed
@Adembc
Copy link
Contributor Author

Adembc commented Dec 11, 2024

I raised the same PR #158 into the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ci area - related to ci lgtm project/repo-setup project - repo setup and health size/M
Projects
Development

Successfully merging this pull request may close these issues.

3 participants