Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ws): add tests for workspace and workspaceKind controller loops #29

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

Adembc
Copy link

@Adembc Adembc commented Jul 23, 2024

This PR is still a work in progress, but I’d appreciate a review before completing all tests.

The tests covered in this PR include:

  • Verifying that resources like Service and StatefulSet are created when a Workspace is created.
  • Ensuring that reconciled resources are deleted and properly recreated.
  • Checking that updated reconciled resources are reverted as expected.
  • Validating that Go templates in WorkspaceKind's spec.podTemplate.extraEnv[].value function correctly:
    • Succeed with a valid portID.
    • Return an empty string for an invalid portID.
    • Set the Workspace to an error state for invalid template formats (e.g., using single quotes for the portID string).

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@thesuperzapper
Copy link
Member

@Adembc I have not reviewed this PR, but I have rebased it so the tests will run.

@Adembc Adembc marked this pull request as ready for review August 28, 2024 09:06
@thesuperzapper thesuperzapper added this to the v2.0.0-alpha.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Discussion
Development

Successfully merging this pull request may close these issues.

2 participants