change snapshot to inline snapshot for RunDetails

kubeflow · May 9, 2020 · 672a9e5 · 672a9e5
1 parent 1e880d5
commit 672a9e5
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 123 deletions.
diff --git a/frontend/src/pages/RunDetails.test.tsx b/frontend/src/pages/RunDetails.test.tsx
@@ -614,7 +614,127 @@ describe('RunDetails', () => {
     await TestUtils.flushPromises();
     clickGraphNode(tree, 'node1');
     expect(tree.state('selectedNodeDetails')).toHaveProperty('id', 'node1');
-    expect(tree).toMatchSnapshot();
+    expect(tree).toMatchInlineSnapshot(`
+      <div
+        className="page"
+      >
+        <div
+          className="page"
+        >
+          <MD2Tabs
+            onSwitch={[Function]}
+            selectedTab={0}
+            tabs={
+              Array [
+                "Graph",
+                "Run output",
+                "Config",
+              ]
+            }
+          />
+          <div
+            className="page"
+          >
+            <div
+              className="page graphPane"
+            >
+              <div
+                className="page"
+              >
+                <EnhancedGraph
+                  graph={
+                    Graph {
+                      "_defaultEdgeLabelFn": [Function],
+                      "_defaultNodeLabelFn": [Function],
+                      "_edgeLabels": Object {},
+                      "_edgeObjs": Object {},
+                      "_in": Object {},
+                      "_isCompound": false,
+                      "_isDirected": true,
+                      "_isMultigraph": false,
+                      "_label": Object {},
+                      "_nodes": Object {},
+                      "_out": Object {},
+                      "_preds": Object {},
+                      "_sucs": Object {},
+                    }
+                  }
+                  onClick={[Function]}
+                  onError={[Function]}
+                  selectedNodeId="node1"
+                />
+                <SidePanel
+                  isBusy={false}
+                  isOpen={true}
+                  onClose={[Function]}
+                  title="node1"
+                >
+                  <div
+                    className="page"
+                  >
+                    <MD2Tabs
+                      onSwitch={[Function]}
+                      selectedTab={0}
+                      tabs={
+                        Array [
+                          "Artifacts",
+                          "Input/Output",
+                          "ML Metadata",
+                          "Volumes",
+                          "Manifest",
+                          "Logs",
+                          "Pod",
+                          "Events",
+                        ]
+                      }
+                    />
+                    <div
+                      className="page"
+                      data-testid="run-details-node-details"
+                    >
+                      <ArtifactsTabContent
+                        generatedVisualizations={Array []}
+                        nodeId="node1"
+                        nodeStatus={
+                          Object {
+                            "id": "node1",
+                          }
+                        }
+                        onError={[Function]}
+                        visualizationCreatorConfig={
+                          Object {
+                            "allowCustomVisualizations": false,
+                            "isBusy": false,
+                            "onGenerate": [Function],
+                            "type": "visualization-creator",
+                          }
+                        }
+                      />
+                    </div>
+                  </div>
+                </SidePanel>
+                <div
+                  className="footer"
+                >
+                  <div
+                    className="flex"
+                  >
+                    <pure(InfoOutlinedIcon)
+                      className="infoIcon"
+                    />
+                    <span
+                      className="infoSpan"
+                    >
+                      Runtime execution graph. Only steps that are currently running or have already completed are shown.
+                    </span>
+                  </div>
+                </div>
+              </div>
+            </div>
+          </div>
+        </div>
+      </div>
+    `);
   });
 
   it('shows clicked node message in side panel', async () => {

diff --git a/frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap b/frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap
@@ -978,128 +978,6 @@ exports[`RunDetails logs tab switches to logs tab in side pane 1`] = `
 </div>
 `;
 
-exports[`RunDetails opens side panel when graph node is clicked 1`] = `
-<div
-  className="page"
->
-  <div
-    className="page"
-  >
-    <MD2Tabs
-      onSwitch={[Function]}
-      selectedTab={0}
-      tabs={
-        Array [
-          "Graph",
-          "Run output",
-          "Config",
-        ]
-      }
-    />
-    <div
-      className="page"
-    >
-      <div
-        className="page graphPane"
-      >
-        <div
-          className="page"
-        >
-          <EnhancedGraph
-            graph={
-              Graph {
-                "_defaultEdgeLabelFn": [Function],
-                "_defaultNodeLabelFn": [Function],
-                "_edgeLabels": Object {},
-                "_edgeObjs": Object {},
-                "_in": Object {},
-                "_isCompound": false,
-                "_isDirected": true,
-                "_isMultigraph": false,
-                "_label": Object {},
-                "_nodes": Object {},
-                "_out": Object {},
-                "_preds": Object {},
-                "_sucs": Object {},
-              }
-            }
-            onClick={[Function]}
-            onError={[Function]}
-            selectedNodeId="node1"
-          />
-          <SidePanel
-            isBusy={false}
-            isOpen={true}
-            onClose={[Function]}
-            title="node1"
-          >
-            <div
-              className="page"
-            >
-              <MD2Tabs
-                onSwitch={[Function]}
-                selectedTab={0}
-                tabs={
-                  Array [
-                    "Artifacts",
-                    "Input/Output",
-                    "ML Metadata",
-                    "Volumes",
-                    "Manifest",
-                    "Logs",
-                    "Pod",
-                    "Events",
-                  ]
-                }
-              />
-              <div
-                className="page"
-                data-testid="run-details-node-details"
-              >
-                <ArtifactsTabContent
-                  generatedVisualizations={Array []}
-                  nodeId="node1"
-                  nodeStatus={
-                    Object {
-                      "id": "node1",
-                    }
-                  }
-                  onError={[Function]}
-                  visualizationCreatorConfig={
-                    Object {
-                      "allowCustomVisualizations": false,
-                      "isBusy": false,
-                      "onGenerate": [Function],
-                      "type": "visualization-creator",
-                    }
-                  }
-                />
-              </div>
-            </div>
-          </SidePanel>
-          <div
-            className="footer"
-          >
-            <div
-              className="flex"
-            >
-              <pure(InfoOutlinedIcon)
-                className="infoIcon"
-              />
-              <span
-                className="infoSpan"
-              >
-                Runtime execution graph. Only steps that are currently running or have already completed are shown.
-              </span>
-            </div>
-          </div>
-        </div>
-      </div>
-    </div>
-  </div>
-</div>
-`;
-
 exports[`RunDetails renders an empty run 1`] = `
 <div
   className="page"