Fix bug in #3707 - href should show full artifact content instead of …

…preview (#3745)
kubeflow · May 12, 2020 · e57a619 · e57a619
1 parent 5740535
commit e57a619
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/frontend/src/components/MinioArtifactPreview.test.tsx b/frontend/src/components/MinioArtifactPreview.test.tsx
@@ -105,7 +105,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=s3&peek=255&bucket=foo&key=bar"
+            href="artifacts/get?source=s3&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="s3://foo/bar"
@@ -145,7 +145,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=minio&peek=255&bucket=foo&key=bar"
+            href="artifacts/get?source=minio&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="minio://foo/bar"
@@ -185,7 +185,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=minio&namespace=namespace&peek=255&bucket=foo&key=bar"
+            href="artifacts/get?source=minio&namespace=namespace&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="minio://foo/bar"
@@ -224,7 +224,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=minio&peek=255&bucket=foo&key=bar"
+            href="artifacts/get?source=minio&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="minio://foo/bar"
@@ -257,7 +257,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=minio&peek=15&bucket=foo&key=bar"
+            href="artifacts/get?source=minio&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="minio://foo/bar"
@@ -302,7 +302,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=minio&peek=15&bucket=foo&key=bar"
+            href="artifacts/get?source=minio&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="minio://foo/bar"
@@ -346,7 +346,7 @@ describe('MinioArtifactPreview', () => {
         >
           <a
             class="link"
-            href="artifacts/get?source=minio&peek=10&bucket=foo&key=bar"
+            href="artifacts/get?source=minio&bucket=foo&key=bar"
             rel="noopener"
             target="_blank"
             title="minio://foo/bar"

diff --git a/frontend/src/components/MinioArtifactPreview.tsx b/frontend/src/components/MinioArtifactPreview.tsx
@@ -105,7 +105,7 @@ const MinioArtifactPreview: React.FC<MinioArtifactPreviewProps> = ({
   // TODO need to come to an agreement how to encode artifact info inside a url
   // namespace is currently not supported
   const linkText = Apis.buildArtifactUrl(storagePath);
-  const artifactUrl = Apis.buildReadFileUrl(storagePath, namespace, maxbytes);
+  const artifactUrl = Apis.buildReadFileUrl(storagePath, namespace);
 
   // Opens in new window safely
   // TODO use ArtifactLink instead (but it need to support namespace)