Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add local task dispatcher validation and ExecutorInput construction #localexecution #10298

Merged

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Dec 11, 2023

Description of your changes:
More local execution changes. The main changes are to add some local execution validation + tests, as well as the code to construct the local executor input.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy connor-mccarthy marked this pull request as ready for review December 11, 2023 01:47
@connor-mccarthy connor-mccarthy changed the title feat(sdk): add local execution task dispatcher logic feat(sdk): add local task dispatcher validation and execution input construction #localexecution Dec 11, 2023
@connor-mccarthy connor-mccarthy changed the title feat(sdk): add local task dispatcher validation and execution input construction #localexecution feat(sdk): add local task dispatcher validation and ExecutorInput construction #localexecution Dec 11, 2023
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 7a914cb link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Dec 12, 2023
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

kubeflow-pipelines-sdk-execution-tests failures are independent of these changes and tracked separately. Manually merging.

@connor-mccarthy connor-mccarthy merged commit d41efc3 into kubeflow:master Dec 12, 2023
19 of 21 checks passed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants