feat(sdk): add subprocess task handler #localexecution #10302
Conversation
|
Skipping CI for Draft Pull Request. |
connor-mccarthy
force-pushed
the
add-subprocess-task-handler
branch
from
3982076
to
a09502d
Compare
|
/assign @chensun |
connor-mccarthy
force-pushed
the
add-subprocess-task-handler
branch
from
a09502d
to
eb952a9
Compare
connor-mccarthy
force-pushed
the
add-subprocess-task-handler
branch
4 times, most recently
from
180de73
to
7e0ea2f
Compare
connor-mccarthy
force-pushed
the
add-subprocess-task-handler
branch
4 times, most recently
from
4bc18f3
to
6680d5d
Compare
|
/retest |
connor-mccarthy
force-pushed
the
add-subprocess-task-handler
branch
from
6680d5d
to
6b65551
Compare
sdk/python/kfp/dsl/executor.py
Outdated
| @@ -191,7 +191,7 @@ def handle_single_return_value(self, output_name: str, annotation_type: Any, | |||
| origin_type = getattr(annotation_type, '__origin__', | |||
| None) or annotation_type | |||
| # relax float-typed return to allow both int and float. | |||
| if origin_type == float: | |||
| if origin_type in {int, float}: | |||
There was a problem hiding this comment.
This seems to be an orthogonal behavior change? And it seems this might be problematic to accept float when the int was expected?
There was a problem hiding this comment.
Yes. Thank you for catching that. This LOC was included in error.
I'll flag the correct solution to the problem this intended to solve in the next PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* add subprocess task handler * response to review feedback
Description of your changes:
Add subprocess task handler to the task dispatcher.
There are basic tests, but will add more comprehensive E2E local execution tests once we support accessing outputs on locally executed tasks. There several other TODOs included throughout.
Checklist: