Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): write local execution logs to stdout #localexecution #10330

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
In a notebook, stderr prints above stdout. For the logs to present sequentially and interleave correctly in a notebook, they must both write to the same place. We choose to write to stdout, consistent with print.

Checklist:

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@google-oss-prow google-oss-prow bot added size/M and removed size/XS labels Dec 19, 2023
@connor-mccarthy connor-mccarthy force-pushed the fix-local-execution-logs-in-notebook branch from c4ae62e to 6b0c0fe Compare December 20, 2023 03:07
@connor-mccarthy connor-mccarthy marked this pull request as ready for review December 20, 2023 03:07
@connor-mccarthy
Copy link
Member Author

/assign @chensun

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 20, 2023
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f52ba56 into kubeflow:master Dec 20, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants