Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): permit empty local execution outputs #localexecution #10338

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(sdk): permit empty local execution outputs #localexecution #10338

merged 1 commit into from
Jan 5, 2024

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Dec 20, 2023 •
edited
Loading

Description of your changes:
It should be permitted for a user to specify a dsl.OutputPath to which the output is not written. This PR fixes a key error when this is the case.

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review December 20, 2023 22:20
@connor-mccarthy connor-mccarthy marked this pull request as draft December 20, 2023 22:21
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy mentioned this pull request Dec 20, 2023
Merged
1 task
@google-oss-prow google-oss-prow bot added size/S and removed size/XL labels Jan 3, 2024
@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy connor-mccarthy marked this pull request as ready for review January 3, 2024 19:35
chensun
chensun reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's no fix, but only adding test? If so, title can be test(sdk): ...

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 3, 2024
@chensun chensun removed the lgtm label Jan 3, 2024
@connor-mccarthy connor-mccarthy changed the title fix(sdk): permit empty local execution outputs #localexecution test(sdk): permit empty local execution outputs #localexecution Jan 3, 2024
@connor-mccarthy
Copy link
Member Author

Good catch, @chensun. Updated.

/approve

@connor-mccarthy connor-mccarthy changed the title test(sdk): permit empty local execution outputs #localexecution test(sdk): assert empty local execution outputs permitted #localexecution Jan 3, 2024
@connor-mccarthy connor-mccarthy changed the title test(sdk): assert empty local execution outputs permitted #localexecution fix(sdk): permit empty local execution outputs #localexecution Jan 3, 2024
@connor-mccarthy
Copy link
Member Author

@chensun, NVM. Reverted title per https://github.com/kubeflow/pipelines/pull/10339/files#r1440864867. Also updated the test case so that it fails before the corresponding change, but passes after.

/remove-approve

@google-oss-prow google-oss-prow bot removed the approved label Jan 3, 2024
chensun
chensun approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 3, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

/retest

2 similar comments
@connor-mccarthy
Copy link
Member Author

/retest

@connor-mccarthy
Copy link
Member Author

/retest

@google-oss-prow Google OSS Prow
Copy link

google-oss-prow bot commented Jan 4, 2024 •
edited
Loading

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests 766e1d0 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member Author

/test kubeflow-pipelines-sdk-execution-tests

@google-oss-prow google-oss-prow bot merged commit 64d46df into kubeflow:master Jan 5, 2024
27 of 28 checks passed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@connor-mccarthy @stijntratsaertit
fix(sdk): permit empty local execution outputs #localexecution (kubef…
2abc173 
…low#10338)
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
@connor-mccarthy @petethegreat
fix(sdk): permit empty local execution outputs #localexecution (kubef…
3104679 
…low#10338)
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
@connor-mccarthy @petethegreat
fix(sdk): permit empty local execution outputs #localexecution (kubef…
95de3ec 
…low#10338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-mccarthy @chensun