feat(sdk): support Concat and IfPresent placeholder in local container component execution #localexecution #10348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor-mccarthy
force-pushed
the
local-ifpresent-concat
branch
2 times, most recently
from
76e245f
to
bfb4211
Compare
…r component execution #localexecution
connor-mccarthy
force-pushed
the
local-ifpresent-concat
branch
from
bfb4211
to
7e7bb4a
Compare
|
/assign @chensun |
|
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stijntratsaertit
pushed a commit
to stijntratsaertit/kfp
that referenced
this pull request
Feb 16, 2024
…r component execution #localexecution (kubeflow#10348) * feat(sdk): support Concat and IfPresent placeholder in local container component execution #localexecution * address review feedback * fix test
petethegreat
pushed a commit
to petethegreat/pipelines
that referenced
this pull request
Mar 27, 2024
…r component execution #localexecution (kubeflow#10348) * feat(sdk): support Concat and IfPresent placeholder in local container component execution #localexecution * address review feedback * fix test
petethegreat
pushed a commit
to petethegreat/pipelines
that referenced
this pull request
Mar 29, 2024
…r component execution #localexecution (kubeflow#10348) * feat(sdk): support Concat and IfPresent placeholder in local container component execution #localexecution * address review feedback * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Adds support for the
dsl.ConcatPlaceholderanddsl.IfPresentPlaceholderin local execution of Container Components.Checklist: