Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix metrics visualization v2 sample #10399

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented Jan 15, 2024

Description of your changes:
Fixes: #10208

Fix visualization metrics v2 sample

Checklist:

@rimolive
Copy link
Member Author

/retest

1 similar comment
@rimolive
Copy link
Member Author

/retest

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rimolive!

/ok-to-test

samples/test/metrics_visualization_v2.py Show resolved Hide resolved
backend/src/v2/test/sample_test.py Outdated Show resolved Hide resolved
samples/test/metrics_visualization_v2.py Outdated Show resolved Hide resolved
Copy link

@rimolive: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 f46bd85 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rimolive!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member

Manually merging since sample failures are independent of your changes.

@connor-mccarthy connor-mccarthy merged commit 6275177 into kubeflow:master Jan 18, 2024
1 of 4 checks passed
roytman pushed a commit to roytman/pipelines that referenced this pull request Feb 14, 2024
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Metrics Visualization v2 test is broken
2 participants