feat(GH workflow): migrate periodic functional tests to GH actions #10751

shruti2522 · 2024-04-25T07:58:58Z

Description of your changes:
Fixes #10745. I have added the workflow file and tried running it locally, but I guess there is some issue with the package versions in requirements.txt.

Error Log:

|   × Preparing metadata (pyproject.toml) did not run successfully.
|   │ exit code: 1
|   ╰─> [40 lines of output]
|       Traceback (most recent call last):
|         File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
|           main()
|         File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
|           json_out['return_val'] = hook(**hook_input['kwargs'])
|         File "/usr/lib/python3/dist-packages/pip/_vendor/pep517/in_process/_in_process.py", line 164, in prepare_metadata_for_build_wheel
|           return hook(metadata_directory, config_settings)
|         File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 174, in prepare_metadata_for_build_wheel
|           self.run_setup()
|         File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 267, in run_setup
|           super(_BuildMetaLegacyBackend,
|         File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 158, in run_setup
|           exec(compile(code, __file__, 'exec'), locals())
|         File "setup.py", line 68, in <module>
|           main()
|         File "setup.py", line 54, in main
|           setuptools.setup(
|         File "/usr/lib/python3/dist-packages/setuptools/__init__.py", line 153, in setup
|           return distutils.core.setup(**attrs)
|         File "/usr/lib/python3/dist-packages/setuptools/_distutils/core.py", line 109, in setup
|           _setup_distribution = dist = klass(attrs)
|         File "/usr/lib/python3/dist-packages/setuptools/dist.py", line 459, in __init__
|           _Distribution.__init__(
|         File "/usr/lib/python3/dist-packages/setuptools/_distutils/dist.py", line 293, in __init__
|           self.finalize_options()
|         File "/usr/lib/python3/dist-packages/setuptools/dist.py", line 837, in finalize_options
|           ep(self)
|         File "/usr/lib/python3/dist-packages/setuptools/dist.py", line 858, in _finalize_setup_keywords
|           ep.load()(self, ep.name, value)
|         File "/tmp/pip-build-env-sd7akepb/normal/local/lib/python3.10/dist-packages/cffi/setuptools_ext.py", line 216, in cffi_modules
|           add_cffi_module(dist, cffi_module)
|         File "/tmp/pip-build-env-sd7akepb/normal/local/lib/python3.10/dist-packages/cffi/setuptools_ext.py", line 49, in add_cffi_module
|           execfile(build_file_name, mod_vars)
|         File "/tmp/pip-build-env-sd7akepb/normal/local/lib/python3.10/dist-packages/cffi/setuptools_ext.py", line 25, in execfile
|           exec(code, glob, glob)
|         File "src/google_crc32c_build.py", line 47, in <module>
|           FFIBUILDER = cffi.FFI()
|         File "/tmp/pip-build-env-sd7akepb/normal/local/lib/python3.10/dist-packages/cffi/api.py", line 54, in __init__
|           raise Exception("Version mismatch: this is the 'cffi' package version %s, located in %r.  When we import the top-level '_cffi_backend' extension module, we get version %s, located in %r.  The two versions should be equal; check your installation." % (
|       Exception: Version mismatch: this is the 'cffi' package version 1.16.0, located in '/tmp/pip-build-env-sd7akepb/normal/local/lib/python3.10/dist-packages/cffi/api.py'.  When we import the top-level '_cffi_backend' extension module, we get version 1.15.0, located in '/usr/lib/python3/dist-packages/_cffi_backend.cpython-310-x86_64-linux-gnu.so'.  The two versions should be equal; check your installation.
|       [end of output]
|   
|   note: This error originates from a subprocess, and is likely not a problem with pip.
| error: metadata-generation-failed
| 
| × Encountered error while generating package metadata.
| ╰─> See above for output.
| 
| note: This is an issue with the package mentioned above, not pip.
| hint: See above for details.
[Periodic Functional Tests/run_tests]   ❌  Failure - Main Run Functional Tests
[Periodic Functional Tests/run_tests] exitcode '1': failure
[Periodic Functional Tests/run_tests] 🏁  Job failed
Error: Job 'run_tests' failed

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

CC @rimolive

google-oss-prow · 2024-04-25T07:59:10Z

Hi @shruti2522. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: migrate periodic functional tests to GH actions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: migrate periodic functional tests to GH actions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: migrate periodic functional tests to GH actions feat: migrate periodic functional tests to GH actions Signed-off-by: shruti2522 <shruti.apc01@gmail.com> feat: migrate periodic functional tests to GH actions Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

rimolive

Thank you for your contribution! I added some comments in the workflow code, you're doing a good job!

rimolive · 2024-04-25T11:37:57Z

.github/workflows/periodic.yml

+      setup_kind:
+      runs-on: ubuntu-latest
+      steps:
+    - name: Check if Docker is installed


This step can be removed. GH Actions always provide docker binary

rimolive · 2024-04-25T11:38:55Z

.github/workflows/periodic.yml

+        else
+            echo "Docker is already installed."
+        fi
+    - name: Install KinD


GH actions have an extension to provision KinD. Check this example: https://github.com/kubeflow/pipelines/blob/master/.github/workflows/backend.yml#L36

rimolive · 2024-04-25T11:39:34Z

.github/workflows/periodic.yml

+        curl -Lo kind https://kind.sigs.k8s.io/dl/v0.11.1/kind-linux-amd64
+        chmod +x kind
+        sudo mv kind /usr/local/bin
+    - name: Verify KinD installation


Remove that step. Previous step if using the GH Action extension already verify installation

rimolive · 2024-04-25T11:45:56Z

.github/workflows/periodic.yml

+    - name: Run Functional Tests
+      run: 
+        ./test/kfp-functional-test/kfp-functional-test.sh
+    - name: Collect test results


Although the step is present in the workflow, it requires some changes in the bash script to generate the artifacts.

Path creation is done here

Artifact collection is done here

Basically, what you can do is redirect this execution to a path that you create previously.

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

shruti2522 · 2024-04-25T13:36:23Z

I have updated the code. Please take a look, @rimolive.

rimolive

Some last changes before we start testing

rimolive · 2024-04-25T16:02:20Z

.github/workflows/periodic.yml

+        ./test/kfp-functional-test/kfp-functional-test.sh > periodic_tests.txt
+        mkdir -p ./test/artifacts  # Directory to store artifacts
+        cp periodic_tests.txt ./test/artifacts/
+


This code is important: https://github.com/kubeflow/pipelines/blob/master/.github/workflows/backend.yml#L76-L81

rimolive · 2024-04-25T16:03:46Z

.github/workflows/periodic.yml

+        node_image: kindest/node:v1.29.2      
+    - name: Run Functional Tests
+      run: 
+        ./test/kfp-functional-test/kfp-functional-test.sh > periodic_tests.txt


Let me suggest a different approach:

log_dir=$(mktemp -d) ./test/kfp-functional-test/kfp-functional-test.sh > $log_dir/periodic_tests.txt

Why mktemp? It creates a random path under /tmp for your temporary artifact collection task. That way, the last step only needs to get all the paths created by mktemp, compress in a tarball, and publish to a remote path.

I've made the changes you suggested and included the artifact collection, @rimolive.

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

rimolive · 2024-04-26T20:03:20Z

/ok-to-test

rimolive · 2024-05-04T15:18:50Z

.github/workflows/periodic.yml

+        uses: actions/upload-artifact@v4
+        with:
+          name: periodic-functional-artifacts
+          path: $log_dir


Replace this line with the same content as in https://github.com/kubeflow/pipelines/blob/master/.github/workflows/backend.yml#L81

rimolive · 2024-05-04T15:20:30Z

.github/workflows/periodic.yml

+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2


nit: upgrade to actions/checkout@v4

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

shruti2522 · 2024-05-04T16:24:12Z

Done @rimolive

rimolive · 2024-05-04T17:09:55Z

Don't forget this. #10751 (comment)

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

shruti2522 · 2024-05-04T19:08:18Z

done with the changes @rimolive

rimolive · 2024-05-04T20:12:14Z

.github/workflows/periodic.yml

@@ -19,11 +19,10 @@ jobs:
          node_image: kindest/node:v1.29.2
      - name: Run Functional Tests
        run: |
-          log_dir=$(mktemp -d)


Please, add this line back and don't make any other changes. All we need is this line.

oh, might have done it by mistake. I will add it back

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

rimolive · 2024-05-05T20:27:02Z

/lgtm

cc @chensun

google-oss-prow · 2024-05-09T19:50:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chensun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot added the do-not-merge/work-in-progress label Apr 25, 2024

google-oss-prow bot requested review from chensun and zijianjoy April 25, 2024 07:59

google-oss-prow bot added size/M needs-ok-to-test labels Apr 25, 2024

shruti2522 force-pushed the periodic-functional-tests branch from 8da93d9 to 19a8d7f Compare April 25, 2024 08:03

shruti2522 force-pushed the periodic-functional-tests branch from 2b977b0 to cdfc9e5 Compare April 25, 2024 10:43

shruti2522 changed the title ~~feat: migrate periodic functional tests to GH actions~~ feat(GH workflow): migrate periodic functional tests to GH actions Apr 25, 2024

rimolive suggested changes Apr 25, 2024

View reviewed changes

updated kind installation and artifact collection

59de798

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

rimolive suggested changes Apr 25, 2024

View reviewed changes

updated artifact collection code

2e5db78

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

google-oss-prow bot added size/S and removed size/M labels Apr 26, 2024

shruti2522 marked this pull request as ready for review April 26, 2024 18:01

google-oss-prow bot removed the do-not-merge/work-in-progress label Apr 26, 2024

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Apr 26, 2024

rimolive suggested changes May 4, 2024

View reviewed changes

rimolive reviewed May 4, 2024

View reviewed changes

updated version

f923dea

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

updated path

2c37d1f

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

rimolive suggested changes May 4, 2024

View reviewed changes

added log_dir

d01c26b

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

google-oss-prow bot assigned rimolive May 5, 2024

google-oss-prow bot added the lgtm label May 5, 2024

chensun approved these changes May 9, 2024

View reviewed changes

google-oss-prow bot added the approved label May 9, 2024

google-oss-prow bot merged commit c4d7ec3 into kubeflow:master May 9, 2024
2 checks passed

tmvfb mentioned this pull request May 10, 2024

test: fix CI failure for periodic functional tests #10817

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(GH workflow): migrate periodic functional tests to GH actions #10751

feat(GH workflow): migrate periodic functional tests to GH actions #10751

shruti2522 commented Apr 25, 2024 •

edited

Loading

google-oss-prow bot commented Apr 25, 2024

rimolive left a comment

rimolive Apr 25, 2024

rimolive Apr 25, 2024

rimolive Apr 25, 2024

rimolive Apr 25, 2024

shruti2522 commented Apr 25, 2024

rimolive left a comment

rimolive Apr 25, 2024

rimolive Apr 25, 2024

rimolive Apr 25, 2024

shruti2522 Apr 26, 2024

rimolive commented Apr 26, 2024

rimolive May 4, 2024

rimolive May 4, 2024

shruti2522 commented May 4, 2024

rimolive commented May 4, 2024

shruti2522 commented May 4, 2024

rimolive May 4, 2024

shruti2522 May 4, 2024

shruti2522 May 4, 2024

rimolive commented May 5, 2024

google-oss-prow bot commented May 9, 2024

feat(GH workflow): migrate periodic functional tests to GH actions #10751

feat(GH workflow): migrate periodic functional tests to GH actions #10751

Conversation

shruti2522 commented Apr 25, 2024 • edited Loading

google-oss-prow bot commented Apr 25, 2024

rimolive left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shruti2522 commented Apr 25, 2024

rimolive left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rimolive commented Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shruti2522 commented May 4, 2024

rimolive commented May 4, 2024

shruti2522 commented May 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rimolive commented May 5, 2024

google-oss-prow bot commented May 9, 2024

shruti2522 commented Apr 25, 2024 •

edited

Loading