Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix version conflict for functional tests #10837

Conversation

tmvfb
Copy link
Contributor

@tmvfb tmvfb commented May 22, 2024

Description of your changes:
Functional tests are still broken (and seem to annoy not only me) despite the fix #10817. Apologies for creating multiple pull requests, looked to me that the previous PR worked.

What's causing problems now is the outdated requirements.txt file (see here). I deleted the old file and created a new one by running pip-compile requirements.in on python3.12 (supported by kfp>=2.5.0).

This PR fixes version conflict issue. Unfortunately, I'm not able to run complete test on my fork, since that requires google cloud configuration. So further problems related to gcloud authentication might possibly be encountered.

image

Note: Should I use kfp version 2.0.5 in requirements.in instead of the current one? Seems that test cluster should be using that version (https://github.com/kubeflow/testing/blob/master/test-infra/kfp/Makefile).

Checklist:

Copy link

Hi @tmvfb. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Igor Kvachenok <igor.kvachenok@prokube.ai>
@tmvfb tmvfb force-pushed the fix/version-conflict-periodic-functional-tests branch from e7e45d3 to c000734 Compare May 22, 2024 12:31
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

@tmvfb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test c000734 link false /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmvfb
Copy link
Contributor Author

tmvfb commented May 22, 2024

Also prow tests have been failing since PR #10817 was merged.
Happens because sudo is not available on python3.7-slim image used for the prow tests. Not sure how to best fix that.

@HumairAK
Copy link
Collaborator

Question, maybe it would make sense to have these tests run on the PR, at least for when the workflow that changes this tests (or the tests themselves) are updated, so we can verify if these fixes have the intended affect or not?

@tmvfb
Copy link
Contributor Author

tmvfb commented May 22, 2024

Question, maybe it would make sense to have these tests run on the PR, at least for when the workflow that changes this tests (or the tests themselves) are updated, so we can verify if these fixes have the intended affect or not?

Being able to run this in the context of kubeflow/pipelines environment before merging would surely make things easier!

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1d5e83b into kubeflow:master May 24, 2024
2 of 3 checks passed
@tmvfb tmvfb deleted the fix/version-conflict-periodic-functional-tests branch July 5, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants