-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix version conflict for functional tests #10837
test: fix version conflict for functional tests #10837
Conversation
Hi @tmvfb. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Igor Kvachenok <igor.kvachenok@prokube.ai>
e7e45d3
to
c000734
Compare
/ok-to-test |
@tmvfb: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Also prow tests have been failing since PR #10817 was merged. |
Question, maybe it would make sense to have these tests run on the PR, at least for when the workflow that changes this tests (or the tests themselves) are updated, so we can verify if these fixes have the intended affect or not? |
Being able to run this in the context of kubeflow/pipelines environment before merging would surely make things easier! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Functional tests are still broken (and seem to annoy not only me) despite the fix #10817. Apologies for creating multiple pull requests, looked to me that the previous PR worked.
What's causing problems now is the outdated requirements.txt file (see here). I deleted the old file and created a new one by running
pip-compile requirements.in
on python3.12 (supported by kfp>=2.5.0).This PR fixes version conflict issue. Unfortunately, I'm not able to run complete test on my fork, since that requires google cloud configuration. So further problems related to gcloud authentication might possibly be encountered.
Note: Should I use kfp version 2.0.5 in
requirements.in
instead of the current one? Seems that test cluster should be using that version (https://github.com/kubeflow/testing/blob/master/test-infra/kfp/Makefile).Checklist: