feat(kubernetes_platform): Add empty dir mount #10892
Conversation
|
Hi @gregsheremeta. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@chensun do you know whom I can nag about reviewing kfp-kubernetes PRs? I ask because it seems like Connor left the project. |
|
/ok-to-test |
| @@ -38,6 +38,7 @@ message KubernetesExecutorConfig { | |||
| repeated NodeAffinityTerm node_affinity = 14; | |||
| repeated PodAffinityTerm pod_affinity = 15; | |||
| EnabledSharedMemory enabled_shared_memory = 16; | |||
| repeated EmptyDirMount empty_dir_mount = 17; | |||
There was a problem hiding this comment.
interesting. I don't see plurals anywhere else -- for example, line 26:
repeated PvcMount pvc_mount = 3;
that said, this is my very first time doing anything with protobuf, so if repeated fields should be pluralized, I will pluralize it.
There was a problem hiding this comment.
ref: https://cloud.google.com/apis/design/naming_convention#repeated_field_names
Repeated fields in APIs must use proper plural forms. This matches the convention of existing Google APIs, and the common expectation of external developers.
gregsheremeta
force-pushed
the
add-empty-dir-mount
branch
from
2cd7b43
to
e18b07d
Compare
Part of kubeflow#10656 Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
gregsheremeta
force-pushed
the
add-empty-dir-mount
branch
from
e18b07d
to
9ba9bdd
Compare
|
@gregsheremeta: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
gregsheremeta
changed the title
|
s/WIP// I think it's good for final review |
|
@chensun can you re-lgtm this? I made the empty_dir_mount -> empty_dir_mounts change you asked for, and the lgtm was removed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Update kubernetes_platform go package to include the ability to add an EmptyDir mount.
Part 1 of 2. Will be rebased when the backend part is merged. Posting as a WIP now to get feedback on the fields in the proto message.
Following the example set in #10410.
Checklist: