Upgrade go version to 1.21

[DharmitD]

Description of your changes:
Resolves #10912

Checklist:

• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[hbelmiro]

/lgtm

cc @chensun

[DharmitD]

@chensun could you take a look?

[gregsheremeta]

yeah seems good to me. I thought about bumping the kfp-kubernetes one myself :)

/lgtm

[google-oss-prow]

@gregsheremeta: changing LGTM is restricted to collaborators

In response to this:

yeah seems good to me. I thought about bumping the kfp-kubernetes one myself :)

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[DharmitD]

@chensun this PR is reviewed and lgtm'd, could you please approve?

cc: @rimolive @HumairAK

[DharmitD]

cc @chensun @zijianjoy @james-jwu

[chensun]

/lgtm

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chensun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndersBennedsgaard]

I just noticed this PR and got interested. No need to change anything if you don't think it's relevant 😄

On another note: should we consider using Go workspaces to reduce duplication between projects? That would mean we only have to change the Go version in the go.work file at the root of the repo

[AndersBennedsgaard]

It might make sense to use something like this instead:

Suggested change

	go-version: 1.21.x
	go-version-file: './go.mod'

This would reduce the number of places where we have to upgrade Go in the future.
Obviously there are multiple go.mods in this repo, so if there is one that makes more sense than the one in the root of the repository, it could be changed to that instead

[HumairAK]

Hey @AndersBennedsgaard
I think these are very valid suggestions, but they are out of scope of this PR which is merely to upgrade the go version. My suggestion is to create an issue for this or propose a separate PR.

[HumairAK]

@DharmitD unfortunately tide is preventing merge due to: kubeflow-pipeline-e2e-test

This might be because you need to rebase the new changes to the github workflows

[DharmitD]

Rebased the PR. @HumairAK @gregsheremeta @hbelmiro could any of you lgtm again?

[google-oss-prow]

@DharmitD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kubeflow-pipeline-e2e-test	e58e0d1	link	false	/test kubeflow-pipeline-e2e-test
kfp-kubernetes-execution-tests	e58e0d1	link	false	/test kfp-kubernetes-execution-tests
kubeflow-pipeline-upgrade-test	da4e241	link	false	/test kubeflow-pipeline-upgrade-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hbelmiro]

/lgtm