test: Moved KFP backend visualization tests to GitHub Actions #10984
Conversation
|
Skipping CI for Draft Pull Request. |
hbelmiro
changed the title
|
/assign @DharmitD |
hbelmiro
force-pushed
the
backend-visualization-tests
branch
from
cece0b2
to
b88b5c1
Compare
| - 'test/presubmit-backend-visualization.sh' | ||
|
|
||
| jobs: | ||
| samples-v2-test: |
There was a problem hiding this comment.
aren't backend visualization and samples-v2 two different tests?
There was a problem hiding this comment.
Yes. I forgot to rename the job.
Fixed.
| @@ -1,4 +1,4 @@ | |||
| name: KFP backend visualization tests | |||
There was a problem hiding this comment.
would suggest changing it back to KFP Backend Visualization Tests, to keep the KFP suffix name convention consistent across all workflow names. For instance: https://github.com/kubeflow/pipelines/blob/master/.github/workflows/presubmit-backend.yml#L1
Also to be able to differentiate between KFP and kfp-tekton workflows: https://github.com/kubeflow/pipelines/blob/master/.github/workflows/backend.yml#L1
|
@hbelmiro could you squash commits to a single commit? |
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
hbelmiro
force-pushed
the
backend-visualization-tests
branch
from
30c1c7f
to
7628f29
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DharmitD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves: #10985
PR to remove the tests from GoogleCloudPlatform/oss-test-infra:
Checklist: