-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify image and add tls parameters #11259
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @YashviP. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -22,7 +22,7 @@ spec: | |||
# * .cloudbuild.yaml and .release.cloudbuild.yaml | |||
# * manifests/kustomize/base/metadata/base/metadata-grpc-deployment.yaml | |||
# * test/tag_for_hosted.sh | |||
image: gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0 | |||
image: docker.intuit.com/personal/y0001/ml_metadata_store_server:1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused, is this a private docker registry?
@YashviP at the moment it's not clear what the intention of this PR is, or what issue it's seeking to resolve. I would suggest providing a bit more context in your PR body. |
/hold |
Please follow our contribution guidelines to contribute with code. You need to sign-off your commits. You can find more details in https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits |
hi Yashvi! Welcome to Kubeflow 😄 Let us know if there's anything we can help you with! |
Description of your changes:
Checklist: