Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fields in SinglePlatformSpec #11299

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

chenyifan-vertex
Copy link
Collaborator

Description of your changes:
Add two fields in SinglePlatformSpec: platform and config.
This will be used by Platform Specifc features and currently used by Vertex Preflight validations.

Checklist:

Signed-off-by: chenyifan-vertex <151570620+chenyifan-vertex@users.noreply.github.com>
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Oct 15, 2024
@google-oss-prow google-oss-prow bot merged commit a0d313e into master Oct 15, 2024
14 checks passed
@google-oss-prow google-oss-prow bot deleted the single-platform-spec-2 branch October 15, 2024 22:04
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this pull request Oct 17, 2024
Signed-off-by: chenyifan-vertex <151570620+chenyifan-vertex@users.noreply.github.com>
@gregsheremeta
Copy link
Contributor

@chensun @chenyifan-vertex consider this my gentle protest about merging a PR 8 minutes after it was posted 😂

@chensun are these new fields something we can/should use for the (non-Vertex) kubernetes platform? If so, how? I'm specifically thinking about PipelineConfig, which we were going to add as a sibling to deployment_spec. But now I see there is a Struct config, and I wonder if it makes more sense to nest PipelineConfig under that.

Perhaps some examples of how you're using config in Vertex would help.

Or if you think PipelineConfig should just be PipelineConfig pipelineConfig = 4 sibling of deployment_spec, platform, and config, that's fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants