Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package version conflict #1201

Merged
merged 2 commits into from
Apr 23, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 22, 2019

This change is Reviewable

@Ark-kun Ark-kun force-pushed the Fix-package-version-conflict branch from 5f326f8 to 280b88c Compare April 22, 2019 23:49
@Ark-kun Ark-kun changed the title [WIP]Fix package version conflict Fix package version conflict Apr 23, 2019
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 23, 2019

/approve

1 similar comment
@IronPan
Copy link
Member

IronPan commented Apr 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 99c40a2 into kubeflow:master Apr 23, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 23, 2019

pip package resolving logic is broken.
The kubernetes package is incompatible with that logic:

$ python3 -m pip install kubernetes==8.0.0
Collecting kubernetes==8.0.0
...

Collecting urllib3!=1.21,>=1.19.1 (from kubernetes==8.0.0)
  Downloading https://files.pythonhosted.org/packages/81/9b/715e96377cc1f87e71d9d4259c6f88bf561a539622ba3042e73188e0bc2d/urllib3-1.25-py2.py3-none-any.whl (149kB)

Collecting requests (from kubernetes==8.0.0)
  Downloading https://files.pythonhosted.org/packages/7d/e3/20f3d364d6c8e5d2353c72a67778eb189176f08e873c9900e10c0287b84b/requests-2.21.0-py2.py3-none-any.whl (57kB)
...

requests 2.21.0 has requirement urllib3<1.25,>=1.21.1, but you'll have urllib3 1.25 which is incompatible.
Installing collected packages: certifi, urllib3, six, idna, chardet, requests, oauthlib, requests-oauthlib, websocket-client, cachetools, pyasn1, rsa, pyasn1-modules, google-auth, pyyaml, asn1crypto, pycparser, cffi, cryptography, PyJWT, python-dateutil, adal, kubernetes
Successfully installed PyJWT-1.7.1 adal-1.2.1 asn1crypto-0.24.0 cachetools-3.1.0 certifi-2019.3.9 cffi-1.12.3 chardet-3.0.4 cryptography-2.6.1 google-auth-1.6.3 idna-2.8 kubernetes-8.0.0 oauthlib-3.0.1 pyasn1-0.4.5 pyasn1-modules-0.2.4 pycparser-2.19 python-dateutil-2.8.0 pyyaml-5.1 requests-2.21.0 requests-oauthlib-1.2.0 rsa-4.0 six-1.12.0 urllib3-1.25 websocket-client-0.56.0

@Ark-kun Ark-kun deleted the Fix-package-version-conflict branch April 23, 2019 01:02
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants