Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing - Stabilize TFX installation using the unstable pip resolver #3810

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented May 21, 2020

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ironpan
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from neuromage May 21, 2020 07:38
@kubeflow-bot
Copy link

This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented May 21, 2020

Thanks @Ark-kun for looking into this!
From test error, looks like this still does not solve it

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 21, 2020

From test error, looks like this still does not solve it

Yes. The new resolver is strict (it fails with a real error when the dependencies cannot be satisfied), but the TFX package is self-inconsistent.

@Ark-kun Ark-kun marked this pull request as draft May 22, 2020 08:35
@Ark-kun Ark-kun closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants